admin-valentin/agent-ecosystem
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: add retry logic to sendInboxMessage for concurrent writes

Browse source 
On Windows, parallel writes to the same inbox file cause race conditions
where atomicWrite verification fails (another process overwrites between
write and verify). Added retry loop (8 attempts) matching the existing
pattern in addTaskComment. Bumps teamctl version to 6.

Fixes CI failure: test (windows-latest) "parallel messages to same inbox"
This commit is contained in:
iliya 2026-02-27 10:45:35 +02:00
parent 1698319443
commit 263c683b42
1 changed files with 19 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

28
src/main/services/team/TeamAgentToolsInstaller.ts
View file

@ -6,7 +6,7 @@ import * as path from 'path';
import { atomicWriteAsync } from './atomicWrite';
const TOOL_FILE_NAME = 'teamctl.js';
const TOOL_VERSION = 10;
const TOOL_VERSION = 11;
function buildTeamCtlScript(): string {
const script = String.raw`#!/usr/bin/env node
@ -420,15 +420,25 @@ function sendInboxMessage(paths, teamName, flags) {
messageId,
};
const existing = readJson(inboxPath, []);
const list = Array.isArray(existing) ? existing : [];
list.push(payload);
atomicWrite(inboxPath, JSON.stringify(list, null, 2));
const verify = readJson(inboxPath, []);
if (!Array.isArray(verify) || !verify.some((m) => m && m.messageId === messageId)) {
die('Inbox write verification failed');
var lastErr;
for (var attempt = 0; attempt < 8; attempt++) {
try {
var existing = readJson(inboxPath, []);
var list = Array.isArray(existing) ? existing : [];
list.push(payload);
atomicWrite(inboxPath, JSON.stringify(list, null, 2));
var verify = readJson(inboxPath, []);
if (Array.isArray(verify) && verify.some(function (m) { return m && m.messageId === messageId; })) {
return { deliveredToInbox: true, messageId: messageId };
}
// Verification failed (concurrent write overwrote us) — retry
} catch (e) {
lastErr = e;
if (attempt === 7) throw e;
}
}
return { deliveredToInbox: true, messageId };
// If all retries exhausted without verification success, die
die('Inbox write verification failed after retries' + (lastErr ? ': ' + formatError(lastErr) : ''));
}
function reviewApprove(paths, teamName, taskId, flags) {