From 31bfd5ebb3ff924bd1b528bd4c1cf144b42468a4 Mon Sep 17 00:00:00 2001 From: 777genius Date: Sat, 16 May 2026 09:15:35 +0300 Subject: [PATCH] fix(opencode): keep Windows marker cleanup conservative --- .../opencode/bridge/OpenCodeManagedHostProcessCleanup.ts | 1 - .../services/team/OpenCodeManagedHostProcessCleanup.test.ts | 6 +++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/src/main/services/team/opencode/bridge/OpenCodeManagedHostProcessCleanup.ts b/src/main/services/team/opencode/bridge/OpenCodeManagedHostProcessCleanup.ts index d684e77b..9e3e8e58 100644 --- a/src/main/services/team/opencode/bridge/OpenCodeManagedHostProcessCleanup.ts +++ b/src/main/services/team/opencode/bridge/OpenCodeManagedHostProcessCleanup.ts @@ -102,7 +102,6 @@ export async function cleanupManagedOpenCodeServeProcesses( isManagedByWindowsCommand || Boolean(details && isManagedOpenCodeServeProcessDetails(details)); const hasRequiredDetailsMarkers = requiredDetailsMarkers.length === 0 || - (isManagedByWindowsCommand && details === null) || Boolean(details && processDetailsIncludeMarkers(details, requiredDetailsMarkers)); if (!isManaged || !hasRequiredDetailsMarkers) { result.candidates.push({ diff --git a/test/main/services/team/OpenCodeManagedHostProcessCleanup.test.ts b/test/main/services/team/OpenCodeManagedHostProcessCleanup.test.ts index 2b9ad444..803d33cf 100644 --- a/test/main/services/team/OpenCodeManagedHostProcessCleanup.test.ts +++ b/test/main/services/team/OpenCodeManagedHostProcessCleanup.test.ts @@ -403,7 +403,7 @@ describe('OpenCodeManagedHostProcessCleanup', () => { expect(result.diagnostics).toEqual([]); }); - it('does not require unreadable Windows details for app-managed command fallback cleanup', async () => { + it('honors required markers when Windows details are unavailable', async () => { const killProcess = vi.fn(); const result = await cleanupManagedOpenCodeServeProcesses({ @@ -425,8 +425,8 @@ describe('OpenCodeManagedHostProcessCleanup', () => { killProcess, }); - expect(killProcess).toHaveBeenCalledWith(71629); - expect(result.candidates[0]).toMatchObject({ pid: 71629, action: 'killed' }); + expect(killProcess).not.toHaveBeenCalled(); + expect(result.candidates[0]).toMatchObject({ pid: 71629, action: 'kept_unmanaged' }); expect(result.diagnostics).toEqual([]); });