refactor: remove console warnings from team-related components for cleaner logging
- Eliminated console warnings in TeamDetailView, GlobalTaskDetailDialog, and TaskDetailDialog to streamline logging and reduce clutter during team data operations. - Updated the selectTeam function in teamSlice to remove unnecessary logging, enhancing performance and readability.
This commit is contained in:
parent
7d575b3383
commit
4644328b93
4 changed files with 1 additions and 39 deletions
|
|
@ -243,7 +243,6 @@ export const TeamDetailView = ({ teamName }: TeamDetailViewProps): React.JSX.Ele
|
|||
if (!teamName) {
|
||||
return;
|
||||
}
|
||||
console.warn(`[TeamDetailView] selectTeam start team=${teamName}`);
|
||||
void selectTeam(teamName);
|
||||
void fetchDeletedTasks(teamName);
|
||||
}, [teamName, selectTeam, fetchDeletedTasks]);
|
||||
|
|
|
|||
|
|
@ -68,22 +68,6 @@ export const GlobalTaskDetailDialog = (): React.JSX.Element | null => {
|
|||
const isThisTeamLoading =
|
||||
selectedTeamName === teamName && selectedTeamLoading && !selectedTeamData;
|
||||
|
||||
useEffect(() => {
|
||||
if (!globalTaskDetail) return;
|
||||
console.warn(
|
||||
`[GlobalTaskDetailDialog] team=${teamName} taskId=${taskId} selectedTeamName=${selectedTeamName ?? ''} loading=${selectedTeamLoading} hasData=${!!selectedTeamData} isFull=${isFullTeamLoaded} isThisTeamLoading=${isThisTeamLoading}`
|
||||
);
|
||||
}, [
|
||||
globalTaskDetail,
|
||||
isFullTeamLoaded,
|
||||
isThisTeamLoading,
|
||||
selectedTeamData,
|
||||
selectedTeamLoading,
|
||||
selectedTeamName,
|
||||
taskId,
|
||||
teamName,
|
||||
]);
|
||||
|
||||
const taskMap = useMemo(() => {
|
||||
const map = new Map<string, TeamTaskWithKanban>();
|
||||
if (!globalTaskDetail) return map;
|
||||
|
|
|
|||
|
|
@ -231,14 +231,6 @@ export const TaskDetailDialog = ({
|
|||
onScrollToTask?.(taskId);
|
||||
};
|
||||
|
||||
useEffect(() => {
|
||||
if (!open) return;
|
||||
if (!loading) return;
|
||||
console.warn(
|
||||
`[TaskDetailDialog] loading=true variant=${variant} team=${teamName} taskId=${task?.id ?? ''}`
|
||||
);
|
||||
}, [loading, open, task?.id, teamName, variant]);
|
||||
|
||||
if (loading) {
|
||||
return (
|
||||
<Dialog open={open} onOpenChange={(v) => !v && onClose()}>
|
||||
|
|
|
|||
|
|
@ -384,18 +384,11 @@ export const createTeamSlice: StateCreator<AppState, [], [], TeamSlice> = (set,
|
|||
reviewActionError: null,
|
||||
});
|
||||
|
||||
const startedAt = Date.now();
|
||||
const traceId = `${teamName}:${startedAt}`;
|
||||
// NOTE: logger.info is not shown by default (level=WARN in dev). Use warn/console.
|
||||
console.warn(
|
||||
`[selectTeam] start trace=${traceId} skipProjectAutoSelect=${opts?.skipProjectAutoSelect === true}`
|
||||
);
|
||||
|
||||
try {
|
||||
const data = await withTimeout(
|
||||
unwrapIpc('team:getData', () => api.teams.getData(teamName)),
|
||||
TEAM_GET_DATA_TIMEOUT_MS,
|
||||
`team:getData(${teamName}) trace=${traceId}`
|
||||
`team:getData(${teamName})`
|
||||
);
|
||||
// Stale check: user may have switched to another team during the async call
|
||||
if (get().selectedTeamName !== teamName) {
|
||||
|
|
@ -408,10 +401,6 @@ export const createTeamSlice: StateCreator<AppState, [], [], TeamSlice> = (set,
|
|||
selectedTeamError: null,
|
||||
});
|
||||
|
||||
console.warn(
|
||||
`[selectTeam] done trace=${traceId} ms=${Date.now() - startedAt} tasks=${data.tasks.length} members=${data.members.length} messages=${data.messages.length}`
|
||||
);
|
||||
|
||||
// Sync tab label with the team's display name from config
|
||||
const displayName = data.config.name || teamName;
|
||||
const allTabs = get().getAllPaneTabs();
|
||||
|
|
@ -471,7 +460,6 @@ export const createTeamSlice: StateCreator<AppState, [], [], TeamSlice> = (set,
|
|||
selectedTeamData: null,
|
||||
selectedTeamError: null,
|
||||
});
|
||||
console.warn(`[selectTeam] provisioning team=${teamName} trace=${traceId}`);
|
||||
return;
|
||||
}
|
||||
|
||||
|
|
@ -481,7 +469,6 @@ export const createTeamSlice: StateCreator<AppState, [], [], TeamSlice> = (set,
|
|||
: error instanceof Error
|
||||
? error.message
|
||||
: 'Failed to fetch team data';
|
||||
console.warn(`[selectTeam] fail team=${teamName} ms=${Date.now() - startedAt} ${message}`);
|
||||
set({
|
||||
selectedTeamLoading: false,
|
||||
selectedTeamData: null,
|
||||
|
|
|
|||
Loading…
Reference in a new issue