feat: add task created notification type

New notification fires when agents create tasks, with toggle in settings.
Follows existing pattern: detect → fire → seed on initial load.
This commit is contained in:
iliya 2026-03-16 14:01:16 +02:00
parent fadd4e04c5
commit 48033ef701
11 changed files with 72 additions and 1 deletions

View file

@ -114,6 +114,7 @@ function validateNotificationsSection(
'snoozeMinutes',
'notifyOnStatusChange',
'notifyOnTaskComments',
'notifyOnTaskCreated',
'statusChangeOnlySolo',
'statusChangeStatuses',
'triggers',
@ -178,6 +179,12 @@ function validateNotificationsSection(
}
result.notifyOnTaskComments = value;
break;
case 'notifyOnTaskCreated':
if (typeof value !== 'boolean') {
return { valid: false, error: `notifications.${key} must be a boolean` };
}
result.notifyOnTaskCreated = value;
break;
case 'statusChangeOnlySolo':
if (typeof value !== 'boolean') {
return { valid: false, error: `notifications.${key} must be a boolean` };

View file

@ -59,6 +59,7 @@ export interface DetectedError {
| 'task_clarification'
| 'task_status_change'
| 'task_comment'
| 'task_created'
| 'schedule_completed'
| 'schedule_failed';
/** Explicit key for storage deduplication. Two notifications with the same dedupeKey won't be stored twice. */

View file

@ -50,6 +50,8 @@ export interface NotificationConfig {
notifyOnStatusChange: boolean;
/** Whether to show native OS notifications when a new comment is added to a task */
notifyOnTaskComments: boolean;
/** Whether to show native OS notifications when a new task is created */
notifyOnTaskCreated: boolean;
/** Only notify on status changes in solo teams (no teammates) */
statusChangeOnlySolo: boolean;
/** Which target statuses to notify about (e.g. ['in_progress', 'completed']) */
@ -264,6 +266,7 @@ const DEFAULT_CONFIG: AppConfig = {
notifyOnClarifications: true,
notifyOnStatusChange: true,
notifyOnTaskComments: true,
notifyOnTaskCreated: true,
statusChangeOnlySolo: false,
statusChangeStatuses: ['in_progress', 'completed'],
triggers: DEFAULT_TRIGGERS,

View file

@ -21,6 +21,7 @@ export type TeamEventType =
| 'task_clarification'
| 'task_status_change'
| 'task_comment'
| 'task_created'
| 'schedule_completed'
| 'schedule_failed';
@ -63,6 +64,7 @@ const TEAM_NOTIFICATION_CONFIG: Record<TeamEventType, TeamNotificationConfig> =
task_clarification: { triggerName: 'Clarification', triggerColor: 'orange' },
task_status_change: { triggerName: 'Status Change', triggerColor: 'purple' },
task_comment: { triggerName: 'Task Comment', triggerColor: 'cyan' },
task_created: { triggerName: 'Task Created', triggerColor: 'green' },
schedule_completed: { triggerName: 'Schedule Done', triggerColor: 'green' },
schedule_failed: { triggerName: 'Schedule Failed', triggerColor: 'red' },
};

View file

@ -47,6 +47,7 @@ export interface SafeConfig {
notifyOnClarifications: boolean;
notifyOnStatusChange: boolean;
notifyOnTaskComments: boolean;
notifyOnTaskCreated: boolean;
statusChangeOnlySolo: boolean;
statusChangeStatuses: string[];
triggers: AppConfig['notifications']['triggers'];
@ -181,6 +182,7 @@ export function useSettingsConfig(): UseSettingsConfigReturn {
notifyOnClarifications: displayConfig?.notifications?.notifyOnClarifications ?? true,
notifyOnStatusChange: displayConfig?.notifications?.notifyOnStatusChange ?? true,
notifyOnTaskComments: displayConfig?.notifications?.notifyOnTaskComments ?? true,
notifyOnTaskCreated: displayConfig?.notifications?.notifyOnTaskCreated ?? true,
statusChangeOnlySolo: displayConfig?.notifications?.statusChangeOnlySolo ?? true,
statusChangeStatuses: displayConfig?.notifications?.statusChangeStatuses ?? [
'in_progress',

View file

@ -300,6 +300,7 @@ export function useSettingsHandlers({
notifyOnClarifications: true,
notifyOnStatusChange: true,
notifyOnTaskComments: true,
notifyOnTaskCreated: true,
statusChangeOnlySolo: true,
statusChangeStatuses: ['in_progress', 'completed'],
triggers: defaultTriggers,

View file

@ -23,6 +23,7 @@ import {
Mail,
MessageSquare,
PartyPopper,
CirclePlus,
Send,
Users,
Volume2,
@ -64,6 +65,7 @@ interface NotificationsSectionProps {
| 'notifyOnClarifications'
| 'notifyOnStatusChange'
| 'notifyOnTaskComments'
| 'notifyOnTaskCreated'
| 'statusChangeOnlySolo',
value: boolean
) => void;
@ -293,6 +295,17 @@ export const NotificationsSection = ({
disabled={saving || !safeConfig.notifications.enabled}
/>
</SettingRow>
<SettingRow
label="Task created notifications"
description="Show native OS notifications when a new task is created"
icon={<CirclePlus className="size-4" />}
>
<SettingsToggle
enabled={safeConfig.notifications.notifyOnTaskCreated}
onChange={(v) => onNotificationToggle('notifyOnTaskCreated', v)}
disabled={saving || !safeConfig.notifications.enabled}
/>
</SettingRow>
{/* Task Status Change Notifications — nested within team card */}
<div className="last:*:border-b-0">

View file

@ -116,6 +116,7 @@ import type { StateCreator } from 'zustand';
const notifiedClarificationTaskKeys = new Set<string>();
const notifiedStatusChangeKeys = new Set<string>();
const notifiedCommentKeys = new Set<string>();
const notifiedCreatedTaskKeys = new Set<string>();
let isFirstFetchAllTasks = true;
@ -295,6 +296,39 @@ function fireTaskCommentNotification(
.catch(() => undefined);
}
function detectTaskCreatedNotifications(
oldTasks: GlobalTask[],
newTasks: GlobalTask[],
notifyEnabled: boolean
): void {
const oldTaskKeys = new Set(oldTasks.map((t) => `${t.teamName}:${t.id}`));
for (const task of newTasks) {
const key = `${task.teamName}:${task.id}`;
if (oldTaskKeys.has(key)) continue;
if (notifiedCreatedTaskKeys.has(key)) continue;
notifiedCreatedTaskKeys.add(key);
fireTaskCreatedNotification(task, !notifyEnabled);
}
}
function fireTaskCreatedNotification(task: GlobalTask, suppressToast: boolean): void {
void api.teams
?.showMessageNotification({
teamName: task.teamName,
teamDisplayName: task.teamDisplayName,
from: task.owner ?? 'system',
to: 'user',
summary: `New task ${formatTaskDisplayLabel(task)}: ${task.subject}`,
body: task.description || task.subject,
teamEventType: 'task_created',
dedupeKey: `created:${task.teamName}:${task.id}`,
suppressToast,
})
.catch(() => undefined);
}
function collectTaskChangeInvalidationState(
teamName: string,
prevTasks: TeamData['tasks'],
@ -852,6 +886,8 @@ export const createTeamSlice: StateCreator<AppState, [], [], TeamSlice> = (set,
detectStatusChangeNotifications(oldTasks, tasks, get().appConfig, get().teamByName);
const notifyOnTaskComments = get().appConfig?.notifications?.notifyOnTaskComments ?? true;
detectTaskCommentNotifications(oldTasks, tasks, notifyOnTaskComments);
const notifyOnTaskCreated = get().appConfig?.notifications?.notifyOnTaskCreated ?? true;
detectTaskCreatedNotifications(oldTasks, tasks, notifyOnTaskCreated);
} else {
// Initial load — seed the Sets to prevent false notifications on next update
for (const task of tasks) {
@ -869,6 +905,8 @@ export const createTeamSlice: StateCreator<AppState, [], [], TeamSlice> = (set,
for (const comment of task.comments ?? []) {
notifiedCommentKeys.add(`${task.teamName}:${task.id}:${comment.id}`);
}
// Seed created task keys to prevent false notifications
notifiedCreatedTaskKeys.add(`${task.teamName}:${task.id}`);
}
}

View file

@ -60,6 +60,7 @@ export interface DetectedError {
| 'task_clarification'
| 'task_status_change'
| 'task_comment'
| 'task_created'
| 'schedule_completed'
| 'schedule_failed';
/** Explicit key for storage deduplication. Two notifications with the same dedupeKey won't be stored twice. */
@ -271,6 +272,8 @@ export interface AppConfig {
notifyOnStatusChange: boolean;
/** Whether to show native OS notifications when a new comment is added to a task */
notifyOnTaskComments: boolean;
/** Whether to show native OS notifications when a new task is created */
notifyOnTaskCreated: boolean;
/** Only notify on status changes in solo teams (no teammates) */
statusChangeOnlySolo: boolean;
/** Which target statuses to notify about (e.g. ['in_progress', 'completed']) */

View file

@ -713,7 +713,7 @@ export interface TeamMessageNotificationData {
/** Optional sender color for visual context. */
color?: string;
/** Team event sub-type for notification categorization. */
teamEventType?: 'task_clarification' | 'task_status_change' | 'task_comment';
teamEventType?: 'task_clarification' | 'task_status_change' | 'task_comment' | 'task_created';
/** Stable key for storage deduplication. Required — no fallback to Date.now(). */
dedupeKey?: string;
/**

View file

@ -93,6 +93,7 @@ describe('buildDetectedErrorFromTeam', () => {
task_clarification: { triggerName: 'Clarification', triggerColor: 'orange' },
task_status_change: { triggerName: 'Status Change', triggerColor: 'purple' },
task_comment: { triggerName: 'Task Comment', triggerColor: 'cyan' },
task_created: { triggerName: 'Task Created', triggerColor: 'green' },
schedule_completed: { triggerName: 'Schedule Done', triggerColor: 'green' },
schedule_failed: { triggerName: 'Schedule Failed', triggerColor: 'red' },
};