admin-valentin/agent-ecosystem
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: remove capTimerMap that silently drops pending refreshes

Browse source 
capTimerMap was cancelling oldest pending throttle/debounce timers
when the Map exceeded a size limit. Since the schedulers don't
replay dropped keys, this silently lost refresh callbacks — leaving
session/team state stale after high-volume file change events.

These Maps are self-cleaning (entries delete themselves when their
callback fires) and hold ~100 bytes per entry. Even 200 entries
is negligible memory. Removing the cap fixes the data freshness
issue without any memory concern.
This commit is contained in:
Artem Rootman 2026-04-05 18:06:31 +00:00
parent a92390dcc6
commit 54198e6598
No known key found for this signature in database
GPG key ID: B7C30676209A822C
1 changed files with 0 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/renderer/store/index.ts
View file

@ -175,19 +175,6 @@ export function initializeNotificationListeners(): () => void {
const TEAM_PRESENCE_REFRESH_THROTTLE_MS = 400; const TEAM_PRESENCE_REFRESH_THROTTLE_MS = 400;
const TEAM_LIST_REFRESH_THROTTLE_MS = 2000; const TEAM_LIST_REFRESH_THROTTLE_MS = 2000;
const GLOBAL_TASKS_REFRESH_THROTTLE_MS = 500; const GLOBAL_TASKS_REFRESH_THROTTLE_MS = 500;
/** Cap a Map at maxSize by clearing oldest entries (FIFO via insertion order). */
const capTimerMap = (map: Map<string, ReturnType<typeof setTimeout>>, maxSize: number): void => {
if (map.size <= maxSize) return;
const excess = map.size - maxSize;
let cleared = 0;
for (const [key, value] of map) {
if (cleared >= excess) break;
clearTimeout(value);
map.delete(key);
cleared++;
}
};
const buildToolActivityTimerKey = ( const buildToolActivityTimerKey = (
teamName: string, teamName: string,
memberName: string, memberName: string,
@ -222,7 +209,6 @@ export function initializeNotificationListeners(): () => void {
cb(); cb();
}, delayMs); }, delayMs);
toolActivityTimers.set(key, timer); toolActivityTimers.set(key, timer);
capTimerMap(toolActivityTimers, 200);
}; };
const clearToolActivityTimersForTeam = (teamName: string): void => { const clearToolActivityTimersForTeam = (teamName: string): void => {
for (const [key, timer] of toolActivityTimers.entries()) { for (const [key, timer] of toolActivityTimers.entries()) {
@ -400,7 +386,6 @@ export function initializeNotificationListeners(): () => void {
void state.refreshSessionInPlace(projectId, sessionId); void state.refreshSessionInPlace(projectId, sessionId);
}, SESSION_REFRESH_DEBOUNCE_MS); }, SESSION_REFRESH_DEBOUNCE_MS);
pendingSessionRefreshTimers.set(key, timer); pendingSessionRefreshTimers.set(key, timer);
capTimerMap(pendingSessionRefreshTimers, 50);
}; };
const scheduleProjectRefresh = (projectId: string): void => { const scheduleProjectRefresh = (projectId: string): void => {
@ -414,7 +399,6 @@ export function initializeNotificationListeners(): () => void {
void state.refreshSessionsInPlace(projectId); void state.refreshSessionsInPlace(projectId);
}, PROJECT_REFRESH_DEBOUNCE_MS); }, PROJECT_REFRESH_DEBOUNCE_MS);
pendingProjectRefreshTimers.set(projectId, timer); pendingProjectRefreshTimers.set(projectId, timer);
capTimerMap(pendingProjectRefreshTimers, 20);
}; };
// Listen for new notifications from main process // Listen for new notifications from main process
@ -959,7 +943,6 @@ export function initializeNotificationListeners(): () => void {
void current.refreshTeamData(event.teamName); void current.refreshTeamData(event.teamName);
}, TEAM_REFRESH_THROTTLE_MS); }, TEAM_REFRESH_THROTTLE_MS);
teamRefreshTimers.set(event.teamName, timer); teamRefreshTimers.set(event.teamName, timer);
capTimerMap(teamRefreshTimers, 20);
return; return;
} }
@ -976,7 +959,6 @@ export function initializeNotificationListeners(): () => void {
void current.refreshSelectedTeamChangePresence(event.teamName); void current.refreshSelectedTeamChangePresence(event.teamName);
}, TEAM_PRESENCE_REFRESH_THROTTLE_MS); }, TEAM_PRESENCE_REFRESH_THROTTLE_MS);
teamPresenceRefreshTimers.set(event.teamName, timer); teamPresenceRefreshTimers.set(event.teamName, timer);
capTimerMap(teamPresenceRefreshTimers, 20);
return; return;
} }
@ -1012,7 +994,6 @@ export function initializeNotificationListeners(): () => void {
void current.refreshTeamData(event.teamName); void current.refreshTeamData(event.teamName);
}, TEAM_REFRESH_THROTTLE_MS); }, TEAM_REFRESH_THROTTLE_MS);
teamRefreshTimers.set(event.teamName, timer); teamRefreshTimers.set(event.teamName, timer);
capTimerMap(teamRefreshTimers, 20);
}); });
if (typeof cleanup === 'function') { if (typeof cleanup === 'function') {