admin-valentin/agent-ecosystem
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

test(opencode): cover local mcp fallback with http

Browse source
This commit is contained in:
777genius 2026-05-16 23:56:43 +03:00
parent 44e760007a
commit 71ad9e53e7
3 changed files with 42 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/main/index.ts
View file

@ -72,6 +72,7 @@ import {
copyOpenCodeLocalMcpLaunchEnv,
hasOpenCodeLocalMcpLaunchEnv,
isOpenCodeMcpHttpBridgeEnabled,
shouldEnsureOpenCodeLocalMcpLaunchEnv,
snapshotOpenCodeLocalMcpLaunchEnv,
} from '@main/services/team/opencode/bridge/OpenCodeMcpBridgeEnv';
import { ReviewApplierService } from '@main/services/team/ReviewApplierService';
@ -450,7 +451,12 @@ async function createOpenCodeRuntimeAdapterRegistry(
);
}
}
if (useHttpMcpBridge || !bridgeEnv.CLAUDE_MULTIMODEL_AGENT_TEAMS_MCP_URL) {
if (
shouldEnsureOpenCodeLocalMcpLaunchEnv({
httpBridgeEnabled: useHttpMcpBridge,
mcpUrl: bridgeEnv.CLAUDE_MULTIMODEL_AGENT_TEAMS_MCP_URL,
})
) {
await ensureOpenCodeLocalMcpLaunchEnv(bridgeEnv, { emitProgress: true });
}

7
src/main/services/team/opencode/bridge/OpenCodeMcpBridgeEnv.ts
View file

@ -17,6 +17,13 @@ export function hasOpenCodeLocalMcpLaunchEnv(env: OpenCodeMcpBridgeEnv): boolean
return LOCAL_MCP_LAUNCH_ENV_KEYS.every((key) => Boolean(env[key]?.trim()));
}
export function shouldEnsureOpenCodeLocalMcpLaunchEnv(input: {
httpBridgeEnabled: boolean;
mcpUrl: string | undefined;
}): boolean {
return input.httpBridgeEnabled || !input.mcpUrl?.trim();
}
export function copyOpenCodeLocalMcpLaunchEnv(
sourceEnv: OpenCodeMcpBridgeEnv,
targetEnv: OpenCodeMcpBridgeEnv

30
test/main/services/team/OpenCodeMcpBridgeEnv.test.ts
View file

@ -5,6 +5,7 @@ import {
copyOpenCodeLocalMcpLaunchEnv,
hasOpenCodeLocalMcpLaunchEnv,
isOpenCodeMcpHttpBridgeEnabled,
shouldEnsureOpenCodeLocalMcpLaunchEnv,
snapshotOpenCodeLocalMcpLaunchEnv,
} from '@main/services/team/opencode/bridge/OpenCodeMcpBridgeEnv';
@ -70,7 +71,32 @@ describe('OpenCodeMcpBridgeEnv', () => {
expect(target.CLAUDE_MULTIMODEL_AGENT_TEAMS_MCP_URL).toBe('http://127.0.0.1:41001/mcp');
});
it('snapshots explicit local MCP launch env before HTTP mode clears it', () => {
it('resolves local MCP launch env even when HTTP MCP already has a URL', () => {
expect(
shouldEnsureOpenCodeLocalMcpLaunchEnv({
httpBridgeEnabled: true,
mcpUrl: 'http://127.0.0.1:41001/mcp',
})
).toBe(true);
});
it('skips local MCP launch env only when HTTP bridge is disabled and a URL already exists', () => {
expect(
shouldEnsureOpenCodeLocalMcpLaunchEnv({
httpBridgeEnabled: false,
mcpUrl: 'http://127.0.0.1:41001/mcp',
})
).toBe(false);
expect(
shouldEnsureOpenCodeLocalMcpLaunchEnv({
httpBridgeEnabled: false,
mcpUrl: undefined,
})
).toBe(true);
});
it('snapshots explicit local MCP launch env before mutating an env object', () => {
const env: NodeJS.ProcessEnv = {
CLAUDE_MULTIMODEL_AGENT_TEAMS_MCP_COMMAND: ' node ',
CLAUDE_MULTIMODEL_AGENT_TEAMS_MCP_ENTRY: ' mcp-server/dist/index.js ',
@ -90,7 +116,7 @@ describe('OpenCodeMcpBridgeEnv', () => {
expect(env.CLAUDE_MULTIMODEL_AGENT_TEAMS_MCP_COMMAND).toBeUndefined();
});
it('removes local MCP launch env when HTTP MCP is active', () => {
it('removes local MCP launch env when explicitly requested', () => {
const env: NodeJS.ProcessEnv = {
CLAUDE_MULTIMODEL_AGENT_TEAMS_MCP_COMMAND: 'node',
CLAUDE_MULTIMODEL_AGENT_TEAMS_MCP_ENTRY: 'mcp-server/dist/index.js',