admin-valentin/agent-ecosystem
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(team): trust permission request ids in launch copy

Browse source
This commit is contained in:
777genius 2026-04-23 02:30:04 +03:00
parent 146b839b9c
commit 842a929a83
2 changed files with 68 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/renderer/utils/teamProvisioningPresentation.ts
View file

@ -41,7 +41,11 @@ function countPermissionBlockedMembers(memberSpawnStatuses: MemberSpawnStatusCol
? [...memberSpawnStatuses.values()]
: Object.values(memberSpawnStatuses);
return entries.filter((entry) => entry.launchState === 'runtime_pending_permission').length;
return entries.filter(
(entry) =>
entry.launchState === 'runtime_pending_permission' ||
(entry.pendingPermissionRequestIds?.length ?? 0) > 0
).length;
}
function buildAwaitingPermissionPhrase(count: number): string {

63
test/renderer/utils/teamProvisioningPresentation.test.ts
View file

@ -397,6 +397,69 @@ describe('buildTeamProvisioningPresentation', () => {
expect(presentation?.panelMessage).toBe('1 teammate awaiting permission approval');
});
it('trusts pending permission request ids even before launchState flips to runtime_pending_permission', () => {
const presentation = buildTeamProvisioningPresentation({
progress: {
runId: 'run-4e',
teamName: 'opencode-team',
state: 'finalizing',
startedAt: '2026-04-13T10:00:00.000Z',
updatedAt: '2026-04-13T10:00:08.000Z',
message: 'Waiting for runtime confirmation',
messageSeverity: undefined,
pid: 4321,
cliLogsTail: '',
assistantOutput: '',
},
members: [
{
name: 'team-lead',
agentType: 'team-lead',
status: 'active',
currentTaskId: null,
taskCount: 0,
lastActiveAt: null,
messageCount: 0,
},
{
name: 'bob',
agentType: 'engineer',
status: 'unknown',
currentTaskId: null,
taskCount: 0,
lastActiveAt: null,
messageCount: 0,
},
],
memberSpawnStatuses: {
bob: {
status: 'online',
launchState: 'runtime_pending_bootstrap',
updatedAt: '2026-04-13T10:00:07.000Z',
runtimeAlive: true,
livenessSource: 'process',
bootstrapConfirmed: false,
hardFailure: false,
agentToolAccepted: true,
pendingPermissionRequestIds: ['perm_1'],
firstSpawnAcceptedAt: '2026-04-13T10:00:01.000Z',
},
},
memberSpawnSnapshot: {
expectedMembers: ['bob'],
summary: {
confirmedCount: 0,
pendingCount: 1,
failedCount: 0,
runtimeAlivePendingCount: 1,
},
},
});
expect(presentation?.compactDetail).toBe('1 teammate awaiting permission approval');
expect(presentation?.panelMessage).toBe('1 teammate awaiting permission approval');
});
it('keeps a generic failed teammate message while launch is still active if only persisted failure counts remain', () => {
const presentation = buildTeamProvisioningPresentation({
progress: {