From 927c8b5c30210112d62c4351604b70e74dd04f60 Mon Sep 17 00:00:00 2001 From: iliya Date: Thu, 19 Mar 2026 19:10:32 +0200 Subject: [PATCH] refactor: clean up legacy code and improve import statements in ApiKeyService and CliInstallerService - Removed legacy comments and fields in ApiKeyService to streamline code. - Updated import statements in CliInstallerService for better organization. --- src/main/services/extensions/apikeys/ApiKeyService.ts | 3 --- src/main/services/infrastructure/CliInstallerService.ts | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/src/main/services/extensions/apikeys/ApiKeyService.ts b/src/main/services/extensions/apikeys/ApiKeyService.ts index 790eaa45..f72564d7 100644 --- a/src/main/services/extensions/apikeys/ApiKeyService.ts +++ b/src/main/services/extensions/apikeys/ApiKeyService.ts @@ -100,7 +100,6 @@ export class ApiKeyService { scope: request.scope, updatedAt: now, }; - // Remove legacy field delete keys[idx].encrypted; } else { keys.push({ @@ -232,7 +231,6 @@ export class ApiKeyService { /** Resolve encryption method, handling legacy entries without encryptionMethod field */ private resolveMethod(stored: StoredApiKey): EncryptionMethod { if (stored.encryptionMethod) return stored.encryptionMethod; - // Legacy migration: encrypted boolean → method return stored.encrypted ? 'safeStorage' : 'base64'; } @@ -266,7 +264,6 @@ export class ApiKeyService { const candidates = ['/etc/machine-id', '/var/lib/dbus/machine-id']; for (const p of candidates) { try { - // Synchronous read is OK — called once, result cached in aesKey const { readFileSync } = require('node:fs') as typeof import('node:fs'); const id = readFileSync(p, 'utf-8').trim(); if (id) return id; diff --git a/src/main/services/infrastructure/CliInstallerService.ts b/src/main/services/infrastructure/CliInstallerService.ts index 179ae0af..70ccbd8a 100644 --- a/src/main/services/infrastructure/CliInstallerService.ts +++ b/src/main/services/infrastructure/CliInstallerService.ts @@ -23,7 +23,7 @@ import { getCachedShellEnv } from '@main/utils/shellEnv'; import { getErrorMessage } from '@shared/utils/errorHandling'; import { createLogger } from '@shared/utils/logger'; import { createHash } from 'crypto'; -import { createWriteStream, existsSync, realpathSync, promises as fsp } from 'fs'; +import { createWriteStream, existsSync, promises as fsp, realpathSync } from 'fs'; import http from 'http'; import https from 'https'; import { tmpdir } from 'os';