+
+
+
+ From comments
+
{items.map((item) => (
diff --git a/src/renderer/components/team/kanban/KanbanBoard.tsx b/src/renderer/components/team/kanban/KanbanBoard.tsx
index 1728a6e4..68cd000f 100644
--- a/src/renderer/components/team/kanban/KanbanBoard.tsx
+++ b/src/renderer/components/team/kanban/KanbanBoard.tsx
@@ -37,28 +37,28 @@ const COLUMN_ACCENTS: Record<
{ headerBg: string; bodyBg: string; icon: React.ReactNode }
> = {
todo: {
- headerBg: 'rgba(59, 130, 246, 0.12)',
- bodyBg: 'rgba(59, 130, 246, 0.05)',
+ headerBg: 'rgba(59, 130, 246, 0.15)',
+ bodyBg: 'rgba(59, 130, 246, 0.015)',
icon:
,
},
in_progress: {
- headerBg: 'rgba(234, 179, 8, 0.14)',
- bodyBg: 'rgba(234, 179, 8, 0.06)',
+ headerBg: 'rgba(234, 179, 8, 0.18)',
+ bodyBg: 'rgba(234, 179, 8, 0.018)',
icon:
,
},
done: {
- headerBg: 'rgba(34, 197, 94, 0.12)',
- bodyBg: 'rgba(34, 197, 94, 0.05)',
+ headerBg: 'rgba(34, 197, 94, 0.15)',
+ bodyBg: 'rgba(34, 197, 94, 0.015)',
icon:
,
},
review: {
- headerBg: 'rgba(139, 92, 246, 0.12)',
- bodyBg: 'rgba(139, 92, 246, 0.05)',
+ headerBg: 'rgba(139, 92, 246, 0.15)',
+ bodyBg: 'rgba(139, 92, 246, 0.015)',
icon:
,
},
approved: {
- headerBg: 'rgba(34, 197, 94, 0.24)',
- bodyBg: 'rgba(34, 197, 94, 0.11)',
+ headerBg: 'rgba(34, 197, 94, 0.28)',
+ bodyBg: 'rgba(34, 197, 94, 0.033)',
icon:
,
},
};
diff --git a/src/renderer/components/team/kanban/KanbanColumn.tsx b/src/renderer/components/team/kanban/KanbanColumn.tsx
index e883e281..68db2d03 100644
--- a/src/renderer/components/team/kanban/KanbanColumn.tsx
+++ b/src/renderer/components/team/kanban/KanbanColumn.tsx
@@ -47,7 +47,7 @@ export const KanbanColumn = ({
)}
{
const [jsonEditorOpen, setJsonEditorOpen] = useState(false);
const [jsonText, setJsonText] = useState('');
@@ -158,7 +161,10 @@ export const MembersEditorSection = ({
const names = members.map((m) => m.name.trim().toLowerCase()).filter(Boolean);
const hasDuplicates = new Set(names).size !== names.length;
- const memberColorMap = useMemo(() => buildMemberDraftColorMap(members), [members]);
+ const memberColorMap = useMemo(
+ () => buildMemberDraftColorMap(members, existingMembers),
+ [members, existingMembers]
+ );
const mentionSuggestions = useMemo(
() => buildMemberDraftSuggestions(members, memberColorMap),
diff --git a/src/renderer/components/team/members/membersEditorUtils.ts b/src/renderer/components/team/members/membersEditorUtils.ts
index 55031085..8bafddc2 100644
--- a/src/renderer/components/team/members/membersEditorUtils.ts
+++ b/src/renderer/components/team/members/membersEditorUtils.ts
@@ -36,15 +36,37 @@ export function createMemberDraft(initial?: Partial): MemberDraft {
};
}
+interface ExistingMemberColorInput {
+ name: string;
+ color?: string;
+ removedAt?: number | string | null;
+}
+
export function buildMemberDraftColorMap(
- members: readonly Pick[]
+ members: readonly Pick[],
+ existingMembers?: readonly ExistingMemberColorInput[]
): Map {
- return buildMemberColorMap(
- members
- .map((member) => member.name.trim())
- .filter(Boolean)
- .map((name) => ({ name }))
- );
+ const draftEntries = members
+ .map((member) => member.name.trim())
+ .filter(Boolean)
+ .map((name) => ({ name }));
+
+ // When existing members are provided, include them first so their colors
+ // are reserved and new drafts receive the next available palette entries.
+ const allEntries = existingMembers ? [...existingMembers, ...draftEntries] : draftEntries;
+
+ const fullMap = buildMemberColorMap(allEntries);
+
+ // Return only draft entries so callers don't see existing-member keys
+ // they didn't ask for (keeps the API surface unchanged).
+ if (!existingMembers) return fullMap;
+
+ const draftMap = new Map();
+ for (const entry of draftEntries) {
+ const color = fullMap.get(entry.name);
+ if (color) draftMap.set(entry.name, color);
+ }
+ return draftMap;
}
/** Resolves a MemberDraft's role selection to a display string. */
diff --git a/src/renderer/components/team/messages/MessageComposer.tsx b/src/renderer/components/team/messages/MessageComposer.tsx
index 1d3a610a..30902e9d 100644
--- a/src/renderer/components/team/messages/MessageComposer.tsx
+++ b/src/renderer/components/team/messages/MessageComposer.tsx
@@ -257,6 +257,13 @@ export const MessageComposer = ({
// );
const supportsAttachments = isLeadRecipient && !isCrossTeam && !!isTeamAlive;
const canAttach = supportsAttachments && draft.canAddMore;
+ const attachmentRestrictionReason = !supportsAttachments
+ ? isCrossTeam
+ ? 'File attachments are not supported for cross-team messages'
+ : !isLeadRecipient
+ ? 'Files can only be sent to the team lead'
+ : 'Team must be online to attach files'
+ : undefined;
const attachmentsBlocked = draft.attachments.length > 0 && !supportsAttachments;
const canSend =
recipient.length > 0 &&
@@ -332,12 +339,14 @@ export const MessageComposer = ({
);
const showFileRestrictionError = useCallback(() => {
- setFileRestrictionError('Files can only be sent to the team lead');
+ setFileRestrictionError(
+ attachmentRestrictionReason ?? 'Files can only be sent to the team lead'
+ );
window.clearTimeout(fileRestrictionTimerRef.current);
fileRestrictionTimerRef.current = window.setTimeout(() => {
setFileRestrictionError(null);
}, 4000);
- }, []);
+ }, [attachmentRestrictionReason]);
// Cleanup restriction error timer on unmount
useEffect(() => {
@@ -841,7 +850,11 @@ export const MessageComposer = ({
-
+
]*>[\s\S]*?<\/teammate-message>/g;
+
+/**
+ * Removes `` XML blocks from text.
+ * Used to clean protocol artifacts that leak into lead thoughts.
+ */
+export function stripTeammateMessageBlocks(text: string): string {
+ return text
+ .replace(TEAMMATE_MESSAGE_BLOCK_RE, '\n')
+ .replace(/\n{3,}/g, '\n\n')
+ .trim();
+}
+
+/**
+ * Returns true if the entire text consists only of `` blocks
+ * (possibly with whitespace between them) and no meaningful user-visible content.
+ */
+export function isOnlyTeammateMessageBlocks(text: string): boolean {
+ const stripped = stripTeammateMessageBlocks(text);
+ return stripped.length === 0;
+}
+
+// ---------------------------------------------------------------------------
+// Combined protocol noise check for lead thoughts
+// ---------------------------------------------------------------------------
+
+/**
+ * Returns true if a lead thought text is entirely protocol noise and should
+ * be hidden from the user. Covers:
+ * 1. Structured JSON noise (idle_notification, shutdown_*, etc.)
+ * 2. Text that consists solely of `` XML blocks
+ */
+export function isThoughtProtocolNoise(text: string): boolean {
+ if (isInboxNoiseMessage(text)) return true;
+ if (isOnlyTeammateMessageBlocks(text)) return true;
+ return false;
+}
diff --git a/test/main/services/schedule/ScheduledTaskExecutor.test.ts b/test/main/services/schedule/ScheduledTaskExecutor.test.ts
index 6c682b6a..2b4fe5f7 100644
--- a/test/main/services/schedule/ScheduledTaskExecutor.test.ts
+++ b/test/main/services/schedule/ScheduledTaskExecutor.test.ts
@@ -26,6 +26,10 @@ vi.mock('@main/utils/shellEnv', () => ({
resolveInteractiveShellEnv: () => mockResolveShellEnv(),
}));
+vi.mock('@main/utils/cliEnv', () => ({
+ buildEnrichedEnv: () => ({ ...process.env }),
+}));
+
vi.mock('../../../../src/main/services/team/ClaudeBinaryResolver', () => ({
ClaudeBinaryResolver: {
resolve: () => mockResolve(),
diff --git a/test/renderer/components/team/activity/LeadThoughtsGroup.test.ts b/test/renderer/components/team/activity/LeadThoughtsGroup.test.ts
index 4663d981..526938cd 100644
--- a/test/renderer/components/team/activity/LeadThoughtsGroup.test.ts
+++ b/test/renderer/components/team/activity/LeadThoughtsGroup.test.ts
@@ -15,4 +15,69 @@ describe('LeadThoughtsGroup', () => {
})
).toBe(false);
});
+
+ it('filters out idle_notification JSON noise from lead thoughts', () => {
+ expect(
+ isLeadThought({
+ from: 'team-lead',
+ text: '{"type":"idle_notification","message":"alice is idle"}',
+ timestamp: '2026-03-08T00:00:00.000Z',
+ read: true,
+ source: 'lead_session',
+ })
+ ).toBe(false);
+ });
+
+ it('filters out shutdown_request JSON noise from lead thoughts', () => {
+ expect(
+ isLeadThought({
+ from: 'team-lead',
+ text: '{"type":"shutdown_request","reason":"Task complete"}',
+ timestamp: '2026-03-08T00:00:00.000Z',
+ read: true,
+ source: 'lead_process',
+ })
+ ).toBe(false);
+ });
+
+ it('filters out pure XML blocks from lead thoughts', () => {
+ expect(
+ isLeadThought({
+ from: 'team-lead',
+ text: 'Task completed',
+ timestamp: '2026-03-08T00:00:00.000Z',
+ read: true,
+ source: 'lead_session',
+ })
+ ).toBe(false);
+ });
+
+ it('filters out multiple blocks with whitespace', () => {
+ const text = [
+ 'Hello',
+ '',
+ 'OK',
+ ].join('\n');
+ expect(
+ isLeadThought({
+ from: 'team-lead',
+ text,
+ timestamp: '2026-03-08T00:00:00.000Z',
+ read: true,
+ source: 'lead_process',
+ })
+ ).toBe(false);
+ });
+
+ it('keeps normal lead thoughts with real content', () => {
+ expect(
+ isLeadThought({
+ from: 'team-lead',
+ text: 'Reviewing the implementation plan for the new feature.',
+ timestamp: '2026-03-08T00:00:00.000Z',
+ read: true,
+ source: 'lead_session',
+ })
+ ).toBe(true);
+ });
});
diff --git a/test/shared/utils/inboxNoise.test.ts b/test/shared/utils/inboxNoise.test.ts
new file mode 100644
index 00000000..cda94fff
--- /dev/null
+++ b/test/shared/utils/inboxNoise.test.ts
@@ -0,0 +1,126 @@
+import { describe, expect, it } from 'vitest';
+
+import {
+ isInboxNoiseMessage,
+ isOnlyTeammateMessageBlocks,
+ isThoughtProtocolNoise,
+ stripTeammateMessageBlocks,
+} from '../../../src/shared/utils/inboxNoise';
+
+describe('stripTeammateMessageBlocks', () => {
+ it('removes a single teammate-message block', () => {
+ const text =
+ 'Hello world';
+ expect(stripTeammateMessageBlocks(text)).toBe('');
+ });
+
+ it('removes multiple teammate-message blocks', () => {
+ const text = [
+ 'Hello',
+ 'OK',
+ ].join('\n');
+ expect(stripTeammateMessageBlocks(text)).toBe('');
+ });
+
+ it('preserves normal text around teammate-message blocks', () => {
+ const text =
+ 'Before\nHello\nAfter';
+ expect(stripTeammateMessageBlocks(text)).toBe('Before\n\nAfter');
+ });
+
+ it('returns text unchanged when no blocks are present', () => {
+ const text = 'Just some normal text without protocol blocks.';
+ expect(stripTeammateMessageBlocks(text)).toBe(text);
+ });
+});
+
+describe('isOnlyTeammateMessageBlocks', () => {
+ it('returns true for a single block', () => {
+ expect(
+ isOnlyTeammateMessageBlocks(
+ 'Hello'
+ )
+ ).toBe(true);
+ });
+
+ it('returns true for multiple blocks with whitespace', () => {
+ const text = [
+ 'X',
+ ' ',
+ 'Y',
+ ].join('\n');
+ expect(isOnlyTeammateMessageBlocks(text)).toBe(true);
+ });
+
+ it('returns false when there is also regular text', () => {
+ const text =
+ 'Hello\nX';
+ expect(isOnlyTeammateMessageBlocks(text)).toBe(false);
+ });
+
+ it('returns false for plain text', () => {
+ expect(isOnlyTeammateMessageBlocks('Just a normal message')).toBe(false);
+ });
+});
+
+describe('isThoughtProtocolNoise', () => {
+ it('detects idle_notification JSON', () => {
+ expect(
+ isThoughtProtocolNoise('{"type":"idle_notification","message":"alice is idle"}')
+ ).toBe(true);
+ });
+
+ it('detects shutdown_request JSON', () => {
+ expect(
+ isThoughtProtocolNoise('{"type":"shutdown_request","reason":"done"}')
+ ).toBe(true);
+ });
+
+ it('detects shutdown_approved JSON', () => {
+ expect(isThoughtProtocolNoise('{"type":"shutdown_approved"}')).toBe(true);
+ });
+
+ it('detects teammate_terminated JSON', () => {
+ expect(isThoughtProtocolNoise('{"type":"teammate_terminated"}')).toBe(true);
+ });
+
+ it('detects pure teammate-message XML', () => {
+ expect(
+ isThoughtProtocolNoise(
+ 'Hello'
+ )
+ ).toBe(true);
+ });
+
+ it('returns false for normal text', () => {
+ expect(isThoughtProtocolNoise('Reviewing the PR now.')).toBe(false);
+ });
+
+ it('returns false for non-noise JSON', () => {
+ expect(
+ isThoughtProtocolNoise('{"type":"message","message":"Hello from lead"}')
+ ).toBe(false);
+ });
+
+ it('returns false for text with teammate-message mixed with content', () => {
+ expect(
+ isThoughtProtocolNoise(
+ 'Starting work.\nX'
+ )
+ ).toBe(false);
+ });
+});
+
+describe('isInboxNoiseMessage', () => {
+ it('detects idle_notification', () => {
+ expect(isInboxNoiseMessage('{"type":"idle_notification"}')).toBe(true);
+ });
+
+ it('does not flag regular JSON messages', () => {
+ expect(isInboxNoiseMessage('{"type":"message","text":"hi"}')).toBe(false);
+ });
+
+ it('does not flag plain text', () => {
+ expect(isInboxNoiseMessage('Hello world')).toBe(false);
+ });
+});