admin-valentin/agent-ecosystem
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(team): surface permission-blocked launch state in graph

Browse source
This commit is contained in:
777genius 2026-04-23 01:13:17 +03:00
parent cfc50df5a1
commit a123b2e247
2 changed files with 36 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
src/features/agent-graph/renderer/adapters/TeamGraphAdapter.ts
View file

@ -518,7 +518,7 @@ export class TeamGraphAdapter {
label: member.name, label: member.name,
state: hasRunningTool state: hasRunningTool
? 'tool_calling' ? 'tool_calling'
: TeamGraphAdapter.#mapMemberStatus(member.status, spawn?.status), : TeamGraphAdapter.#mapMemberStatus(member.status, spawn),
color: member.color ?? undefined, color: member.color ?? undefined,
role: member.role ?? undefined, role: member.role ?? undefined,
runtimeLabel: TeamGraphAdapter.#getRuntimeLabel( runtimeLabel: TeamGraphAdapter.#getRuntimeLabel(
@ -1128,7 +1128,7 @@ export class TeamGraphAdapter {
if (spawn?.launchState === 'failed_to_start' || spawn?.status === 'error') { if (spawn?.launchState === 'failed_to_start' || spawn?.status === 'error') {
return { exceptionTone: 'error', exceptionLabel: 'spawn failed' }; return { exceptionTone: 'error', exceptionLabel: 'spawn failed' };
} }
if (pendingApproval) { if (pendingApproval || spawn?.launchState === 'runtime_pending_permission') {
return { exceptionTone: 'warning', exceptionLabel: 'awaiting approval' }; return { exceptionTone: 'warning', exceptionLabel: 'awaiting approval' };
} }
if (spawn?.status === 'waiting' || spawn?.status === 'spawning') { if (spawn?.status === 'waiting' || spawn?.status === 'spawning') {
@ -1144,10 +1144,11 @@ export class TeamGraphAdapter {
return undefined; return undefined;
} }
static #mapMemberStatus(status: string, spawnStatus?: string): GraphNodeState { static #mapMemberStatus(status: string, spawn?: MemberSpawnStatusEntry): GraphNodeState {
if (spawnStatus === 'spawning') return 'thinking'; if (spawn?.launchState === 'runtime_pending_permission') return 'waiting';
if (spawnStatus === 'error') return 'error'; if (spawn?.status === 'spawning') return 'thinking';
if (spawnStatus === 'waiting') return 'waiting'; if (spawn?.status === 'error') return 'error';
if (spawn?.status === 'waiting') return 'waiting';
switch (status) { switch (status) {
case 'active': case 'active':
return 'active'; return 'active';

29
test/renderer/features/agent-graph/TeamGraphAdapter.test.ts
View file

@ -1360,6 +1360,35 @@ describe('TeamGraphAdapter particles', () => {
}); });
}); });
it('treats permission-blocked spawn state as awaiting approval even without pending approval feed', () => {
const adapter = TeamGraphAdapter.create();
const teamData = createBaseTeamData();
adapter.adapt(teamData, 'my-team');
const graph = adapter.adapt(teamData, 'my-team', {
alice: {
status: 'online',
launchState: 'runtime_pending_permission',
runtimeAlive: true,
agentToolAccepted: true,
bootstrapConfirmed: false,
hardFailure: false,
updatedAt: '2026-04-08T20:00:00.000Z',
},
});
expect(findNode(graph, 'member:my-team:alice')).toMatchObject({
state: 'waiting',
spawnStatus: 'online',
launchVisualState: 'permission_pending',
launchStatusLabel: 'awaiting permission',
exceptionTone: 'warning',
exceptionLabel: 'awaiting approval',
pendingApproval: false,
});
});
it('refreshes unread comment badges when comment read state changes without task changes', () => { it('refreshes unread comment badges when comment read state changes without task changes', () => {
const adapter = TeamGraphAdapter.create(); const adapter = TeamGraphAdapter.create();
const teamData = createBaseTeamData({ const teamData = createBaseTeamData({