admin-valentin/agent-ecosystem
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: use content fingerprint for stale check instead of computedAt

Browse source 
computedAt is regenerated on each cache miss, causing false positives
when the review data hasn't actually changed. Compare file count, line
counts, and file paths instead.
This commit is contained in:
iliya 2026-02-24 23:48:14 +02:00
parent 2123dfb780
commit ada5d8359a
1 changed files with 13 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
src/renderer/store/slices/changeReviewSlice.ts
View file

@ -263,13 +263,20 @@ export const createChangeReviewSlice: StateCreator<AppState, [], [], ChangeRevie
set({ applying: true, applyError: null });
try {
// Stale check: re-fetch changes and compare computedAt
// Stale check: re-fetch changes and compare content fingerprint
const state = get();
const currentComputedAt = state.activeChangeSet?.computedAt;
const current = state.activeChangeSet;
const fingerprint = (cs: {
totalFiles: number;
totalLinesAdded: number;
totalLinesRemoved: number;
files: { filePath: string }[];
}) =>
`${cs.totalFiles}:${cs.totalLinesAdded}:${cs.totalLinesRemoved}:${cs.files.map((f) => f.filePath).join(',')}`;
if (memberName) {
if (memberName && current) {
const fresh = await api.review.getAgentChanges(teamName, memberName);
if (fresh.computedAt !== currentComputedAt) {
if (fingerprint(fresh) !== fingerprint(current)) {
set({
activeChangeSet: fresh,
applying: false,
@ -277,9 +284,9 @@ export const createChangeReviewSlice: StateCreator<AppState, [], [], ChangeRevie
});
return;
}
} else if (taskId) {
} else if (taskId && current) {
const fresh = await api.review.getTaskChanges(teamName, taskId);
if (fresh.computedAt !== currentComputedAt) {
if (fingerprint(fresh) !== fingerprint(current)) {
set({
activeChangeSet: fresh,
applying: false,