fix(team): keep persisted launch failure details visible
This commit is contained in:
parent
e309eb8a0d
commit
b955901e15
2 changed files with 101 additions and 13 deletions
|
|
@ -86,25 +86,46 @@ const ACTIVE_PROVISIONING_STATES = new Set([
|
||||||
'verifying',
|
'verifying',
|
||||||
]);
|
]);
|
||||||
|
|
||||||
function getFailedSpawnDetails(
|
function getFailedSpawnDetails(params: {
|
||||||
memberSpawnStatuses: MemberSpawnStatusCollection
|
memberSpawnStatuses: MemberSpawnStatusCollection;
|
||||||
): FailedSpawnDetail[] {
|
memberSpawnSnapshotStatuses?: MemberSpawnStatusesSnapshot['statuses'];
|
||||||
if (!memberSpawnStatuses) {
|
}): FailedSpawnDetail[] {
|
||||||
|
const names = new Set<string>();
|
||||||
|
if (params.memberSpawnStatuses instanceof Map) {
|
||||||
|
for (const name of params.memberSpawnStatuses.keys()) {
|
||||||
|
names.add(name);
|
||||||
|
}
|
||||||
|
} else if (params.memberSpawnStatuses) {
|
||||||
|
for (const name of Object.keys(params.memberSpawnStatuses)) {
|
||||||
|
names.add(name);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
for (const name of Object.keys(params.memberSpawnSnapshotStatuses ?? {})) {
|
||||||
|
names.add(name);
|
||||||
|
}
|
||||||
|
|
||||||
|
if (names.size === 0) {
|
||||||
return [];
|
return [];
|
||||||
}
|
}
|
||||||
const entries =
|
|
||||||
memberSpawnStatuses instanceof Map
|
|
||||||
? [...memberSpawnStatuses.entries()]
|
|
||||||
: Object.entries(memberSpawnStatuses);
|
|
||||||
|
|
||||||
return entries
|
return [...names]
|
||||||
.filter(([, entry]) => entry.launchState === 'failed_to_start' || entry.status === 'error')
|
.map((name) => {
|
||||||
|
const liveEntry =
|
||||||
|
params.memberSpawnStatuses instanceof Map
|
||||||
|
? params.memberSpawnStatuses.get(name)
|
||||||
|
: params.memberSpawnStatuses?.[name];
|
||||||
|
const snapshotEntry = params.memberSpawnSnapshotStatuses?.[name];
|
||||||
|
return [name, liveEntry ?? snapshotEntry] as const;
|
||||||
|
})
|
||||||
|
.filter(
|
||||||
|
([, entry]) => entry && (entry.launchState === 'failed_to_start' || entry.status === 'error')
|
||||||
|
)
|
||||||
.map(([name, entry]) => ({
|
.map(([name, entry]) => ({
|
||||||
name,
|
name,
|
||||||
reason:
|
reason:
|
||||||
typeof entry.hardFailureReason === 'string' && entry.hardFailureReason.trim().length > 0
|
typeof entry?.hardFailureReason === 'string' && entry.hardFailureReason.trim().length > 0
|
||||||
? entry.hardFailureReason.trim()
|
? entry.hardFailureReason.trim()
|
||||||
: typeof entry.error === 'string' && entry.error.trim().length > 0
|
: typeof entry?.error === 'string' && entry.error.trim().length > 0
|
||||||
? entry.error.trim()
|
? entry.error.trim()
|
||||||
: null,
|
: null,
|
||||||
}))
|
}))
|
||||||
|
|
@ -241,7 +262,10 @@ export function buildTeamProvisioningPresentation({
|
||||||
memberSpawnStatuses,
|
memberSpawnStatuses,
|
||||||
memberSpawnSnapshot,
|
memberSpawnSnapshot,
|
||||||
});
|
});
|
||||||
const failedSpawnDetails = getFailedSpawnDetails(memberSpawnStatuses);
|
const failedSpawnDetails = getFailedSpawnDetails({
|
||||||
|
memberSpawnStatuses,
|
||||||
|
memberSpawnSnapshotStatuses: memberSpawnSnapshot?.statuses,
|
||||||
|
});
|
||||||
const failedSpawnPanelMessage = buildFailedSpawnPanelMessage(failedSpawnDetails);
|
const failedSpawnPanelMessage = buildFailedSpawnPanelMessage(failedSpawnDetails);
|
||||||
const failedSpawnCompactDetail = buildFailedSpawnCompactDetail(failedSpawnDetails);
|
const failedSpawnCompactDetail = buildFailedSpawnCompactDetail(failedSpawnDetails);
|
||||||
const genericFailedSpawnPanelMessage = buildGenericFailedSpawnPanelMessage(
|
const genericFailedSpawnPanelMessage = buildGenericFailedSpawnPanelMessage(
|
||||||
|
|
|
||||||
|
|
@ -576,6 +576,70 @@ describe('buildTeamProvisioningPresentation', () => {
|
||||||
expect(presentation?.compactTone).toBe('warning');
|
expect(presentation?.compactTone).toBe('warning');
|
||||||
});
|
});
|
||||||
|
|
||||||
|
it('surfaces persisted failed teammate reasons when live member statuses are missing', () => {
|
||||||
|
const presentation = buildTeamProvisioningPresentation({
|
||||||
|
progress: {
|
||||||
|
runId: 'run-4c',
|
||||||
|
teamName: 'codex-team',
|
||||||
|
state: 'ready',
|
||||||
|
startedAt: '2026-04-13T10:00:00.000Z',
|
||||||
|
updatedAt: '2026-04-13T10:00:08.000Z',
|
||||||
|
message: 'Launch completed with teammate errors',
|
||||||
|
messageSeverity: 'warning',
|
||||||
|
pid: 4321,
|
||||||
|
cliLogsTail: '',
|
||||||
|
assistantOutput: '',
|
||||||
|
},
|
||||||
|
members: [
|
||||||
|
{
|
||||||
|
name: 'team-lead',
|
||||||
|
agentType: 'team-lead',
|
||||||
|
status: 'active',
|
||||||
|
currentTaskId: null,
|
||||||
|
taskCount: 0,
|
||||||
|
lastActiveAt: null,
|
||||||
|
messageCount: 0,
|
||||||
|
},
|
||||||
|
{
|
||||||
|
name: 'jack',
|
||||||
|
agentType: 'engineer',
|
||||||
|
status: 'unknown',
|
||||||
|
currentTaskId: null,
|
||||||
|
taskCount: 0,
|
||||||
|
lastActiveAt: null,
|
||||||
|
messageCount: 0,
|
||||||
|
},
|
||||||
|
],
|
||||||
|
memberSpawnStatuses: {},
|
||||||
|
memberSpawnSnapshot: {
|
||||||
|
expectedMembers: ['jack'],
|
||||||
|
summary: {
|
||||||
|
confirmedCount: 0,
|
||||||
|
pendingCount: 0,
|
||||||
|
failedCount: 1,
|
||||||
|
runtimeAlivePendingCount: 0,
|
||||||
|
},
|
||||||
|
statuses: {
|
||||||
|
jack: {
|
||||||
|
status: 'error',
|
||||||
|
launchState: 'failed_to_start',
|
||||||
|
hardFailureReason: 'The requested model is not available for your account.',
|
||||||
|
updatedAt: '2026-04-13T10:00:03.000Z',
|
||||||
|
runtimeAlive: false,
|
||||||
|
bootstrapConfirmed: false,
|
||||||
|
hardFailure: true,
|
||||||
|
agentToolAccepted: true,
|
||||||
|
firstSpawnAcceptedAt: '2026-04-13T10:00:01.000Z',
|
||||||
|
},
|
||||||
|
},
|
||||||
|
},
|
||||||
|
});
|
||||||
|
|
||||||
|
expect(presentation?.panelMessage).toContain('jack failed to start');
|
||||||
|
expect(presentation?.panelMessage).toContain('requested model is not available');
|
||||||
|
expect(presentation?.compactDetail).toBe('jack failed to start');
|
||||||
|
});
|
||||||
|
|
||||||
it('prefers live confirmed teammates over a stale persisted launch summary', () => {
|
it('prefers live confirmed teammates over a stale persisted launch summary', () => {
|
||||||
const presentation = buildTeamProvisioningPresentation({
|
const presentation = buildTeamProvisioningPresentation({
|
||||||
progress: {
|
progress: {
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue