From e81116b85e93eaca53faa0ae68aa7e77d515fd2d Mon Sep 17 00:00:00 2001 From: Artem Rootman <4586640+artemrootman@users.noreply.github.com> Date: Sun, 5 Apr 2026 17:01:36 +0000 Subject: [PATCH] fix: apply exact reviewer suggestions for MemberLogsTab MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Move endRefreshing() outside the !cancelled guard in finally block so it always runs even when the effect is torn down mid-refresh. - Only call load() when isTabActive or on first load — prevents unnecessary fetches when a hidden tab's effect re-runs. --- src/renderer/components/team/members/MemberLogsTab.tsx | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/renderer/components/team/members/MemberLogsTab.tsx b/src/renderer/components/team/members/MemberLogsTab.tsx index 430c20dc..4943d506 100644 --- a/src/renderer/components/team/members/MemberLogsTab.tsx +++ b/src/renderer/components/team/members/MemberLogsTab.tsx @@ -474,14 +474,16 @@ export const MemberLogsTab = ({ setError(e instanceof Error ? e.message : 'Unknown error'); } } finally { + if (didBeginRefreshing) endRefreshing(); if (!cancelled) { setLoading(false); - if (didBeginRefreshing) endRefreshing(); } } }; - void load(); + if (isTabActive || !hasLoadedRef.current) { + void load(); + } const interval = shouldAutoRefresh && isTabActive ? setInterval(() => void load(), 5000) : null;