agent-ecosystem/src/renderer/components/team/review/CodeMirrorDiffView.tsx
iliya 0df816bba6 feat: enhance diff view with continuous scroll and lazy loading
- Introduced a continuous scroll mode for the diff view, allowing users to review multiple files in a single scrollable container.
- Added lazy loading functionality to improve performance by loading file content as it approaches the viewport.
- Implemented a new portion collapse feature to allow users to expand unchanged regions incrementally, enhancing context retention during reviews.
- Updated navigation to support smooth scrolling between files and improved keyboard shortcuts for file navigation.
- Enhanced the review toolbar to manage actions across all files, including bulk accept/reject options.
- Added new hooks and components to support the continuous scroll and lazy loading features, ensuring a seamless user experience.
2026-02-25 15:39:14 +02:00

802 lines
27 KiB
TypeScript

import React, { useCallback, useEffect, useRef } from 'react';
import { defaultKeymap, history, historyKeymap, indentWithTab } from '@codemirror/commands';
import { cpp } from '@codemirror/lang-cpp';
import { css } from '@codemirror/lang-css';
import { go } from '@codemirror/lang-go';
import { html } from '@codemirror/lang-html';
import { java } from '@codemirror/lang-java';
import { javascript } from '@codemirror/lang-javascript';
import { json } from '@codemirror/lang-json';
import { less } from '@codemirror/lang-less';
import { markdown } from '@codemirror/lang-markdown';
import { php } from '@codemirror/lang-php';
import { python } from '@codemirror/lang-python';
import { rust } from '@codemirror/lang-rust';
import { sass } from '@codemirror/lang-sass';
import { sql } from '@codemirror/lang-sql';
import { xml } from '@codemirror/lang-xml';
import { yaml } from '@codemirror/lang-yaml';
import { indentUnit, LanguageDescription, syntaxHighlighting } from '@codemirror/language';
import { languages } from '@codemirror/language-data';
import { goToNextChunk, goToPreviousChunk, unifiedMergeView } from '@codemirror/merge';
import { Compartment, EditorState, type Extension } from '@codemirror/state';
import { oneDarkHighlightStyle } from '@codemirror/theme-one-dark';
import { EditorView, keymap, lineNumbers } from '@codemirror/view';
import { acceptChunk, getChunks, mergeUndoSupport, rejectChunk } from './CodeMirrorDiffUtils';
import { portionCollapseExtension } from './portionCollapse';
interface CodeMirrorDiffViewProps {
original: string;
modified: string;
fileName: string;
maxHeight?: string;
readOnly?: boolean;
showMergeControls?: boolean;
collapseUnchanged?: boolean;
collapseMargin?: number;
onHunkAccepted?: (hunkIndex: number) => void;
onHunkRejected?: (hunkIndex: number) => void;
/** Called when the user scrolls to the end of the diff (auto-viewed) */
onFullyViewed?: () => void;
/** Ref to expose the EditorView for external navigation */
editorViewRef?: React.RefObject<EditorView | null>;
/** Called when editor content changes (debounced, only when readOnly=false) */
onContentChanged?: (content: string) => void;
/** Cached EditorState to restore (preserves undo history between file switches) */
initialState?: EditorState;
/** Use portion collapse instead of CM's collapseUnchanged (Expand N / Expand All buttons) */
usePortionCollapse?: boolean;
/** Lines per "Expand N" click (only with usePortionCollapse). Default: 100 */
portionSize?: number;
}
/** Synchronous language extension for common file types (bundled by Vite) */
function getSyncLanguageExtension(fileName: string): Extension | null {
const ext = fileName.split('.').pop()?.toLowerCase();
switch (ext) {
case 'ts':
case 'tsx':
case 'js':
case 'jsx':
case 'mjs':
case 'cjs':
return javascript({
jsx: ext === 'tsx' || ext === 'jsx',
typescript: ext === 'ts' || ext === 'tsx',
});
case 'py':
return python();
case 'json':
case 'jsonl':
return json();
case 'css':
return css();
case 'scss':
return sass({ indented: false });
case 'sass':
return sass({ indented: true });
case 'less':
return less();
case 'html':
case 'htm':
return html();
case 'xml':
case 'svg':
return xml();
case 'md':
case 'mdx':
case 'markdown':
return markdown();
case 'yaml':
case 'yml':
return yaml();
case 'rs':
return rust();
case 'go':
return go();
case 'java':
return java();
case 'c':
case 'h':
case 'cpp':
case 'cxx':
case 'cc':
case 'hpp':
return cpp();
case 'php':
return php();
case 'sql':
return sql();
default:
return null;
}
}
/** Async fallback: match by filename via @codemirror/language-data for rare languages */
function getAsyncLanguageDesc(fileName: string): LanguageDescription | null {
return LanguageDescription.matchFilename(languages, fileName);
}
/** Compute hunk index for the chunk at a given position */
function computeHunkIndexAtPos(state: EditorState, pos: number): number {
const chunks = getChunks(state);
if (!chunks) return 0;
let index = 0;
for (const chunk of chunks.chunks) {
if (pos >= chunk.fromA && pos <= chunk.toA) {
return index;
}
if (pos >= chunk.fromB && pos <= chunk.toB) {
return index;
}
index++;
}
return 0;
}
/** Custom dark theme for diff view using CSS variables */
const diffTheme = EditorView.theme({
'&': {
backgroundColor: 'var(--color-surface)',
color: 'var(--color-text)',
fontFamily: 'ui-monospace, SFMono-Regular, "SF Mono", Menlo, Consolas, monospace',
fontSize: '13px',
},
'&.cm-focused': {
outline: 'none',
},
'.cm-gutters': {
backgroundColor: 'var(--color-surface)',
borderRight: '1px solid var(--color-border)',
color: 'var(--color-text-muted)',
fontSize: '11px',
minWidth: 'auto',
},
'.cm-lineNumbers .cm-gutterElement': {
padding: '0 4px 0 8px',
minWidth: '2ch',
textAlign: 'right',
opacity: '0.5',
},
'.cm-activeLineGutter': {
backgroundColor: 'transparent',
},
'.cm-activeLine': {
backgroundColor: 'transparent',
},
'.cm-scroller': {
overflow: 'auto',
},
'.cm-content': {
caretColor: 'var(--color-text)',
},
'.cm-cursor': {
borderLeftColor: 'var(--color-text)',
},
'.cm-selectionBackground': {
backgroundColor: 'rgba(59, 130, 246, 0.3) !important',
},
// Diff-specific line/block backgrounds
'.cm-changedLine': { backgroundColor: '#1a3a1a !important' },
'.cm-deletedChunk': { backgroundColor: '#241517', position: 'relative', overflow: 'visible' },
'.cm-insertedLine': { backgroundColor: '#1a3a1a !important' },
'.cm-deletedLine': { backgroundColor: '#241517 !important' },
// Merge toolbar — absolute, Y set dynamically by mousemove handler
'.cm-deletedChunk .cm-chunkButtons': {
position: 'absolute',
top: '0',
insetInlineEnd: '8px',
zIndex: 10,
display: 'flex',
justifyContent: 'flex-end',
},
'.cm-merge-toolbar': {
display: 'none',
alignItems: 'center',
gap: '2px',
'&.cm-merge-toolbar-active': {
display: 'flex',
},
},
'.cm-merge-nav': {
display: 'flex',
alignItems: 'center',
gap: '0',
marginRight: '2px',
border: '1px solid var(--color-border)',
borderRadius: '6px',
backgroundColor: 'var(--color-surface-raised)',
overflow: 'hidden',
},
'.cm-merge-nav-btn': {
border: 'none',
background: 'transparent',
color: 'var(--color-text-secondary)',
cursor: 'pointer',
padding: '3px 8px',
fontSize: '13px',
lineHeight: '20px',
'&:hover': { background: 'rgba(255,255,255,0.08)' },
},
'.cm-merge-nav-counter': {
fontSize: '12px',
color: 'var(--color-text-secondary)',
padding: '0 2px',
whiteSpace: 'nowrap',
},
'.cm-merge-undo': {
cursor: 'pointer',
padding: '3px 10px',
borderRadius: '5px',
fontSize: '12px',
fontWeight: '500',
lineHeight: '20px',
color: 'var(--color-text)',
backgroundColor: 'var(--color-surface-raised)',
border: '1px solid var(--color-border)',
'&:hover': { backgroundColor: 'rgba(255,255,255,0.1)' },
'& kbd': { fontSize: '10px', color: 'var(--color-text-muted)', marginLeft: '4px' },
},
'.cm-merge-keep': {
cursor: 'pointer',
padding: '3px 10px',
borderRadius: '5px',
fontSize: '12px',
fontWeight: '500',
lineHeight: '20px',
color: '#3fb950',
backgroundColor: 'rgba(46, 160, 67, 0.25)',
border: '1px solid rgba(46, 160, 67, 0.4)',
'&:hover': { backgroundColor: 'rgba(46, 160, 67, 0.4)' },
'& kbd': { fontSize: '10px', color: 'rgba(63, 185, 80, 0.7)', marginLeft: '4px' },
},
// Collapse unchanged region marker
'.cm-collapsedLines': {
backgroundColor: 'var(--color-surface-raised)',
color: 'var(--color-text-muted)',
fontSize: '12px',
padding: '2px 8px',
cursor: 'pointer',
borderTop: '1px solid var(--color-border)',
borderBottom: '1px solid var(--color-border)',
},
});
export const CodeMirrorDiffView = ({
original,
modified,
fileName,
maxHeight = '100%',
readOnly = false,
showMergeControls = false,
collapseUnchanged: collapseUnchangedProp = true,
collapseMargin = 3,
onHunkAccepted,
onHunkRejected,
onFullyViewed,
editorViewRef: externalViewRef,
onContentChanged,
initialState,
usePortionCollapse = false,
portionSize = 100,
}: CodeMirrorDiffViewProps): React.ReactElement => {
const containerRef = useRef<HTMLDivElement>(null);
const viewRef = useRef<EditorView | null>(null);
const endSentinelRef = useRef<HTMLDivElement>(null);
// Local ref to hold externalViewRef for syncing via useEffect
const externalViewRefHolder = useRef(externalViewRef);
// Stabilize callbacks via useEffect (cannot update refs during render)
const onAcceptRef = useRef(onHunkAccepted);
const onRejectRef = useRef(onHunkRejected);
const onContentChangedRef = useRef(onContentChanged);
const debounceTimer = useRef<ReturnType<typeof setTimeout>>();
useEffect(() => {
onAcceptRef.current = onHunkAccepted;
onRejectRef.current = onHunkRejected;
onContentChangedRef.current = onContentChanged;
externalViewRefHolder.current = externalViewRef;
}, [onHunkAccepted, onHunkRejected, onContentChanged, externalViewRef]);
// Auto-scroll to next chunk after accept/reject (deferred to let CM recalculate)
const scrollToNextChunk = useCallback(() => {
requestAnimationFrame(() => {
if (viewRef.current) goToNextChunk(viewRef.current);
});
}, []);
// Compartment for lazy-injected language support
const langCompartment = useRef(new Compartment());
// Compartment for merge view — allows dynamic collapse reconfigure without editor recreation
const mergeCompartment = useRef(new Compartment());
// Compartment for portion collapse (separate from merge to allow independent reconfigure)
const portionCompartment = useRef(new Compartment());
// Collapse as ref — used in buildExtensions (initial value) without triggering full rebuild
const collapseRef = useRef({ enabled: collapseUnchangedProp, margin: collapseMargin });
useEffect(() => {
collapseRef.current = { enabled: collapseUnchangedProp, margin: collapseMargin };
}, [collapseUnchangedProp, collapseMargin]);
/** Build unified merge view extension. Extracted for dynamic compartment reconfigure. */
const buildMergeExtension = useCallback(
(collapse: boolean, margin: number): Extension => {
const mergeConfig: Parameters<typeof unifiedMergeView>[0] = {
original,
highlightChanges: false,
gutter: true,
syntaxHighlightDeletions: true,
};
if (collapse && !usePortionCollapse) {
mergeConfig.collapseUnchanged = {
margin,
minSize: 4,
};
}
if (showMergeControls) {
// NOTE: We intentionally do NOT use the `action` callback from @codemirror/merge.
// CM's DeletionWidget caches DOM via a global WeakMap keyed by chunk.changes.
// When EditorView is recreated (e.g. from cached initialState), toDOM() returns
// the OLD cached DOM whose `action` closure references the DESTROYED view.
// Instead, we call acceptChunk/rejectChunk directly with viewRef.current.
//
// CM calls mergeControls twice per chunk: 'accept' first, 'reject' second.
// Both elements go into `.cm-chunkButtons`. We return the full toolbar for
// 'accept' and a hidden span for 'reject'.
mergeConfig.mergeControls = (type, _action) => {
if (type === 'reject') {
const empty = document.createElement('span');
empty.style.display = 'none';
return empty;
}
// --- Full toolbar for 'accept' ---
const toolbar = document.createElement('div');
toolbar.className = 'cm-merge-toolbar';
// Navigation section (hidden by default, shown if >1 chunks)
const nav = document.createElement('div');
nav.className = 'cm-merge-nav';
nav.style.display = 'none';
const prevBtn = document.createElement('button');
prevBtn.className = 'cm-merge-nav-btn';
prevBtn.textContent = '\u2227';
prevBtn.title = 'Previous chunk';
prevBtn.onmousedown = (e) => {
e.preventDefault();
const v = viewRef.current;
if (v) goToPreviousChunk(v);
};
const counter = document.createElement('span');
counter.className = 'cm-merge-nav-counter';
const nextBtn = document.createElement('button');
nextBtn.className = 'cm-merge-nav-btn';
nextBtn.textContent = '\u2228';
nextBtn.title = 'Next chunk';
nextBtn.onmousedown = (e) => {
e.preventDefault();
const v = viewRef.current;
if (v) goToNextChunk(v);
};
nav.append(prevBtn, counter, nextBtn);
toolbar.append(nav);
// Helper: create button with label + kbd shortcut
const makeBtn = (cls: string, label: string, shortcut: string): HTMLButtonElement => {
const btn = document.createElement('button');
btn.className = cls;
btn.append(document.createTextNode(label + ' '));
const kbd = document.createElement('kbd');
kbd.textContent = shortcut;
btn.append(kbd);
return btn;
};
// Undo button (reject action)
const undoBtn = makeBtn('cm-merge-undo', 'Undo', '\u2318N');
undoBtn.title = 'Reject change (⌘N)';
undoBtn.onmousedown = (e) => {
e.preventDefault();
const v = viewRef.current;
if (v) {
const pos = v.posAtDOM(toolbar);
const idx = computeHunkIndexAtPos(v.state, pos);
rejectChunk(v, pos);
onRejectRef.current?.(idx);
scrollToNextChunk();
}
};
toolbar.append(undoBtn);
// Keep button (accept action)
const keepBtn = makeBtn('cm-merge-keep', 'Keep', '\u2318Y');
keepBtn.title = 'Accept change (⌘Y)';
keepBtn.onmousedown = (e) => {
e.preventDefault();
const v = viewRef.current;
if (v) {
const pos = v.posAtDOM(toolbar);
const idx = computeHunkIndexAtPos(v.state, pos);
acceptChunk(v, pos);
onAcceptRef.current?.(idx);
scrollToNextChunk();
}
};
toolbar.append(keepBtn);
// Deferred: compute chunk index + show nav if >1 chunks
requestAnimationFrame(() => {
const v = viewRef.current;
if (!v) return;
const chunks = getChunks(v.state);
if (!chunks || chunks.chunks.length <= 1) return;
const pos = v.posAtDOM(toolbar);
const idx = computeHunkIndexAtPos(v.state, pos);
counter.textContent = `${idx + 1} of ${chunks.chunks.length}`;
nav.style.display = '';
});
return toolbar;
};
}
return unifiedMergeView(mergeConfig);
},
[original, showMergeControls, scrollToNextChunk, usePortionCollapse]
);
const buildExtensions = useCallback(() => {
const extensions: Extension[] = [
diffTheme,
lineNumbers(),
syntaxHighlighting(oneDarkHighlightStyle),
EditorView.editable.of(!readOnly),
EditorState.readOnly.of(readOnly),
];
// Undo/redo support and standard editing keybindings
if (!readOnly) {
extensions.push(history());
extensions.push(mergeUndoSupport);
extensions.push(indentUnit.of(' '));
extensions.push(keymap.of([indentWithTab, ...defaultKeymap, ...historyKeymap]));
}
// Language placeholder — actual language injected async via compartment reconfigure
extensions.push(langCompartment.current.of([]));
// Keyboard shortcuts for chunk navigation and accept/reject
extensions.push(
keymap.of([
{
key: 'Mod-y',
run: (view) => {
acceptChunk(view);
requestAnimationFrame(() => goToNextChunk(view));
return true;
},
},
{
key: 'Mod-n',
run: (view) => {
rejectChunk(view);
requestAnimationFrame(() => goToNextChunk(view));
return true;
},
},
{
key: 'Alt-j',
run: (view) => {
goToNextChunk(view);
return true;
},
},
{
key: 'Ctrl-Alt-ArrowDown',
run: goToNextChunk,
},
{
key: 'Ctrl-Alt-ArrowUp',
run: goToPreviousChunk,
},
])
);
// Debounced content change listener (only when editable)
if (!readOnly) {
extensions.push(
EditorView.updateListener.of((update) => {
if (update.docChanged) {
clearTimeout(debounceTimer.current);
debounceTimer.current = setTimeout(() => {
onContentChangedRef.current?.(update.state.doc.toString());
}, 300);
}
})
);
}
// Merge toolbar: always visible for nearest chunk, follows cursor when hovering on chunk
if (showMergeControls) {
// Helper: position a chunkButtons container so it's below the change block,
// but clamped to the visible viewport if that would be off-screen.
const positionAtBottom = (chunkEl: Element, scroller: Element): void => {
const btnContainer = chunkEl.querySelector<HTMLElement>('.cm-chunkButtons');
if (!btnContainer) return;
const parentRect = chunkEl.getBoundingClientRect();
const scrollerRect = scroller.getBoundingClientRect();
// "below block" = 100% of parent height
let targetY = parentRect.bottom;
const tbHeight = btnContainer.offsetHeight || 28;
// Clamp: if bottom edge would go below visible area, pin to viewport bottom
if (targetY + tbHeight > scrollerRect.bottom) {
targetY = scrollerRect.bottom - tbHeight;
}
btnContainer.style.top = `${targetY - parentRect.top}px`;
};
const positionAtCursor = (chunkEl: Element, clientY: number, scroller: Element): void => {
const btnContainer = chunkEl.querySelector<HTMLElement>('.cm-chunkButtons');
if (!btnContainer) return;
const parentRect = chunkEl.getBoundingClientRect();
const scrollerRect = scroller.getBoundingClientRect();
const tbHeight = btnContainer.offsetHeight || 28;
let targetY = clientY - tbHeight / 2;
// Clamp to viewport
if (targetY + tbHeight > scrollerRect.bottom) {
targetY = scrollerRect.bottom - tbHeight;
}
if (targetY < scrollerRect.top) {
targetY = scrollerRect.top;
}
btnContainer.style.top = `${targetY - parentRect.top}px`;
};
// Find which chunk index the mouse is directly over (deleted or inserted area)
const findHoveredChunkIndex = (event: MouseEvent, view: EditorView): number => {
const el = document.elementFromPoint(event.clientX, event.clientY);
if (!el) return -1;
const deletedChunk = el.closest('.cm-deletedChunk');
if (deletedChunk) {
const all = view.dom.querySelectorAll('.cm-deletedChunk');
return [...all].indexOf(deletedChunk);
}
if (el.closest('.cm-changedLine, .cm-insertedLine')) {
const allChunks = getChunks(view.state);
if (!allChunks) return -1;
const pos = view.posAtCoords({ x: event.clientX, y: event.clientY });
if (pos !== null) {
for (let i = 0; i < allChunks.chunks.length; i++) {
const chunk = allChunks.chunks[i];
if (pos >= chunk.fromB && pos <= chunk.toB) return i;
}
}
}
return -1;
};
// Find chunk nearest to cursor Y (for default "below block" display)
const findNearestChunkIndex = (clientY: number, view: EditorView): number => {
const allChunkEls = view.dom.querySelectorAll('.cm-deletedChunk');
let result = -1;
if (allChunkEls.length > 0) {
let bestIdx = 0;
let bestDist = Infinity;
allChunkEls.forEach((el, idx) => {
const rect = el.getBoundingClientRect();
const centerY = (rect.top + rect.bottom) / 2;
const dist = Math.abs(clientY - centerY);
if (dist < bestDist) {
bestDist = dist;
bestIdx = idx;
}
});
result = bestIdx;
}
return result;
};
extensions.push(
EditorView.domEventHandlers({
mousemove(event, view) {
const allChunks = getChunks(view.state);
if (allChunks && allChunks.chunks.length > 0) {
const scroller = view.scrollDOM;
const allChunkEls = view.dom.querySelectorAll('.cm-deletedChunk');
const hoveredIdx = findHoveredChunkIndex(event, view);
const nearestIdx =
hoveredIdx >= 0 ? hoveredIdx : findNearestChunkIndex(event.clientY, view);
const toolbars = view.dom.querySelectorAll('.cm-merge-toolbar');
toolbars.forEach((tb, idx) => {
tb.classList.toggle('cm-merge-toolbar-active', idx === nearestIdx);
});
if (nearestIdx >= 0 && nearestIdx < allChunkEls.length) {
const chunkEl = allChunkEls[nearestIdx] as HTMLElement;
if (hoveredIdx >= 0) {
positionAtCursor(chunkEl, event.clientY, scroller);
} else {
positionAtBottom(chunkEl, scroller);
}
}
}
return false;
},
mouseleave(_event, view) {
// Keep active toolbar visible, reposition to "below block"
const activeToolbar = view.dom.querySelector('.cm-merge-toolbar-active');
if (activeToolbar) {
const chunkEl = activeToolbar.closest('.cm-deletedChunk');
if (chunkEl) positionAtBottom(chunkEl, view.scrollDOM);
}
return false;
},
})
);
// Ensure at least one toolbar is visible (initial load + after accept/reject)
extensions.push(
EditorView.updateListener.of((update) => {
if (update.view.dom.querySelector('.cm-merge-toolbar-active')) return;
requestAnimationFrame(() => {
const v = update.view;
if (v.dom.querySelector('.cm-merge-toolbar-active')) return;
const first = v.dom.querySelector('.cm-merge-toolbar');
if (first) {
first.classList.add('cm-merge-toolbar-active');
const chunkEl = first.closest('.cm-deletedChunk');
if (chunkEl) positionAtBottom(chunkEl, v.scrollDOM);
}
});
})
);
}
// Unified merge view (wrapped in compartment for dynamic collapse reconfigure)
extensions.push(
mergeCompartment.current.of(
buildMergeExtension(collapseRef.current.enabled, collapseRef.current.margin)
)
);
// Portion collapse — must come AFTER merge view so ChunkField is available
extensions.push(
portionCompartment.current.of(
usePortionCollapse && collapseRef.current.enabled
? portionCollapseExtension({
margin: collapseRef.current.margin,
minSize: 4,
portionSize,
})
: []
)
);
return extensions;
}, [readOnly, showMergeControls, buildMergeExtension, usePortionCollapse, portionSize]);
useEffect(() => {
if (!containerRef.current) return;
// Destroy previous view
if (viewRef.current) {
viewRef.current.destroy();
viewRef.current = null;
}
const view = initialState
? new EditorView({ state: initialState, parent: containerRef.current })
: new EditorView({
doc: modified,
extensions: buildExtensions(),
parent: containerRef.current,
});
viewRef.current = view;
// Sync to external ref via holder
const extRef = externalViewRefHolder.current;
if (extRef) {
(extRef as React.MutableRefObject<EditorView | null>).current = view;
}
return () => {
view.destroy();
viewRef.current = null;
if (extRef) {
(extRef as React.MutableRefObject<EditorView | null>).current = null;
}
};
// We intentionally rebuild the entire editor when key props change
}, [original, modified, buildExtensions, initialState]);
// Inject language extension via compartment after editor creation
useEffect(() => {
const view = viewRef.current;
if (!view) return;
// Try synchronous (bundled) language first
const syncLang = getSyncLanguageExtension(fileName);
if (syncLang) {
view.dispatch({ effects: langCompartment.current.reconfigure(syncLang) });
return;
}
// Async fallback for rare languages via @codemirror/language-data
const desc = getAsyncLanguageDesc(fileName);
if (!desc) return;
if (desc.support) {
view.dispatch({ effects: langCompartment.current.reconfigure(desc.support) });
return;
}
let cancelled = false;
void desc.load().then((support: Extension) => {
if (!cancelled && viewRef.current === view) {
view.dispatch({ effects: langCompartment.current.reconfigure(support) });
}
});
return () => {
cancelled = true;
};
}, [fileName, buildExtensions, initialState]);
// Dynamic collapse toggle — reconfigure compartments in-place, preserving undo history
useEffect(() => {
const view = viewRef.current;
if (!view) return;
view.dispatch({
effects: [
mergeCompartment.current.reconfigure(
buildMergeExtension(collapseUnchangedProp, collapseMargin)
),
portionCompartment.current.reconfigure(
usePortionCollapse && collapseUnchangedProp
? portionCollapseExtension({
margin: collapseMargin,
minSize: 4,
portionSize,
})
: []
),
],
});
}, [collapseUnchangedProp, collapseMargin, buildMergeExtension, usePortionCollapse, portionSize]);
// Auto-viewed detection via IntersectionObserver
useEffect(() => {
if (!endSentinelRef.current || !onFullyViewed) return;
const observer = new IntersectionObserver(
(entries) => {
for (const entry of entries) {
if (entry.isIntersecting) {
onFullyViewed();
}
}
},
{ threshold: 1.0 }
);
observer.observe(endSentinelRef.current);
return () => observer.disconnect();
}, [onFullyViewed]);
return (
<div className="flex flex-col" style={{ maxHeight }}>
<div ref={containerRef} className="flex-1 overflow-hidden rounded-lg border border-border" />
{/* Invisible sentinel for auto-viewed detection */}
<div ref={endSentinelRef} className="h-px shrink-0" />
</div>
);
};