0feb5e650f
- Introduced logic to prevent relaying cross-team replies back into the originating lead, ensuring cleaner message handling. - Added utility functions for parsing cross-team recipients and determining targets for cross-team messages. - Updated ActivityItem and TeamProvisioningService to utilize new parsing methods for improved recipient qualification. - Enhanced tests to validate the handling of cross-team replies and recipient parsing.
41 lines
1.6 KiB
TypeScript
41 lines
1.6 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
|
|
import {
|
|
getCrossTeamSentTarget,
|
|
getSystemMessageLabel,
|
|
isQualifiedExternalRecipient,
|
|
} from '@renderer/components/team/activity/ActivityItem';
|
|
|
|
describe('ActivityItem legacy system message fallback', () => {
|
|
it('recognizes historical assignment and review message wording', () => {
|
|
expect(getSystemMessageLabel('New task assigned to you: #abcd1234 "Implement feature".')).toBe(
|
|
'Task assignment'
|
|
);
|
|
expect(getSystemMessageLabel('Task #abcd1234 approved by reviewer.')).toBe('Task approved');
|
|
expect(getSystemMessageLabel('Task #abcd1234 needs fixes before approval.')).toBe(
|
|
'Review changes requested'
|
|
);
|
|
});
|
|
|
|
it('does not treat new controller-authored summaries as legacy system noise', () => {
|
|
expect(getSystemMessageLabel('Review request for #abcd1234')).toBeNull();
|
|
expect(getSystemMessageLabel('Approved abcd1234')).toBeNull();
|
|
expect(getSystemMessageLabel('Fix request for abcd1234')).toBeNull();
|
|
});
|
|
|
|
it('does not classify dotted local teammates as external recipients', () => {
|
|
expect(isQualifiedExternalRecipient('ops.bot', 'my-team', new Set(['ops.bot']))).toBe(false);
|
|
expect(isQualifiedExternalRecipient('team-best.user', 'my-team', new Set(['ops.bot']))).toBe(
|
|
true
|
|
);
|
|
});
|
|
|
|
it('recognizes pseudo cross-team recipients in activity rows', () => {
|
|
expect(getCrossTeamSentTarget('cross-team:team-best', 'my-team', new Set(['ops.bot']))).toBe(
|
|
'team-best'
|
|
);
|
|
expect(getCrossTeamSentTarget('team-best.user', 'my-team', new Set(['ops.bot']))).toBe(
|
|
'team-best'
|
|
);
|
|
});
|
|
});
|