agent-ecosystem/src/main/services/team/TeamDataService.ts
iliya 27eacfa77c feat: add agent language update handling and validation
- Introduced support for updating the agent language in the configuration, including a new callback in `initializeConfigHandlers`.
- Enhanced `handleUpdateConfig` to trigger the new language update callback when the agent language changes.
- Updated validation logic to ensure the agent language is a non-empty string.
- Modified the `TeamConfigReader` and `TeamProvisioningService` to handle the new language setting, ensuring teams are notified of language changes.
- Adjusted various components to accommodate the new task start and cancellation features, improving task management in the Kanban board.
2026-02-24 17:11:54 +02:00

795 lines
25 KiB
TypeScript

import {
encodePath,
extractBaseDir,
getProjectsBasePath,
getTasksBasePath,
getTeamsBasePath,
} from '@main/utils/pathDecoder';
import { AGENT_BLOCK_CLOSE, AGENT_BLOCK_OPEN } from '@shared/constants/agentBlocks';
import { getMemberColor } from '@shared/constants/memberColors';
import { createLogger } from '@shared/utils/logger';
import { randomUUID } from 'crypto';
import * as fs from 'fs';
import * as path from 'path';
import * as readline from 'readline';
import { gitIdentityResolver } from '../parsing/GitIdentityResolver';
import { atomicWriteAsync } from './atomicWrite';
import { TeamAgentToolsInstaller } from './TeamAgentToolsInstaller';
import { TeamConfigReader } from './TeamConfigReader';
import { TeamInboxReader } from './TeamInboxReader';
import { TeamInboxWriter } from './TeamInboxWriter';
import { TeamKanbanManager } from './TeamKanbanManager';
import { TeamMemberResolver } from './TeamMemberResolver';
import { TeamMembersMetaStore } from './TeamMembersMetaStore';
import { TeamSentMessagesStore } from './TeamSentMessagesStore';
import { TeamTaskReader } from './TeamTaskReader';
import { TeamTaskWriter } from './TeamTaskWriter';
import type {
AddMemberRequest,
CreateTaskRequest,
GlobalTask,
InboxMessage,
KanbanColumnId,
KanbanState,
KanbanTaskState,
ResolvedTeamMember,
SendMessageRequest,
SendMessageResult,
TaskComment,
TeamConfig,
TeamCreateConfigRequest,
TeamData,
TeamMember,
TeamSummary,
TeamTask,
TeamTaskStatus,
TeamTaskWithKanban,
UpdateKanbanPatch,
} from '@shared/types';
const logger = createLogger('Service:TeamDataService');
const MIN_TEXT_LENGTH = 30;
const MAX_LEAD_TEXTS = 50;
export class TeamDataService {
constructor(
private readonly configReader: TeamConfigReader = new TeamConfigReader(),
private readonly taskReader: TeamTaskReader = new TeamTaskReader(),
private readonly inboxReader: TeamInboxReader = new TeamInboxReader(),
private readonly inboxWriter: TeamInboxWriter = new TeamInboxWriter(),
private readonly taskWriter: TeamTaskWriter = new TeamTaskWriter(),
private readonly memberResolver: TeamMemberResolver = new TeamMemberResolver(),
private readonly kanbanManager: TeamKanbanManager = new TeamKanbanManager(),
private readonly toolsInstaller: TeamAgentToolsInstaller = new TeamAgentToolsInstaller(),
private readonly membersMetaStore: TeamMembersMetaStore = new TeamMembersMetaStore(),
private readonly sentMessagesStore: TeamSentMessagesStore = new TeamSentMessagesStore()
) {}
async listTeams(): Promise<TeamSummary[]> {
return this.configReader.listTeams();
}
async getAllTasks(): Promise<GlobalTask[]> {
const [rawTasks, teams] = await Promise.all([
this.taskReader.getAllTasks(),
this.configReader.listTeams(),
]);
const teamInfoMap = new Map<string, { displayName: string; projectPath?: string }>();
for (const team of teams) {
teamInfoMap.set(team.teamName, {
displayName: team.displayName,
projectPath: team.projectPath,
});
}
const teamNames = [
...new Set(rawTasks.map((t) => t.teamName).filter((n) => teamInfoMap.has(n))),
];
const kanbanByTeam = new Map<string, KanbanState>();
await Promise.all(
teamNames.map(async (teamName) => {
try {
const state = await this.kanbanManager.getState(teamName);
kanbanByTeam.set(teamName, state);
} catch {
// ignore
}
})
);
return rawTasks
.filter((task) => teamInfoMap.has(task.teamName))
.map((task) => {
const info = teamInfoMap.get(task.teamName)!;
const kanban = kanbanByTeam.get(task.teamName);
const kanbanEntry = kanban?.tasks[task.id];
const kanbanColumn =
kanbanEntry?.column === 'review' || kanbanEntry?.column === 'approved'
? kanbanEntry.column
: undefined;
return {
...task,
teamDisplayName: info.displayName,
projectPath: task.projectPath ?? info.projectPath,
kanbanColumn,
};
});
}
async updateConfig(
teamName: string,
updates: { name?: string; description?: string; color?: string }
): Promise<TeamConfig | null> {
return this.configReader.updateConfig(teamName, updates);
}
async deleteTeam(teamName: string): Promise<void> {
const teamsDir = path.join(getTeamsBasePath(), teamName);
await fs.promises.rm(teamsDir, { recursive: true, force: true });
const tasksDir = path.join(getTasksBasePath(), teamName);
await fs.promises.rm(tasksDir, { recursive: true, force: true });
}
async getTeamData(teamName: string): Promise<TeamData> {
const config = await this.configReader.getConfig(teamName);
if (!config) {
throw new Error(`Team not found: ${teamName}`);
}
const warnings: string[] = [];
let tasks: TeamTask[] = [];
let tasksLoaded = true;
try {
tasks = await this.taskReader.getTasks(teamName);
} catch {
warnings.push('Tasks failed to load');
tasksLoaded = false;
}
let inboxNames: string[] = [];
try {
inboxNames = await this.inboxReader.listInboxNames(teamName);
} catch {
warnings.push('Inboxes failed to load');
}
let messages: InboxMessage[] = [];
try {
messages = await this.inboxReader.getMessages(teamName);
} catch {
warnings.push('Messages failed to load');
}
try {
const leadTexts = await this.extractLeadSessionTexts(config);
if (leadTexts.length > 0) {
messages = [...messages, ...leadTexts];
}
} catch {
warnings.push('Lead session texts failed to load');
}
try {
const sentMessages = await this.sentMessagesStore.readMessages(teamName);
if (sentMessages.length > 0) {
messages = [...messages, ...sentMessages];
}
} catch {
warnings.push('Sent messages failed to load');
}
messages.sort((a, b) => Date.parse(b.timestamp) - Date.parse(a.timestamp));
let metaMembers: TeamConfig['members'] = [];
try {
metaMembers = await this.membersMetaStore.getMembers(teamName);
} catch {
warnings.push('Member metadata failed to load');
}
let kanbanState: KanbanState = {
teamName,
reviewers: [],
tasks: {},
};
let canRunKanbanGc = true;
try {
kanbanState = await this.kanbanManager.getState(teamName);
} catch {
warnings.push('Kanban state failed to load');
canRunKanbanGc = false;
}
if (canRunKanbanGc && tasksLoaded) {
try {
await this.kanbanManager.garbageCollect(teamName, new Set(tasks.map((task) => task.id)));
kanbanState = await this.kanbanManager.getState(teamName);
} catch {
warnings.push('Kanban state cleanup failed');
}
}
const tasksWithKanban: TeamTaskWithKanban[] = tasks.map((task) => {
const col = kanbanState.tasks[task.id]?.column;
const kanbanColumn = col === 'review' || col === 'approved' ? col : undefined;
return { ...task, kanbanColumn };
});
const members = this.memberResolver.resolveMembers(
config,
metaMembers,
inboxNames,
tasksWithKanban,
messages
);
// Enrich members with git branch when it differs from lead's branch
await this.enrichMemberBranches(members, config);
// Auto-sync: create comments from task-related inbox messages
if (tasksLoaded && messages.length > 0) {
try {
const didSync = await this.syncLinkedComments(teamName, tasks, messages);
if (didSync) {
// Re-read tasks only if new comments were actually written
tasks = await this.taskReader.getTasks(teamName);
}
} catch {
warnings.push('Comment sync from messages failed');
}
}
const tasksToReturn: TeamTaskWithKanban[] = tasks.map((task) => {
const col = kanbanState.tasks[task.id]?.column;
const kanbanColumn = col === 'review' || col === 'approved' ? col : undefined;
return { ...task, kanbanColumn };
});
return {
teamName,
config,
tasks: tasksToReturn,
members,
messages,
kanbanState,
warnings: warnings.length > 0 ? warnings : undefined,
};
}
/**
* Enriches members with gitBranch when their cwd differs from the lead's.
* Mutates members in-place for efficiency (called right after resolveMembers).
*/
private async enrichMemberBranches(
members: ResolvedTeamMember[],
config: TeamConfig
): Promise<void> {
// Determine lead's cwd — prefer explicit member entry, fall back to config.projectPath
const leadEntry = config.members?.find((m) => m.name === 'team-lead');
const leadCwd = leadEntry?.cwd ?? config.projectPath;
if (!leadCwd) return;
let leadBranch: string | null = null;
try {
leadBranch = await gitIdentityResolver.getBranch(leadCwd);
} catch {
// Lead cwd may not be a git repo — skip enrichment entirely
return;
}
await Promise.all(
members.map(async (member) => {
if (!member.cwd || member.cwd === leadCwd) return;
try {
const branch = await gitIdentityResolver.getBranch(member.cwd);
if (branch && branch !== leadBranch) {
// eslint-disable-next-line no-param-reassign -- intentional in-place enrichment
member.gitBranch = branch;
}
} catch {
// Member cwd may not be a git repo — skip silently
}
})
);
}
async addMember(teamName: string, request: AddMemberRequest): Promise<void> {
const members = await this.membersMetaStore.getMembers(teamName);
const existing = members.find((m) => m.name.toLowerCase() === request.name.toLowerCase());
if (existing) {
if (existing.removedAt) {
throw new Error(`Name "${request.name}" was previously used by a removed member`);
}
throw new Error(`Member "${request.name}" already exists`);
}
const newMember: TeamMember = {
name: request.name,
role: request.role?.trim() || undefined,
agentType: 'general-purpose',
color: getMemberColor(members.filter((m) => !m.removedAt).length),
joinedAt: Date.now(),
};
members.push(newMember);
await this.membersMetaStore.writeMembers(teamName, members);
}
async removeMember(teamName: string, memberName: string): Promise<void> {
const members = await this.membersMetaStore.getMembers(teamName);
const member = members.find((m) => m.name === memberName);
if (!member) {
throw new Error(`Member "${memberName}" not found`);
}
if (member.removedAt) {
throw new Error(`Member "${memberName}" is already removed`);
}
if (member.agentType === 'team-lead') {
throw new Error('Cannot remove team lead');
}
member.removedAt = Date.now();
await this.membersMetaStore.writeMembers(teamName, members);
}
async createTask(teamName: string, request: CreateTaskRequest): Promise<TeamTask> {
const nextId = await this.taskReader.getNextTaskId(teamName);
const blockedBy = request.blockedBy?.filter((id) => id.length > 0) ?? [];
const related = request.related?.filter((id) => id.length > 0 && id !== nextId) ?? [];
let description = request.description
? `${request.subject}\n\n${request.description}`
: request.subject;
if (request.prompt?.trim()) {
description = description
? `${description}\n\n---\nPrompt: ${request.prompt.trim()}`
: `Prompt: ${request.prompt.trim()}`;
}
let projectPath: string | undefined;
try {
const config = await this.configReader.getConfig(teamName);
projectPath = config?.projectPath;
} catch {
/* best-effort */
}
const shouldStart = request.owner && request.startImmediately !== false;
const task: TeamTask = {
id: nextId,
subject: request.subject,
description,
owner: request.owner,
createdBy: 'user',
status: shouldStart ? 'in_progress' : 'pending',
blocks: [],
blockedBy,
related: related.length > 0 ? related : undefined,
projectPath,
};
await this.taskWriter.createTask(teamName, task);
// Update blocks[] on each referenced task so the reverse link exists
for (const depId of blockedBy) {
await this.taskWriter.addBlocksEntry(teamName, depId, nextId);
}
if (shouldStart && request.owner) {
try {
const toolPath = await this.toolsInstaller.ensureInstalled();
// Build notification with full context — inbox is the primary delivery
// channel to agents (Claude Code monitors inbox via fs.watch)
const parts = [`New task assigned to you: #${task.id} "${task.subject}".`];
if (request.description?.trim()) {
parts.push(`\nDescription:\n${request.description.trim()}`);
}
if (request.prompt?.trim()) {
parts.push(`\nInstructions:\n${request.prompt.trim()}`);
}
parts.push(
`\n${AGENT_BLOCK_OPEN}`,
`Update task status using:`,
`node "${toolPath}" --team ${teamName} task start ${task.id}`,
`node "${toolPath}" --team ${teamName} task complete ${task.id}`,
AGENT_BLOCK_CLOSE
);
await this.sendMessage(teamName, {
member: request.owner,
text: parts.join('\n'),
summary: `New task #${task.id} assigned`,
});
} catch {
// Best-effort notification — don't fail task creation if message fails
}
}
return task;
}
async startTask(teamName: string, taskId: string): Promise<{ notifiedOwner: boolean }> {
const tasks = await this.taskReader.getTasks(teamName);
const task = tasks.find((t) => t.id === taskId);
if (!task) {
throw new Error(`Task #${taskId} not found`);
}
if (task.status !== 'pending') {
throw new Error(`Task #${taskId} is not pending (current: ${task.status})`);
}
await this.taskWriter.updateStatus(teamName, taskId, 'in_progress');
if (task.owner) {
try {
const toolPath = await this.toolsInstaller.ensureInstalled();
const parts = [`Task #${task.id} "${task.subject}" has been started.`];
if (task.description?.trim()) {
parts.push(`\nDetails:\n${task.description.trim()}`);
}
parts.push(
`\n${AGENT_BLOCK_OPEN}`,
`Update task status using:`,
`node "${toolPath}" --team ${teamName} task complete ${task.id}`,
AGENT_BLOCK_CLOSE
);
await this.sendMessage(teamName, {
member: task.owner,
text: parts.join('\n'),
summary: `Task #${task.id} started`,
});
} catch {
// Best-effort notification
}
}
return { notifiedOwner: !!task.owner };
}
async updateTaskStatus(teamName: string, taskId: string, status: TeamTaskStatus): Promise<void> {
await this.taskWriter.updateStatus(teamName, taskId, status);
}
async updateTaskOwner(teamName: string, taskId: string, owner: string | null): Promise<void> {
await this.taskWriter.updateOwner(teamName, taskId, owner);
}
async addTaskComment(teamName: string, taskId: string, text: string): Promise<TaskComment> {
const comment = await this.taskWriter.addComment(teamName, taskId, text);
try {
const [tasks, toolPath] = await Promise.all([
this.taskReader.getTasks(teamName),
this.toolsInstaller.ensureInstalled(),
]);
const task = tasks.find((t) => t.id === taskId);
if (task?.owner) {
const parts = [
`Comment on task #${taskId} "${task.subject}":\n\n${text}`,
`\n${AGENT_BLOCK_OPEN}`,
`Reply to this comment using:`,
`node "${toolPath}" --team ${teamName} task comment ${taskId} --text "<your reply>" --from "<your-name>"`,
AGENT_BLOCK_CLOSE,
];
await this.sendMessage(teamName, {
member: task.owner,
text: parts.join('\n'),
summary: `Comment on #${taskId}`,
});
}
} catch {
// Notification is best-effort — don't fail comment save
}
return comment;
}
async sendMessage(teamName: string, request: SendMessageRequest): Promise<SendMessageResult> {
return this.inboxWriter.sendMessage(teamName, request);
}
async sendDirectToLead(
teamName: string,
leadName: string,
text: string,
summary?: string
): Promise<SendMessageResult> {
const messageId = randomUUID();
const msg: InboxMessage = {
from: 'user',
to: leadName,
text,
timestamp: new Date().toISOString(),
read: true,
summary,
messageId,
source: 'user_sent',
};
await this.sentMessagesStore.appendMessage(teamName, msg);
return { deliveredToInbox: false, deliveredViaStdin: true, messageId };
}
async getLeadMemberName(teamName: string): Promise<string | null> {
try {
const config = await this.configReader.getConfig(teamName);
// Check config.json members first (Claude Code-created teams)
if (config?.members?.length) {
const lead = config.members.find(
(m) => m.agentType === 'team-lead' || m.name === 'team-lead'
);
if (lead?.name) return lead.name;
}
// Fallback: check members.meta.json (UI-created teams)
const metaMembers = await this.membersMetaStore.getMembers(teamName);
if (metaMembers.length > 0) {
const lead = metaMembers.find((m) => m.agentType === 'team-lead' || m.name === 'team-lead');
if (lead?.name) return lead.name;
return metaMembers[0]?.name ?? null;
}
// Last resort: check config.json first member
return config?.members?.[0]?.name ?? null;
} catch {
return null;
}
}
async requestReview(teamName: string, taskId: string): Promise<void> {
await this.kanbanManager.updateTask(teamName, taskId, { op: 'set_column', column: 'review' });
const state = await this.kanbanManager.getState(teamName);
const reviewer = state.reviewers[0];
if (!reviewer) {
return;
}
try {
const toolPath = await this.toolsInstaller.ensureInstalled();
await this.sendMessage(teamName, {
member: reviewer,
text:
`Please review task #${taskId}.\n\n` +
`${AGENT_BLOCK_OPEN}\n` +
`When approved, move it to APPROVED:\n` +
`node "${toolPath}" --team ${teamName} review approve ${taskId}\n\n` +
`If changes are needed:\n` +
`node "${toolPath}" --team ${teamName} review request-changes ${taskId} --comment "..."\n` +
AGENT_BLOCK_CLOSE,
summary: `Review request for #${taskId}`,
});
} catch (error) {
await this.kanbanManager
.updateTask(teamName, taskId, { op: 'remove' })
.catch(() => undefined);
throw error;
}
}
async createTeamConfig(request: TeamCreateConfigRequest): Promise<void> {
const teamDir = path.join(getTeamsBasePath(), request.teamName);
const configPath = path.join(teamDir, 'config.json');
try {
await fs.promises.access(configPath, fs.constants.F_OK);
throw new Error(`Team already exists: ${request.teamName}`);
} catch (error) {
if ((error as NodeJS.ErrnoException).code !== 'ENOENT') {
throw error;
}
}
const tasksDir = path.join(getTasksBasePath(), request.teamName);
await fs.promises.mkdir(teamDir, { recursive: true });
await fs.promises.mkdir(tasksDir, { recursive: true });
const joinedAt = Date.now();
const config = {
name: request.displayName?.trim() || request.teamName,
description: request.description?.trim() || undefined,
color: request.color?.trim() || undefined,
};
await atomicWriteAsync(configPath, JSON.stringify(config, null, 2));
await this.membersMetaStore.writeMembers(
request.teamName,
request.members.map((member, index) => ({
name: member.name,
role: member.role?.trim() || undefined,
agentType: 'general-purpose',
color: getMemberColor(index),
joinedAt,
}))
);
}
/**
* Scans inbox messages for task-related discussions and auto-creates
* linked comments on disk. Uses deterministic comment ID for dedup.
* Returns true if any new comments were synced (caller should re-read tasks).
*/
private async syncLinkedComments(
teamName: string,
tasks: TeamTask[],
messages: InboxMessage[]
): Promise<boolean> {
const TASK_ID_PATTERN = /#(\d+)/g;
let synced = false;
// Dedup broadcasts: same sender + same text → process only once
const processedTexts = new Set<string>();
for (const msg of messages) {
if (!msg.messageId || !msg.summary || msg.from === 'user') continue;
if (msg.source === 'lead_session' || msg.source === 'lead_process') continue;
const textKey = `${msg.from}\0${msg.text}`;
if (processedTexts.has(textKey)) continue;
processedTexts.add(textKey);
const matches = msg.summary.matchAll(TASK_ID_PATTERN);
const taskIds = new Set<string>();
for (const match of matches) {
taskIds.add(match[1]);
}
for (const taskId of taskIds) {
const task = tasks.find((t) => t.id === taskId);
if (!task) continue;
const commentId = `msg-${msg.messageId}`;
const existing = task.comments ?? [];
if (existing.some((c) => c.id === commentId)) continue;
try {
await this.taskWriter.addComment(teamName, taskId, msg.text, {
id: commentId,
author: msg.from,
createdAt: msg.timestamp,
});
synced = true;
} catch {
// Best-effort — don't fail getTeamData() on sync errors
}
}
}
return synced;
}
private async extractLeadSessionTexts(config: TeamConfig): Promise<InboxMessage[]> {
if (!config.leadSessionId || !config.projectPath) {
return [];
}
const projectId = encodePath(config.projectPath);
const baseDir = extractBaseDir(projectId);
const jsonlPath = path.join(getProjectsBasePath(), baseDir, `${config.leadSessionId}.jsonl`);
try {
await fs.promises.access(jsonlPath, fs.constants.F_OK);
} catch {
logger.debug(`Lead session JSONL not found: ${jsonlPath}`);
return [];
}
const leadName = config.members?.find((m) => m.agentType === 'team-lead')?.name ?? 'team-lead';
const texts: InboxMessage[] = [];
const stream = fs.createReadStream(jsonlPath, { encoding: 'utf8' });
const rl = readline.createInterface({ input: stream, crlfDelay: Infinity });
try {
for await (const line of rl) {
const trimmed = line.trim();
if (!trimmed) continue;
let msg: Record<string, unknown>;
try {
msg = JSON.parse(trimmed) as Record<string, unknown>;
} catch {
continue;
}
if (msg.type !== 'assistant') continue;
const message = (msg.message ?? msg) as Record<string, unknown>;
const content = message.content;
if (!Array.isArray(content)) continue;
const timestamp =
typeof msg.timestamp === 'string' ? msg.timestamp : new Date().toISOString();
for (const block of content as Record<string, unknown>[]) {
if (block.type !== 'text' || typeof block.text !== 'string') continue;
const text = block.text.trim();
if (text.length < MIN_TEXT_LENGTH) continue;
texts.push({
from: leadName,
text,
timestamp,
read: true,
source: 'lead_session',
});
}
}
} finally {
rl.close();
stream.destroy();
}
// Keep only the last N texts
if (texts.length > MAX_LEAD_TEXTS) {
return texts.slice(-MAX_LEAD_TEXTS);
}
return texts;
}
async updateKanban(teamName: string, taskId: string, patch: UpdateKanbanPatch): Promise<void> {
if (patch.op !== 'request_changes') {
await this.kanbanManager.updateTask(teamName, taskId, patch);
return;
}
const tasks = await this.taskReader.getTasks(teamName);
const task = tasks.find((candidate) => candidate.id === taskId);
if (!task?.owner) {
throw new Error(`No owner found for task ${taskId}`);
}
const previousStatus: TeamTaskStatus = task.status;
const previousState = await this.kanbanManager.getState(teamName);
const previousKanbanEntry: KanbanTaskState | undefined = previousState.tasks[taskId];
await this.kanbanManager.updateTask(teamName, taskId, { op: 'remove' });
try {
await this.taskWriter.updateStatus(teamName, taskId, 'in_progress');
await this.sendMessage(teamName, {
member: task.owner,
text:
`Task #${taskId} needs fixes.\n\n` +
`${patch.comment?.trim() || 'Reviewer requested changes.'}\n\n` +
`Please fix and mark it as completed when ready.`,
summary: `Fix request for #${taskId}`,
});
} catch (error) {
await this.taskWriter.updateStatus(teamName, taskId, previousStatus).catch(() => undefined);
if (previousKanbanEntry) {
await this.kanbanManager
.updateTask(teamName, taskId, { op: 'set_column', column: previousKanbanEntry.column })
.catch(() => undefined);
}
throw error;
}
}
async updateKanbanColumnOrder(
teamName: string,
columnId: KanbanColumnId,
orderedTaskIds: string[]
): Promise<void> {
await this.kanbanManager.updateColumnOrder(teamName, columnId, orderedTaskIds);
}
}