2615ed0ad7
- Updated file naming in release workflow to use consistent dot notation for better clarity. - Enhanced RELEASE.md to reflect updated file names for download links. - Added logic to filter out the "user" pseudo-member in TeamMemberResolver to prevent confusion in team configurations. - Improved error handling in TeamProvisioningService to avoid caching authentication failures and ensure accurate readiness status. - Introduced visual tone handling in ProvisioningProgressBlock for better user feedback on errors. Made-with: Cursor
68 lines
2.6 KiB
TypeScript
68 lines
2.6 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
|
|
import { TeamMemberResolver } from '../../../../src/main/services/team/TeamMemberResolver';
|
|
|
|
import type { InboxMessage, TeamConfig, TeamTask } from '../../../../src/shared/types/team';
|
|
|
|
describe('TeamMemberResolver', () => {
|
|
it('builds roster from config + meta + inbox only', () => {
|
|
const resolver = new TeamMemberResolver();
|
|
const config: TeamConfig = {
|
|
name: 'My Team',
|
|
members: [{ name: 'team-lead', agentType: 'team-lead', role: 'lead' }],
|
|
};
|
|
const metaMembers: TeamConfig['members'] = [
|
|
{ name: 'alice', role: 'developer', agentType: 'general-purpose', color: 'blue' },
|
|
];
|
|
const inboxNames = ['bob'];
|
|
const tasks: TeamTask[] = [
|
|
{ id: '1', subject: 'Visible task', status: 'pending', owner: 'alice' },
|
|
{ id: '2', subject: 'Ghost task', status: 'pending', owner: 'stranger' },
|
|
];
|
|
const now = new Date().toISOString();
|
|
const messages: InboxMessage[] = [
|
|
{ from: 'bob', text: 'ready', timestamp: now, read: false, color: 'green' },
|
|
{ from: 'user', text: 'system note', timestamp: now, read: false },
|
|
];
|
|
|
|
const members = resolver.resolveMembers(config, metaMembers, inboxNames, tasks, messages);
|
|
const names = members.map((member) => member.name);
|
|
|
|
expect(names).toEqual(['alice', 'bob', 'team-lead']);
|
|
expect(names).not.toContain('stranger');
|
|
expect(names).not.toContain('user');
|
|
|
|
const alice = members.find((member) => member.name === 'alice');
|
|
expect(alice?.role).toBe('developer');
|
|
expect(alice?.color).toBe('blue');
|
|
|
|
const lead = members.find((member) => member.name === 'team-lead');
|
|
expect(lead?.role).toBe('lead');
|
|
expect(lead?.agentType).toBe('team-lead');
|
|
});
|
|
|
|
it('filters out "user" pseudo-member even when present in config, meta, or inboxNames', () => {
|
|
const resolver = new TeamMemberResolver();
|
|
const config: TeamConfig = {
|
|
name: 'Team',
|
|
members: [
|
|
{ name: 'team-lead', agentType: 'team-lead', role: 'lead' },
|
|
{ name: 'user', agentType: 'general-purpose' },
|
|
],
|
|
};
|
|
const metaMembers: TeamConfig['members'] = [
|
|
{ name: 'user', agentType: 'general-purpose' },
|
|
{ name: 'alice', role: 'dev', agentType: 'general-purpose' },
|
|
];
|
|
const inboxNames = ['user', 'alice'];
|
|
const tasks: TeamTask[] = [];
|
|
const messages: InboxMessage[] = [];
|
|
|
|
const members = resolver.resolveMembers(config, metaMembers, inboxNames, tasks, messages);
|
|
const names = members.map((m) => m.name);
|
|
|
|
expect(names).not.toContain('user');
|
|
expect(names).toContain('team-lead');
|
|
expect(names).toContain('alice');
|
|
});
|
|
});
|