agent-ecosystem/src/renderer/components/team/members/MemberDraftRow.tsx
iliya 3f923c480e feat: improve task status handling and notification resilience
- Enhanced the startTask function to clear stale kanban entries when a task is reopened, ensuring accurate task tracking.
- Updated the addTaskComment function to handle notification failures gracefully, allowing comments to persist even if owner notifications fail.
- Added tests to validate the resilience of task comment notifications and ensure correct behavior under failure scenarios.
- Refactored related functions for improved clarity and maintainability in task management.
2026-03-09 17:09:15 +02:00

236 lines
8.4 KiB
TypeScript

import React, { useCallback, useEffect, useMemo, useState } from 'react';
import { TeamModelSelector } from '@renderer/components/team/dialogs/TeamModelSelector';
import { RoleSelect } from '@renderer/components/team/RoleSelect';
import { Button } from '@renderer/components/ui/button';
import { Input } from '@renderer/components/ui/input';
import { MentionableTextarea } from '@renderer/components/ui/MentionableTextarea';
import { getTeamColorSet } from '@renderer/constants/teamColors';
import { useDraftPersistence } from '@renderer/hooks/useDraftPersistence';
import { useFileListCacheWarmer } from '@renderer/hooks/useFileListCacheWarmer';
import { reconcileChips, removeChipTokenFromText } from '@renderer/utils/chipUtils';
import { getMemberColorByName } from '@shared/constants/memberColors';
import { ChevronDown, ChevronRight, Info } from 'lucide-react';
import type { MemberDraft } from './membersEditorTypes';
import type { InlineChip } from '@renderer/types/inlineChip';
import type { MentionSuggestion } from '@renderer/types/mention';
interface MemberDraftRowProps {
member: MemberDraft;
index: number;
nameError: string | null;
onNameChange: (id: string, name: string) => void;
onRoleChange: (id: string, roleSelection: string) => void;
onCustomRoleChange: (id: string, customRole: string) => void;
onRemove: (id: string) => void;
showWorkflow?: boolean;
onWorkflowChange?: (id: string, workflow: string) => void;
onWorkflowChipsChange?: (id: string, chips: InlineChip[]) => void;
draftKeyPrefix?: string;
projectPath?: string | null;
mentionSuggestions?: MentionSuggestion[];
}
export const MemberDraftRow = ({
member,
index,
nameError,
onNameChange,
onRoleChange,
onCustomRoleChange,
onRemove,
showWorkflow = false,
onWorkflowChange,
onWorkflowChipsChange,
draftKeyPrefix,
projectPath,
mentionSuggestions = [],
}: MemberDraftRowProps): React.JSX.Element => {
const memberColorSet = getTeamColorSet(
getMemberColorByName(member.name.trim() || `member-${index}`)
);
const [workflowExpanded, setWorkflowExpanded] = useState(false);
const [modelExpanded, setModelExpanded] = useState(false);
// Pre-warm file list cache when workflow section is expanded
useFileListCacheWarmer(workflowExpanded && projectPath ? projectPath : null);
const draftKey =
draftKeyPrefix && (member.name.trim() || member.id)
? `${draftKeyPrefix}:workflow:${member.name.trim() || member.id}`
: null;
const workflowDraft = useDraftPersistence({
key: draftKey ?? `workflow:${member.id}`,
initialValue: member.workflow?.trim() ? member.workflow : undefined,
enabled: !!draftKey,
});
const chips = useMemo(() => member.workflowChips ?? [], [member.workflowChips]);
const handleWorkflowChange = useCallback(
(v: string) => {
const reconciled = reconcileChips(chips, v);
if (reconciled.length !== chips.length) {
onWorkflowChipsChange?.(member.id, reconciled);
}
workflowDraft.setValue(v);
onWorkflowChange?.(member.id, v);
},
[member.id, chips, onWorkflowChange, onWorkflowChipsChange, workflowDraft]
);
const handleFileChipInsert = useCallback(
(chip: InlineChip) => {
onWorkflowChipsChange?.(member.id, [...chips, chip]);
},
[member.id, chips, onWorkflowChipsChange]
);
const handleChipRemove = useCallback(
(chipId: string) => {
const chip = chips.find((c) => c.id === chipId);
if (!chip) return;
const newChips = chips.filter((c) => c.id !== chipId);
const newValue = removeChipTokenFromText(workflowDraft.value, chip);
onWorkflowChipsChange?.(member.id, newChips);
workflowDraft.setValue(newValue);
onWorkflowChange?.(member.id, newValue);
},
[chips, member.id, onWorkflowChange, onWorkflowChipsChange, workflowDraft]
);
useEffect(() => {
if (
onWorkflowChange &&
workflowDraft.value &&
workflowDraft.value !== (member.workflow ?? '')
) {
onWorkflowChange(member.id, workflowDraft.value);
}
}, [workflowDraft.value, member.id, member.workflow, onWorkflowChange]);
const suggestionsExcludingSelf = mentionSuggestions.filter(
(s) => s.name.toLowerCase() !== member.name.trim().toLowerCase()
);
return (
<div
className="grid grid-cols-1 gap-2 rounded-md border border-[var(--color-border)] bg-[var(--color-surface-raised)] p-2 md:grid-cols-[1fr_220px_auto]"
style={{
borderLeftWidth: '3px',
borderLeftColor: memberColorSet.border,
}}
>
<div className="space-y-0.5">
<Input
className="h-8 text-xs"
value={member.name}
aria-label={`Member ${index + 1} name`}
onChange={(event) => onNameChange(member.id, event.target.value)}
placeholder="member-name"
style={
member.name.trim()
? {
color: memberColorSet.text,
}
: undefined
}
/>
{nameError ? <p className="text-[10px] text-red-300">{nameError}</p> : null}
</div>
<div>
<RoleSelect
value={member.roleSelection || '__none__'}
onValueChange={(roleSelection) => onRoleChange(member.id, roleSelection)}
customRole={member.customRole}
onCustomRoleChange={(customRole) => onCustomRoleChange(member.id, customRole)}
triggerClassName="h-8 text-xs"
inputClassName="h-8 text-xs"
/>
</div>
<div className="flex flex-col gap-2 sm:flex-row">
{showWorkflow && onWorkflowChange ? (
<Button
variant="outline"
size="sm"
className="h-8 shrink-0 gap-1"
onClick={() => setWorkflowExpanded((prev) => !prev)}
>
{workflowExpanded ? (
<ChevronDown className="size-3.5" />
) : (
<ChevronRight className="size-3.5" />
)}
Workflow
</Button>
) : null}
<Button
variant="outline"
size="sm"
className="h-8 shrink-0 gap-1"
onClick={() => setModelExpanded((prev) => !prev)}
>
{modelExpanded ? (
<ChevronDown className="size-3.5" />
) : (
<ChevronRight className="size-3.5" />
)}
Model
</Button>
<Button
variant="outline"
size="sm"
className="h-8 shrink-0 border-red-500/40 text-red-300 hover:bg-red-500/10 hover:text-red-200"
onClick={() => onRemove(member.id)}
>
Remove
</Button>
</div>
{showWorkflow && onWorkflowChange && workflowExpanded ? (
<div className="space-y-0.5 md:col-span-3">
<label
htmlFor={`member-${member.id}-workflow`}
className="block text-[10px] font-medium text-[var(--color-text-muted)]"
>
Workflow (optional)
</label>
<MentionableTextarea
id={`member-${member.id}-workflow`}
className="min-h-[80px] text-xs"
minRows={3}
maxRows={8}
value={workflowDraft.value}
onValueChange={handleWorkflowChange}
suggestions={suggestionsExcludingSelf}
chips={chips}
onChipRemove={handleChipRemove}
projectPath={projectPath ?? undefined}
onFileChipInsert={handleFileChipInsert}
placeholder="How this agent should behave, interact with others..."
footerRight={
workflowDraft.isSaved ? (
<span className="text-[10px] text-[var(--color-text-muted)]">Draft saved</span>
) : null
}
/>
</div>
) : null}
{modelExpanded && (
<div className="space-y-2 md:col-span-3">
<div className="pointer-events-none opacity-40">
<TeamModelSelector value="" onValueChange={() => {}} />
</div>
<div className="flex items-start gap-2 rounded-md border border-sky-500/20 bg-sky-500/5 px-3 py-2">
<Info className="mt-0.5 size-3.5 shrink-0 text-sky-400" />
<p className="text-[11px] leading-relaxed text-sky-300">
Claude Code doesn&apos;t support per-member model selection yet &mdash; all teammates
inherit the team launch model. We plan to solve this via a local proxy.
</p>
</div>
</div>
)}
</div>
);
};