96c9b00d92
- Added a new function to drop CLI provisioner members from the member map, ensuring these internal artifacts are never displayed to users. - Updated the createCliProvisionerNameGuard function to unconditionally hide provisioner names, regardless of the presence of base members. - Modified unit tests to reflect the new behavior of dropping provisioner names even when the base member is absent.
84 lines
2.6 KiB
TypeScript
84 lines
2.6 KiB
TypeScript
import { describe, expect, it } from 'vitest';
|
|
|
|
import {
|
|
createCliAutoSuffixNameGuard,
|
|
createCliProvisionerNameGuard,
|
|
parseNumericSuffixName,
|
|
} from '@shared/utils/teamMemberName';
|
|
|
|
describe('teamMemberName helpers', () => {
|
|
it('parses numeric suffix names', () => {
|
|
expect(parseNumericSuffixName('alice-2')).toEqual({ base: 'alice', suffix: 2 });
|
|
expect(parseNumericSuffixName('alice')).toBeNull();
|
|
expect(parseNumericSuffixName('')).toBeNull();
|
|
});
|
|
|
|
it('drops cli auto-suffixed names only when the base name also exists', () => {
|
|
const keepName = createCliAutoSuffixNameGuard(['dev', 'dev-2', 'dev-3']);
|
|
|
|
expect(keepName('dev')).toBe(true);
|
|
expect(keepName('dev-2')).toBe(false);
|
|
expect(keepName('dev-3')).toBe(false);
|
|
});
|
|
|
|
it('keeps -1 names because they are often intentional', () => {
|
|
const keepName = createCliAutoSuffixNameGuard(['worker', 'worker-1']);
|
|
|
|
expect(keepName('worker')).toBe(true);
|
|
expect(keepName('worker-1')).toBe(true);
|
|
});
|
|
|
|
it('keeps suffixed names when the base name is absent', () => {
|
|
const keepName = createCliAutoSuffixNameGuard(['alice-2']);
|
|
|
|
expect(keepName('alice-2')).toBe(true);
|
|
});
|
|
|
|
it('treats base-name collisions case-insensitively', () => {
|
|
const keepName = createCliAutoSuffixNameGuard(['Alice', 'alice-2']);
|
|
|
|
expect(keepName('alice-2')).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('createCliProvisionerNameGuard', () => {
|
|
it('drops provisioner names when the base member exists', () => {
|
|
const keep = createCliProvisionerNameGuard([
|
|
'alice',
|
|
'alice-provisioner',
|
|
'bob',
|
|
'bob-provisioner',
|
|
]);
|
|
|
|
expect(keep('alice')).toBe(true);
|
|
expect(keep('alice-provisioner')).toBe(false);
|
|
expect(keep('bob')).toBe(true);
|
|
expect(keep('bob-provisioner')).toBe(false);
|
|
});
|
|
|
|
it('drops provisioner names even when the base member is absent', () => {
|
|
const keep = createCliProvisionerNameGuard(['carol-provisioner']);
|
|
|
|
expect(keep('carol-provisioner')).toBe(false);
|
|
});
|
|
|
|
it('treats base-name collisions case-insensitively', () => {
|
|
const keep = createCliProvisionerNameGuard(['Alice', 'alice-provisioner']);
|
|
|
|
expect(keep('alice-provisioner')).toBe(false);
|
|
});
|
|
|
|
it('keeps non-provisioner names unchanged', () => {
|
|
const keep = createCliProvisionerNameGuard(['alice', 'alice-provisioner', 'dev-1']);
|
|
|
|
expect(keep('alice')).toBe(true);
|
|
expect(keep('dev-1')).toBe(true);
|
|
});
|
|
|
|
it('handles empty and edge-case names', () => {
|
|
const keep = createCliProvisionerNameGuard(['', '-provisioner']);
|
|
|
|
expect(keep('')).toBe(true);
|
|
expect(keep('-provisioner')).toBe(true);
|
|
});
|
|
});
|