admin-valentin/arcade-mcp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix login URL (fixes CSRF issues) (#225)

Browse source 
The CLI was starting the login process on the old domain, which is why
we were seeing a CSRF error. The cookie was placed on `arcade-ai.com`
not `arcade.dev`!
This commit is contained in:
Nate Barbettini 2025-01-23 22:44:57 -08:00 committed by GitHub
parent ca90b31262
commit a1db8a9f33
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 15 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
arcade/arcade/cli/constants.py
View file

@ -1,5 +1,5 @@
DEFAULT_CLOUD_HOST = "cloud.arcade-ai.com" DEFAULT_CLOUD_HOST = "cloud.arcade.dev"
DEFAULT_ENGINE_HOST = "api.arcade-ai.com" DEFAULT_ENGINE_HOST = "api.arcade.dev"
LOCALHOST = "localhost" LOCALHOST = "localhost"
_style_block = b""" _style_block = b"""

2
arcade/pyproject.toml
View file

@ -1,6 +1,6 @@
[tool.poetry] [tool.poetry]
name = "arcade-ai" name = "arcade-ai"
version = "1.0.0" version = "1.0.1"
description = "Arcade AI Python SDK and CLI" description = "Arcade AI Python SDK and CLI"
readme = "README.md" readme = "README.md"
packages = [ packages = [

24
arcade/tests/cli/test_utils.py
View file

@ -2,8 +2,8 @@ import pytest
from arcade.cli.utils import compute_engine_base_url, compute_login_url from arcade.cli.utils import compute_engine_base_url, compute_login_url
DEFAULT_CLOUD_HOST = "cloud.arcade-ai.com" DEFAULT_CLOUD_HOST = "cloud.arcade.dev"
DEFAULT_ENGINE_HOST = "api.arcade-ai.com" DEFAULT_ENGINE_HOST = "api.arcade.dev"
LOCALHOST = "localhost" LOCALHOST = "localhost"
DEFAULT_PORT = None DEFAULT_PORT = None
DEFAULT_FORCE_TLS = False DEFAULT_FORCE_TLS = False
@ -20,7 +20,7 @@ DEFAULT_FORCE_NO_TLS = False
"force_tls": DEFAULT_FORCE_TLS, "force_tls": DEFAULT_FORCE_TLS,
"force_no_tls": DEFAULT_FORCE_NO_TLS, "force_no_tls": DEFAULT_FORCE_NO_TLS,
}, },
"https://api.arcade-ai.com", "https://api.arcade.dev",
id="default", id="default",
), ),
pytest.param( pytest.param(
@ -40,7 +40,7 @@ DEFAULT_FORCE_NO_TLS = False
"force_tls": DEFAULT_FORCE_TLS, "force_tls": DEFAULT_FORCE_TLS,
"force_no_tls": DEFAULT_FORCE_NO_TLS, "force_no_tls": DEFAULT_FORCE_NO_TLS,
}, },
"https://api.arcade-ai.com:9099", "https://api.arcade.dev:9099",
id="custom port", id="custom port",
), ),
pytest.param( pytest.param(
@ -60,7 +60,7 @@ DEFAULT_FORCE_NO_TLS = False
"force_tls": True, "force_tls": True,
"force_no_tls": DEFAULT_FORCE_NO_TLS, "force_no_tls": DEFAULT_FORCE_NO_TLS,
}, },
"https://api.arcade-ai.com", "https://api.arcade.dev",
id="force TLS", id="force TLS",
), ),
pytest.param( pytest.param(
@ -80,7 +80,7 @@ DEFAULT_FORCE_NO_TLS = False
"force_tls": True, "force_tls": True,
"force_no_tls": DEFAULT_FORCE_NO_TLS, "force_no_tls": DEFAULT_FORCE_NO_TLS,
}, },
"https://api.arcade-ai.com:9099", "https://api.arcade.dev:9099",
id="custom port with force TLS", id="custom port with force TLS",
), ),
pytest.param( pytest.param(
@ -100,7 +100,7 @@ DEFAULT_FORCE_NO_TLS = False
"force_tls": DEFAULT_FORCE_TLS, "force_tls": DEFAULT_FORCE_TLS,
"force_no_tls": True, "force_no_tls": True,
}, },
"http://api.arcade-ai.com", "http://api.arcade.dev",
id="force no TLS", id="force no TLS",
), ),
pytest.param( pytest.param(
@ -120,7 +120,7 @@ DEFAULT_FORCE_NO_TLS = False
"force_tls": DEFAULT_FORCE_TLS, "force_tls": DEFAULT_FORCE_TLS,
"force_no_tls": True, "force_no_tls": True,
}, },
"http://api.arcade-ai.com:9099", "http://api.arcade.dev:9099",
id="custom port with force no TLS", id="custom port with force no TLS",
), ),
pytest.param( pytest.param(
@ -140,7 +140,7 @@ DEFAULT_FORCE_NO_TLS = False
"force_tls": True, "force_tls": True,
"force_no_tls": True, "force_no_tls": True,
}, },
"http://api.arcade-ai.com", "http://api.arcade.dev",
id="force TLS and no TLS", id="force TLS and no TLS",
), ),
pytest.param( pytest.param(
@ -160,7 +160,7 @@ DEFAULT_FORCE_NO_TLS = False
"force_tls": True, "force_tls": True,
"force_no_tls": True, "force_no_tls": True,
}, },
"http://api.arcade-ai.com:9099", "http://api.arcade.dev:9099",
id="custom port with force TLS and no TLS", id="custom port with force TLS and no TLS",
), ),
pytest.param( pytest.param(
@ -201,7 +201,7 @@ def test_compute_base_url(inputs: dict, expected_output: str):
[ [
pytest.param( pytest.param(
{"host_input": DEFAULT_CLOUD_HOST, "port_input": DEFAULT_PORT, "state": "123"}, {"host_input": DEFAULT_CLOUD_HOST, "port_input": DEFAULT_PORT, "state": "123"},
"https://cloud.arcade-ai.com/api/v1/auth/cli_login?callback_uri=http%3A%2F%2Flocalhost%3A9905%2Fcallback&state=123", "https://cloud.arcade.dev/api/v1/auth/cli_login?callback_uri=http%3A%2F%2Flocalhost%3A9905%2Fcallback&state=123",
id="default", id="default",
), ),
pytest.param( pytest.param(
@ -216,7 +216,7 @@ def test_compute_base_url(inputs: dict, expected_output: str):
), ),
pytest.param( pytest.param(
{"host_input": DEFAULT_CLOUD_HOST, "port_input": 8000, "state": "123"}, {"host_input": DEFAULT_CLOUD_HOST, "port_input": 8000, "state": "123"},
"https://cloud.arcade-ai.com/api/v1/auth/cli_login?callback_uri=http%3A%2F%2Flocalhost%3A9905%2Fcallback&state=123", "https://cloud.arcade.dev/api/v1/auth/cli_login?callback_uri=http%3A%2F%2Flocalhost%3A9905%2Fcallback&state=123",
id="cloud host with an ignored custom port", id="cloud host with an ignored custom port",
), ),
], ],