admin-valentin/arcade-mcp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add tool name and version to otel spans for worker (#690)

Browse source 
Knowing which tools we called seems important

<img width="1554" height="293" alt="Screenshot 2025-11-20 at 1 36 48 PM"
src="https://github.com/user-attachments/assets/1b3cf297-749f-4ea1-9d1c-606707540d5b"
/>

Closes PLT-748
This commit is contained in:
Evan Tahler 2025-11-21 15:53:54 -08:00 committed by GitHub
parent 5602578b2f
commit a921b76ce9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 13 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
libs/arcade-serve/arcade_serve/core/base.py
View file

@ -132,7 +132,12 @@ class BaseWorker(Worker):
logger.debug(f"{execution_id} | Tool inputs: {tool_request.inputs}")
tracer = trace.get_tracer(__name__)
with tracer.start_as_current_span("RunTool"):
with tracer.start_as_current_span("RunTool") as current_span:
current_span.set_attribute("tool_name", str(tool_fqname.name))
current_span.set_attribute("toolkit_version", str(tool_fqname.toolkit_version))
current_span.set_attribute("toolkit_name", str(tool_fqname.toolkit_name))
current_span.set_attribute("environment", self.environment)
output = await ToolExecutor.run(
func=materialized_tool.tool,
definition=materialized_tool.definition,

8
libs/arcade-serve/arcade_serve/core/components.py
View file

@ -66,9 +66,15 @@ class CallToolComponent(WorkerComponent):
Handle the request to call (invoke) a tool.
"""
tracer = trace.get_tracer(__name__)
with tracer.start_as_current_span("CallTool"):
with tracer.start_as_current_span("CallTool") as current_span:
call_tool_request_data = request.body_json
call_tool_request = ToolCallRequest.model_validate(call_tool_request_data)
current_span.set_attribute("tool_name", str(call_tool_request.tool.name))
current_span.set_attribute("toolkit_version", str(call_tool_request.tool.version))
current_span.set_attribute("toolkit_name", str(call_tool_request.tool.toolkit))
current_span.set_attribute("environment", self.worker.environment)
return await self.worker.call_tool(call_tool_request)