admin-valentin/arcade-mcp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix issue in get_channel_metadata_by_name: missing scope for private channels and conversation types filter (#338)

Browse source
This commit is contained in:
Renato Byrro 2025-04-01 17:01:25 -03:00 committed by GitHub
parent 79e3b03a8e
commit cb1fff151b
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 56 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
toolkits/slack/arcade_slack/tools/chat.py
View file

@ -624,7 +624,7 @@ async def get_conversation_metadata_by_id(
return dict(**extract_conversation_metadata(response["channel"])) return dict(**extract_conversation_metadata(response["channel"]))
@tool(requires_auth=Slack(scopes=["channels:read"])) @tool(requires_auth=Slack(scopes=["channels:read", "groups:read"]))
async def get_channel_metadata_by_name( async def get_channel_metadata_by_name(
context: ToolContext, context: ToolContext,
channel_name: Annotated[str, "The name of the channel to get metadata for"], channel_name: Annotated[str, "The name of the channel to get metadata for"],
@ -644,7 +644,14 @@ async def get_channel_metadata_by_name(
should_continue = True should_continue = True
while should_continue: while should_continue:
response = await list_conversations_metadata(context, next_cursor=next_cursor) response = await list_conversations_metadata(
context=context,
conversation_types=[
ConversationType.PUBLIC_CHANNEL,
ConversationType.PRIVATE_CHANNEL,
],
next_cursor=next_cursor,
)
next_cursor = response.get("next_cursor") next_cursor = response.get("next_cursor")
for channel in response["conversations"]: for channel in response["conversations"]:

2
toolkits/slack/pyproject.toml
View file

@ -1,6 +1,6 @@
[tool.poetry] [tool.poetry]
name = "arcade_slack" name = "arcade_slack"
version = "0.4.1" version = "0.4.2"
description = "Slack tools for LLMs" description = "Slack tools for LLMs"
authors = ["Arcade <dev@arcade.dev>"] authors = ["Arcade <dev@arcade.dev>"]

54
toolkits/slack/tests/test_chat.py
View file

@ -322,7 +322,14 @@ async def test_get_conversation_metadata_by_name(
response = await get_channel_metadata_by_name(mock_context, sample_conversation["name"]) response = await get_channel_metadata_by_name(mock_context, sample_conversation["name"])
assert response == sample_conversation assert response == sample_conversation
mock_list_conversations_metadata.assert_called_once_with(mock_context, next_cursor=None) mock_list_conversations_metadata.assert_called_once_with(
context=mock_context,
conversation_types=[
ConversationType.PUBLIC_CHANNEL,
ConversationType.PRIVATE_CHANNEL,
],
next_cursor=None,
)
@pytest.mark.asyncio @pytest.mark.asyncio
@ -349,8 +356,16 @@ async def test_get_channel_metadata_by_name_triggering_pagination(
assert response == target_channel assert response == target_channel
assert mock_list_conversations_metadata.call_count == 2 assert mock_list_conversations_metadata.call_count == 2
mock_list_conversations_metadata.assert_has_calls([ mock_list_conversations_metadata.assert_has_calls([
call(mock_context, next_cursor=None), call(
call(mock_context, next_cursor="123"), context=mock_context,
conversation_types=[ConversationType.PUBLIC_CHANNEL, ConversationType.PRIVATE_CHANNEL],
next_cursor=None,
),
call(
context=mock_context,
conversation_types=[ConversationType.PUBLIC_CHANNEL, ConversationType.PRIVATE_CHANNEL],
next_cursor="123",
),
]) ])
@ -378,8 +393,16 @@ async def test_get_channel_metadata_by_name_not_found(
assert mock_list_conversations_metadata.call_count == 2 assert mock_list_conversations_metadata.call_count == 2
mock_list_conversations_metadata.assert_has_calls([ mock_list_conversations_metadata.assert_has_calls([
call(mock_context, next_cursor=None), call(
call(mock_context, next_cursor="123"), context=mock_context,
conversation_types=[ConversationType.PUBLIC_CHANNEL, ConversationType.PRIVATE_CHANNEL],
next_cursor=None,
),
call(
context=mock_context,
conversation_types=[ConversationType.PUBLIC_CHANNEL, ConversationType.PRIVATE_CHANNEL],
next_cursor="123",
),
]) ])
@ -479,7 +502,14 @@ async def test_get_members_in_channel_by_name(
) )
assert response == mock_get_members_in_conversation_by_id.return_value assert response == mock_get_members_in_conversation_by_id.return_value
mock_list_conversations_metadata.assert_called_once_with(mock_context, next_cursor=None) mock_list_conversations_metadata.assert_called_once_with(
context=mock_context,
conversation_types=[
ConversationType.PUBLIC_CHANNEL,
ConversationType.PRIVATE_CHANNEL,
],
next_cursor=None,
)
mock_get_members_in_conversation_by_id.assert_called_once_with( mock_get_members_in_conversation_by_id.assert_called_once_with(
context=mock_context, context=mock_context,
conversation_id="C12345", conversation_id="C12345",
@ -517,8 +547,16 @@ async def test_get_members_in_channel_by_name_triggering_pagination(
assert response == mock_get_members_in_conversation_by_id.return_value assert response == mock_get_members_in_conversation_by_id.return_value
mock_list_conversations_metadata.assert_has_calls([ mock_list_conversations_metadata.assert_has_calls([
call(mock_context, next_cursor=None), call(
call(mock_context, next_cursor="123"), context=mock_context,
conversation_types=[ConversationType.PUBLIC_CHANNEL, ConversationType.PRIVATE_CHANNEL],
next_cursor=None,
),
call(
context=mock_context,
conversation_types=[ConversationType.PUBLIC_CHANNEL, ConversationType.PRIVATE_CHANNEL],
next_cursor="123",
),
]) ])
mock_get_members_in_conversation_by_id.assert_called_once_with( mock_get_members_in_conversation_by_id.assert_called_once_with(
context=mock_context, context=mock_context,