admin-valentin/arcade-mcp
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix Failing Slack Toolkit Build (#326)

Browse source 
`typing` was being installed and causing builds to fail. [See logs
here](https://github.com/ArcadeAI/arcade-ai/actions/runs/14041206262/job/39311571300)

This PR also removes the `typing-extensions` dependency
This commit is contained in:
Eric Gustin 2025-03-24 12:45:04 -08:00 committed by GitHub
parent 3b8d978e89
commit e7daa1edba
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 6 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
toolkits/slack/arcade_slack/models.py
View file

@ -1,7 +1,5 @@
from enum import Enum
from typing import Optional
from typing_extensions import Literal, NotRequired, TypedDict
from typing import Literal, Optional, TypedDict
from arcade_slack.custom_types import (
SlackOffsetSecondsFromUTC,
@ -174,7 +172,7 @@ class Message(SlackMessage, total=False):
datetime_timestamp: str # Human-readable datetime string (e.g. "2025-01-22 12:00:00")
class ConversationMetadata(TypedDict, total=True):
class ConversationMetadata(TypedDict, total=False):
"""Type definition for the conversation metadata dictionary."""
id: Optional[str]
@ -184,9 +182,9 @@ class ConversationMetadata(TypedDict, total=True):
is_archived: Optional[bool]
is_member: Optional[bool]
purpose: Optional[str]
num_members: NotRequired[Optional[int]]
user: NotRequired[Optional[SlackUser]]
is_user_deleted: NotRequired[Optional[bool]]
num_members: Optional[int]
user: Optional[SlackUser]
is_user_deleted: Optional[bool]
class BasicUserInfo(TypedDict, total=False):

2
toolkits/slack/pyproject.toml
View file

@ -7,10 +7,10 @@ authors = ["Arcade <dev@arcade.dev>"]
[tool.poetry.dependencies]
python = "^3.10"
aiodns = "^1.0" # required by slack - not picked by poetry due to slack requirements txt quirk :/
typing = { version = "*", markers = "python_version < '3.7'" } # prevent aiodns from installing typing package
aiohttp = ">=3.7.3,<4" # same as aiodns, above comment
arcade-ai = ">=0.1,<2.0"
slack-sdk = "^3.31.0"
typing-extensions = "^4.0.0" # some typing annotations aren't available in older versions of python
[tool.poetry.dev-dependencies]
pytest = "^8.3.0"