From feb83c95cadef1839d0fc9daa8b7a94071d2fc11 Mon Sep 17 00:00:00 2001 From: Eric Gustin <34000337+EricGustin@users.noreply.github.com> Date: Tue, 7 Jan 2025 13:21:55 -0800 Subject: [PATCH] Pin poetry to 1.8.5 (#193) # PR Description Poetry released v2 with many breaking changes a couple days ago. The `install-poetry` action that our workflows use default to that v2 version, so many of our workflows are failing. This PR forces that action to use poetry version 1.8.5 and also uses 1.8.5 for toolkits A ticket to migrate to 2.0.0 has been filed for future work --- .github/actions/setup-poetry-env/action.yml | 1 + .github/workflows/main.yml | 2 ++ .github/workflows/publish-toolkit.yml | 2 ++ .github/workflows/release-containers.yml | 2 ++ .github/workflows/test-toolkits.yml | 2 ++ .../.github/actions/setup-poetry-env/action.yml | 1 + .../templates/{{ toolkit_name }}/.github/workflows/main.yml | 2 ++ arcade/arcade/templates/{{ toolkit_name }}/Makefile | 2 +- toolkits/code_sandbox/Makefile | 2 +- toolkits/github/Makefile | 2 +- toolkits/google/Makefile | 2 +- toolkits/linkedin/Makefile | 2 +- toolkits/math/Makefile | 2 +- toolkits/search/Makefile | 2 +- toolkits/slack/Makefile | 2 +- toolkits/spotify/Makefile | 2 +- toolkits/web/Makefile | 2 +- toolkits/x/Makefile | 2 +- toolkits/zoom/Makefile | 2 +- 19 files changed, 24 insertions(+), 12 deletions(-) diff --git a/.github/actions/setup-poetry-env/action.yml b/.github/actions/setup-poetry-env/action.yml index ad665590..507b64de 100644 --- a/.github/actions/setup-poetry-env/action.yml +++ b/.github/actions/setup-poetry-env/action.yml @@ -18,6 +18,7 @@ runs: - name: Install Poetry uses: snok/install-poetry@v1 with: + version: 1.8.5 virtualenvs-in-project: true - name: Generate poetry.lock diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml index 7cbf2eec..21e4a3c2 100644 --- a/.github/workflows/main.yml +++ b/.github/workflows/main.yml @@ -42,6 +42,8 @@ jobs: - name: Install Poetry uses: snok/install-poetry@v1 + with: + version: 1.8.5 - name: Load cached venv uses: actions/cache@v4 diff --git a/.github/workflows/publish-toolkit.yml b/.github/workflows/publish-toolkit.yml index f1aa0e7f..4e9375a4 100644 --- a/.github/workflows/publish-toolkit.yml +++ b/.github/workflows/publish-toolkit.yml @@ -33,6 +33,8 @@ jobs: - name: Install Poetry uses: snok/install-poetry@v1 + with: + version: 1.8.5 - uses: actions/setup-python@v5 with: diff --git a/.github/workflows/release-containers.yml b/.github/workflows/release-containers.yml index 532ea394..5c7de1c1 100644 --- a/.github/workflows/release-containers.yml +++ b/.github/workflows/release-containers.yml @@ -40,6 +40,8 @@ jobs: - name: Install Poetry uses: snok/install-poetry@v1 + with: + version: 1.8.5 - name: Set up Docker Buildx uses: docker/setup-buildx-action@v2 diff --git a/.github/workflows/test-toolkits.yml b/.github/workflows/test-toolkits.yml index b13fea6c..cb6ae072 100644 --- a/.github/workflows/test-toolkits.yml +++ b/.github/workflows/test-toolkits.yml @@ -39,6 +39,8 @@ jobs: - name: Install Poetry uses: snok/install-poetry@v1 + with: + version: 1.8.5 - uses: actions/setup-python@v5 with: diff --git a/arcade/arcade/templates/{{ toolkit_name }}/.github/actions/setup-poetry-env/action.yml b/arcade/arcade/templates/{{ toolkit_name }}/.github/actions/setup-poetry-env/action.yml index d9f5c9cc..dd8d25a4 100644 --- a/arcade/arcade/templates/{{ toolkit_name }}/.github/actions/setup-poetry-env/action.yml +++ b/arcade/arcade/templates/{{ toolkit_name }}/.github/actions/setup-poetry-env/action.yml @@ -18,6 +18,7 @@ runs: - name: Install Poetry uses: snok/install-poetry@v1 with: + version: 1.8.5 virtualenvs-in-project: true - name: Generate poetry.lock diff --git a/arcade/arcade/templates/{{ toolkit_name }}/.github/workflows/main.yml b/arcade/arcade/templates/{{ toolkit_name }}/.github/workflows/main.yml index bf9c2de4..ce8b873b 100644 --- a/arcade/arcade/templates/{{ toolkit_name }}/.github/workflows/main.yml +++ b/arcade/arcade/templates/{{ toolkit_name }}/.github/workflows/main.yml @@ -42,6 +42,8 @@ jobs: - name: Install Poetry uses: snok/install-poetry@v1 + with: + version: 1.8.5 - name: Load cached venv uses: actions/cache@v4 diff --git a/arcade/arcade/templates/{{ toolkit_name }}/Makefile b/arcade/arcade/templates/{{ toolkit_name }}/Makefile index dfcc004d..48f7ff6b 100644 --- a/arcade/arcade/templates/{{ toolkit_name }}/Makefile +++ b/arcade/arcade/templates/{{ toolkit_name }}/Makefile @@ -9,7 +9,7 @@ install: ## Install the poetry environment and install the pre-commit hooks @echo "📦 Checking if Poetry is installed" @if ! command -v poetry &> /dev/null; then \ echo "📦 Installing Poetry with pip"; \ - pip install poetry; \ + pip install poetry==1.8.5; \ else \ echo "📦 Poetry is already installed"; \ fi diff --git a/toolkits/code_sandbox/Makefile b/toolkits/code_sandbox/Makefile index 68003ca4..3ded2851 100644 --- a/toolkits/code_sandbox/Makefile +++ b/toolkits/code_sandbox/Makefile @@ -9,7 +9,7 @@ install: ## Install the poetry environment and install the pre-commit hooks @echo "📦 Checking if Poetry is installed" @if ! command -v poetry &> /dev/null; then \ echo "📦 Installing Poetry with pip"; \ - pip install poetry; \ + pip install poetry==1.8.5; \ else \ echo "📦 Poetry is already installed"; \ fi diff --git a/toolkits/github/Makefile b/toolkits/github/Makefile index ecc0d79e..df42f6d8 100644 --- a/toolkits/github/Makefile +++ b/toolkits/github/Makefile @@ -9,7 +9,7 @@ install: ## Install the poetry environment and install the pre-commit hooks @echo "📦 Checking if Poetry is installed" @if ! command -v poetry &> /dev/null; then \ echo "📦 Installing Poetry with pip"; \ - pip install poetry; \ + pip install poetry==1.8.5; \ else \ echo "📦 Poetry is already installed"; \ fi diff --git a/toolkits/google/Makefile b/toolkits/google/Makefile index 56ed319e..874ba35f 100644 --- a/toolkits/google/Makefile +++ b/toolkits/google/Makefile @@ -9,7 +9,7 @@ install: ## Install the poetry environment and install the pre-commit hooks @echo "📦 Checking if Poetry is installed" @if ! command -v poetry &> /dev/null; then \ echo "📦 Installing Poetry with pip"; \ - pip install poetry; \ + pip install poetry==1.8.5; \ else \ echo "📦 Poetry is already installed"; \ fi diff --git a/toolkits/linkedin/Makefile b/toolkits/linkedin/Makefile index 4657b42c..54e9af14 100644 --- a/toolkits/linkedin/Makefile +++ b/toolkits/linkedin/Makefile @@ -9,7 +9,7 @@ install: ## Install the poetry environment and install the pre-commit hooks @echo "📦 Checking if Poetry is installed" @if ! command -v poetry &> /dev/null; then \ echo "📦 Installing Poetry with pip"; \ - pip install poetry; \ + pip install poetry==1.8.5; \ else \ echo "📦 Poetry is already installed"; \ fi diff --git a/toolkits/math/Makefile b/toolkits/math/Makefile index 4fb67549..27952192 100644 --- a/toolkits/math/Makefile +++ b/toolkits/math/Makefile @@ -9,7 +9,7 @@ install: ## Install the poetry environment and install the pre-commit hooks @echo "📦 Checking if Poetry is installed" @if ! command -v poetry &> /dev/null; then \ echo "📦 Installing Poetry with pip"; \ - pip install poetry; \ + pip install poetry==1.8.5; \ else \ echo "📦 Poetry is already installed"; \ fi diff --git a/toolkits/search/Makefile b/toolkits/search/Makefile index a0626464..75a9dd7f 100644 --- a/toolkits/search/Makefile +++ b/toolkits/search/Makefile @@ -9,7 +9,7 @@ install: ## Install the poetry environment and install the pre-commit hooks @echo "📦 Checking if Poetry is installed" @if ! command -v poetry &> /dev/null; then \ echo "📦 Installing Poetry with pip"; \ - pip install poetry; \ + pip install poetry==1.8.5; \ else \ echo "📦 Poetry is already installed"; \ fi diff --git a/toolkits/slack/Makefile b/toolkits/slack/Makefile index f0a8a0a1..8261337f 100644 --- a/toolkits/slack/Makefile +++ b/toolkits/slack/Makefile @@ -9,7 +9,7 @@ install: ## Install the poetry environment and install the pre-commit hooks @echo "📦 Checking if Poetry is installed" @if ! command -v poetry &> /dev/null; then \ echo "📦 Installing Poetry with pip"; \ - pip install poetry; \ + pip install poetry==1.8.5; \ else \ echo "📦 Poetry is already installed"; \ fi diff --git a/toolkits/spotify/Makefile b/toolkits/spotify/Makefile index 5ed46930..51a56477 100644 --- a/toolkits/spotify/Makefile +++ b/toolkits/spotify/Makefile @@ -9,7 +9,7 @@ install: ## Install the poetry environment and install the pre-commit hooks @echo "📦 Checking if Poetry is installed" @if ! command -v poetry &> /dev/null; then \ echo "📦 Installing Poetry with pip"; \ - pip install poetry; \ + pip install poetry==1.8.5; \ else \ echo "📦 Poetry is already installed"; \ fi diff --git a/toolkits/web/Makefile b/toolkits/web/Makefile index 78bc47bf..ef5ab299 100644 --- a/toolkits/web/Makefile +++ b/toolkits/web/Makefile @@ -9,7 +9,7 @@ install: ## Install the poetry environment and install the pre-commit hooks @echo "📦 Checking if Poetry is installed" @if ! command -v poetry &> /dev/null; then \ echo "📦 Installing Poetry with pip"; \ - pip install poetry; \ + pip install poetry==1.8.5; \ else \ echo "📦 Poetry is already installed"; \ fi diff --git a/toolkits/x/Makefile b/toolkits/x/Makefile index 64b07b37..35030196 100644 --- a/toolkits/x/Makefile +++ b/toolkits/x/Makefile @@ -9,7 +9,7 @@ install: ## Install the poetry environment and install the pre-commit hooks @echo "📦 Checking if Poetry is installed" @if ! command -v poetry &> /dev/null; then \ echo "📦 Installing Poetry with pip"; \ - pip install poetry; \ + pip install poetry==1.8.5; \ else \ echo "📦 Poetry is already installed"; \ fi diff --git a/toolkits/zoom/Makefile b/toolkits/zoom/Makefile index 68003ca4..3ded2851 100644 --- a/toolkits/zoom/Makefile +++ b/toolkits/zoom/Makefile @@ -9,7 +9,7 @@ install: ## Install the poetry environment and install the pre-commit hooks @echo "📦 Checking if Poetry is installed" @if ! command -v poetry &> /dev/null; then \ echo "📦 Installing Poetry with pip"; \ - pip install poetry; \ + pip install poetry==1.8.5; \ else \ echo "📦 Poetry is already installed"; \ fi