30739dc44a
Adds `Jira.GetAvailableAtlassianClouds` tool, which provides a list of clouds available (checking which Clouds were actually authorized by the current auth token). Refactors the interface of every tool to accept an `atlassian_cloud_id` argument (when not provided, try to get a unique cloud ID - if multiple are available, raises a Retryable error with the list of Clouds available instructing to select one). Gets rid of all caching. Now storing the global semaphore to the context object. The global semaphore is important because some tools depend on others, and each tool instantiates its own Jira HTTP client. Storing the semaphore in the context object ensures that all HTTP clients will respect the concurrency limit. Removes from tool responses the Atlassian URLs linking to objects in the Jira GUI (users, projects, issues, etc. We do not keep track of the cloud name anymore, which is required to build the objects' URLs. Extends/refactors unit tests accordingly. Evals checking LLM behavior when: - a cloud ID is explicitly mentioned in the prompt; - no cloud ID is mentioned; - a "multiple clouds available" error is raised and the user is prompted to pick one; - user request triggers another tool call after having previously picked a cloud ID (in the same chat context);
93 lines
3.1 KiB
Python
93 lines
3.1 KiB
Python
from collections.abc import Callable
|
|
|
|
import pytest
|
|
from arcade_tdk import ToolContext
|
|
|
|
from arcade_jira.exceptions import MultipleItemsFoundError, NotFoundError
|
|
from arcade_jira.utils import clean_project_dict, find_unique_project
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_find_unique_project_by_id_success(
|
|
mock_context: ToolContext,
|
|
mock_httpx_client,
|
|
mock_httpx_response: Callable,
|
|
build_project_dict: Callable,
|
|
):
|
|
sample_project = build_project_dict()
|
|
project_response = mock_httpx_response(200, sample_project)
|
|
mock_httpx_client.get.return_value = project_response
|
|
|
|
response = await find_unique_project(mock_context, sample_project["id"])
|
|
assert response == clean_project_dict(sample_project)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_find_unique_project_by_name_with_a_single_match(
|
|
mock_context: ToolContext,
|
|
mock_httpx_client,
|
|
mock_httpx_response: Callable,
|
|
build_project_dict: Callable,
|
|
build_project_search_response_dict: Callable,
|
|
):
|
|
sample_project = build_project_dict()
|
|
get_project_by_id_response = mock_httpx_response(404, {})
|
|
get_projects_without_id_response = mock_httpx_response(
|
|
200, build_project_search_response_dict([sample_project])
|
|
)
|
|
mock_httpx_client.get.side_effect = [
|
|
get_project_by_id_response,
|
|
get_projects_without_id_response,
|
|
]
|
|
|
|
response = await find_unique_project(mock_context, sample_project["name"].lower())
|
|
assert response == clean_project_dict(sample_project)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_find_unique_project_by_name_with_multiple_matches(
|
|
mock_context: ToolContext,
|
|
mock_httpx_client,
|
|
mock_httpx_response: Callable,
|
|
build_project_dict: Callable,
|
|
build_project_search_response_dict: Callable,
|
|
generate_random_str: Callable,
|
|
):
|
|
project_name = generate_random_str()
|
|
sample_projects = [
|
|
build_project_dict(name=project_name),
|
|
build_project_dict(name=project_name),
|
|
]
|
|
get_project_by_id_response = mock_httpx_response(404, {})
|
|
search_projects_response = mock_httpx_response(
|
|
200, build_project_search_response_dict(sample_projects)
|
|
)
|
|
mock_httpx_client.get.side_effect = [
|
|
get_project_by_id_response,
|
|
search_projects_response,
|
|
]
|
|
|
|
with pytest.raises(MultipleItemsFoundError) as exc:
|
|
await find_unique_project(mock_context, sample_projects[0]["name"].lower())
|
|
|
|
assert sample_projects[0]["id"] in exc.value.message
|
|
assert sample_projects[1]["id"] in exc.value.message
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_find_unique_project_by_name_without_matches(
|
|
mock_context: ToolContext,
|
|
mock_httpx_client,
|
|
mock_httpx_response: Callable,
|
|
generate_random_str: Callable,
|
|
build_project_search_response_dict: Callable,
|
|
):
|
|
get_project_by_id_response = mock_httpx_response(404, {})
|
|
search_projects_response = mock_httpx_response(200, build_project_search_response_dict([]))
|
|
mock_httpx_client.get.side_effect = [
|
|
get_project_by_id_response,
|
|
search_projects_response,
|
|
]
|
|
|
|
with pytest.raises(NotFoundError):
|
|
await find_unique_project(mock_context, generate_random_str())
|