b6b4cd0a4c
### Overview Major restructuring from monolithic `arcade-ai` package to modular library architecture with standardized uv-based dependency management.  ### New Package Structure - **`arcade-tdk`** - Lightweight toolkit development kit (core decorators, auth) - **`arcade-core`** - Core execution engine and catalog functionality - **`arcade-serve`** - FastAPI/MCP server components - **`arcade-ai`** - Meta package that includes CLI functionality. Optionally include evals via the `evals` extra. Optionally include all packages via the `all` extra. ### Key Benefits - **Lighter Dependencies**: Toolkits now depend only on `arcade-tdk` (~2 deps) vs full `arcade-ai` (~30+ deps) - **Faster Builds**: uv provides 10-100x faster dependency resolution and installation - **Better Modularity**: Clear separation of concerns, consumers import only what they need - **Standard Tooling**: Eliminates custom poetry scripts, uses standard Python packaging ### Migration Impact - All 20 toolkits converted from poetry → uv with `arcade-tdk` dependencies plus `arcade-ai[evals]` and `arcade-serve` dev dependencies. When developing locally, devs should install toolkits via `make install-local`. - Modern Python 3.10+ type hints throughout - Standardized build system with hatchling backend - Enhanced Makefile with robust toolkit management commands - Removed `arcade dev` CLI command - Reduce the number of files created by `arcade new` and add an option to not generate a tests and evals folder. This foundation enables faster development cycles and cleaner dependency chains for the growing toolkit ecosystem. ### Todo After this PR is merged - [ ] Post-merge workflow(s) (release & publish containers, etc) - [ ] Release order plan. @EricGustin suggests releasing in the following order: 1. `arcade-core` version 0.1.0 2. `arcade-serve` version 0.1.0 and `arcade-tdk` version 0.1.0 3. `arcade-ai` version 2.0.0 4. Patch release for all toolkits (all changes in toolkits are internal refactors) - [ ] [Update docs](https://github.com/ArcadeAI/docs/pull/318) --------- Co-authored-by: Eric Gustin <eric@arcade.dev> Co-authored-by: Eric Gustin <34000337+EricGustin@users.noreply.github.com>
79 lines
2.9 KiB
Python
79 lines
2.9 KiB
Python
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
from arcade_cli.constants import PROD_ENGINE_HOST
|
|
from arcade_cli.main import cli
|
|
from typer.testing import CliRunner
|
|
|
|
runner = CliRunner()
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"args, expected_url",
|
|
[
|
|
([], f"https://{PROD_ENGINE_HOST}/dashboard"),
|
|
(["--local"], "http://localhost:9099/dashboard"),
|
|
(["--host", "custom.host.com"], "https://custom.host.com/dashboard"),
|
|
(["-h", "api.arcade.dev", "-p", "9099"], "https://api.arcade.dev:9099/dashboard"),
|
|
(["--local", "--port", "9099"], "http://localhost:9099/dashboard"),
|
|
(["--local", "--tls"], "https://localhost:9099/dashboard"),
|
|
(["--no-tls"], f"http://{PROD_ENGINE_HOST}/dashboard"),
|
|
],
|
|
)
|
|
def test_dashboard_url_construction(args, expected_url):
|
|
"""Test that the dashboard command constructs the correct URL with various args."""
|
|
with (
|
|
patch("webbrowser.open") as mock_open,
|
|
patch("arcade_cli.main.validate_and_get_config") as mock_validate,
|
|
patch("arcade_cli.main.log_engine_health") as mock_health_check,
|
|
):
|
|
# Setup mocks
|
|
mock_open.return_value = True # Successfully opened browser
|
|
mock_validate.return_value = MagicMock()
|
|
mock_health_check.return_value = None # Successful health check
|
|
|
|
# Run command
|
|
result = runner.invoke(cli, ["dashboard", *args])
|
|
|
|
assert result.exit_code == 0
|
|
mock_open.assert_called_once_with(expected_url)
|
|
mock_health_check.assert_called_once()
|
|
|
|
|
|
def test_fallback_when_browser_fails():
|
|
"""Test fallback message when browser.open fails."""
|
|
with (
|
|
patch("webbrowser.open") as mock_open,
|
|
patch("arcade_cli.main.validate_and_get_config") as mock_validate,
|
|
patch("arcade_cli.main.log_engine_health") as mock_health_check,
|
|
patch("arcade_cli.main.console.print") as mock_print,
|
|
):
|
|
mock_open.return_value = False # Failed to open browser
|
|
mock_validate.return_value = MagicMock()
|
|
mock_health_check.return_value = None
|
|
|
|
result = runner.invoke(cli, ["dashboard"])
|
|
|
|
assert result.exit_code == 0
|
|
mock_print.assert_any_call(
|
|
f"If a browser doesn't open automatically, copy this URL and paste it into your browser: https://{PROD_ENGINE_HOST}/dashboard",
|
|
style="dim",
|
|
)
|
|
|
|
|
|
def test_health_check_success():
|
|
"""Test successful health check."""
|
|
with (
|
|
patch("webbrowser.open") as mock_open,
|
|
patch("arcade_cli.main.validate_and_get_config") as mock_validate,
|
|
patch("arcade_cli.main.log_engine_health") as mock_health_check,
|
|
):
|
|
mock_open.return_value = True
|
|
mock_validate.return_value = MagicMock()
|
|
mock_health_check.return_value = None # Successful health check
|
|
|
|
result = runner.invoke(cli, ["dashboard"])
|
|
|
|
assert result.exit_code == 0
|
|
mock_health_check.assert_called_once()
|
|
mock_open.assert_called_once()
|