# Improvements to Arcade TDK Error Handling
I tried my very best to not make any breaking changes in this PR. So,
you will notice various "Deprecation" notices throughout.
### Instructions for PR reviewers
1. Pull down this PR's branch
2. Pull down the Engine's tool error handling PR's branch
3. Update your installed arcadepy to have the following:
- In `arcadepy/resources/tools/tools.py`, if you want to test out
including stacktraces, then you need to update `ToolsResource.execute`
to accept a `include_error_stacktrace` argument and also include the
"include_error_stacktrace" argument to the POST to the Engine inside of
the function's execute method's body.
- In `arcadepy/types/execute_tool_response.py` add the following enum
```py
class ErrorKind(str, Enum):
"""Error kind that is comprised of
- the who (toolkit, tool, upstream)
- the when (load time, definition parsing time, runtime)
- the what (bad_definition, bad_input, bad_output, retry,
context_required, fatal, etc.)"""
TOOLKIT_LOAD_FAILED = "TOOLKIT_LOAD_FAILED"
TOOL_DEFINITION_BAD_DEFINITION = "TOOL_DEFINITION_BAD_DEFINITION"
TOOL_DEFINITION_BAD_INPUT_SCHEMA = "TOOL_DEFINITION_BAD_INPUT_SCHEMA"
TOOL_DEFINITION_BAD_OUTPUT_SCHEMA = "TOOL_DEFINITION_BAD_OUTPUT_SCHEMA"
TOOL_RUNTIME_BAD_INPUT_VALUE = "TOOL_RUNTIME_BAD_INPUT_VALUE"
TOOL_RUNTIME_BAD_OUTPUT_VALUE = "TOOL_RUNTIME_BAD_OUTPUT_VALUE"
TOOL_RUNTIME_RETRY = "TOOL_RUNTIME_RETRY"
TOOL_RUNTIME_CONTEXT_REQUIRED = "TOOL_RUNTIME_CONTEXT_REQUIRED"
TOOL_RUNTIME_FATAL = "TOOL_RUNTIME_FATAL"
UPSTREAM_RUNTIME_BAD_REQUEST = "UPSTREAM_RUNTIME_BAD_REQUEST"
UPSTREAM_RUNTIME_AUTH_ERROR = "UPSTREAM_RUNTIME_AUTH_ERROR"
UPSTREAM_RUNTIME_NOT_FOUND = "UPSTREAM_RUNTIME_NOT_FOUND"
UPSTREAM_RUNTIME_VALIDATION_ERROR = "UPSTREAM_RUNTIME_VALIDATION_ERROR"
UPSTREAM_RUNTIME_RATE_LIMIT = "UPSTREAM_RUNTIME_RATE_LIMIT"
UPSTREAM_RUNTIME_SERVER_ERROR = "UPSTREAM_RUNTIME_SERVER_ERROR"
UPSTREAM_RUNTIME_UNMAPPED = "UPSTREAM_RUNTIME_UNMAPPED"
UNKNOWN = "UNKNOWN"
```
- In `arcadepy/types/execute_tool_response.py` add the following fields
to OutputError:
```py
kind: ErrorKind
status_code: Optional[int] = None
stacktrace: Optional[str] = None
extra: Optional[dict[str, Any]] = None
```
### Example Client Usage
```py
# Example of handling an upstream rate limit
error = response.output.error
if error and error.kind == ErrorKind.UPSTREAM_RUNTIME_RATE_LIMIT:
sleep_time = error.retry_after_ms / 1000
time.sleep(sleep_time)
# and then execute again
```
```py
# Examples of determining what type of runtime error it is
error = response.output.error
if error:
is_retryable_error = error.kind == ErrorKind.TOOL_RUNTIME_RETRY
is_a_bug_in_the_tool = error.kind == ErrorKind.TOOL_RUNTIME_FATAL
is_additional_context_required = error.kind == ErrorKind.TOOL_RUNTIME_CONTEXT_REQUIRED
```
### Example Tool Usage
```py
# EXAMPLE 1 letting Arcade handle upstream error handling for you
reddit_client.post(params) # Arcade's httpx adapter will handle error handling for you!
# ------------------------------------
# EXAMPLE 2 handling upstream bad request yourself, but letting Arcade handle the rest
try:
reddit_client.post(params)
except httpx.HTTPStatusError as e:
if e.status_code == 400:
raise UpstreamError("My extra custom message) from e
raise
```
```py
# EXAMPLE 1 letting Arcade handle it for you
risky_element = my_risky_list[42] # Arcade will raise a FatalToolError for you
# ------------------------------------
# EXAMPLE 2 handling it yourself for extra flexibility
try:
risky_element = my_risky_list[42]
except IndexError as e:
raise FatalToolError("My extra custom message") from e
```
### Non-runtime Error Message Examples
Example ToolkitLoadError Messages:
```
- [TOOLKIT_LOAD_FAILED] ToolkitLoadError when loading toolkit 'sample_tool': Could not import module mock_module. Reason: Mock import error
- [TOOLKIT_LOAD_FAILED] ToolkitLoadError when loading toolkit 'test_toolkit': Tool 'ValidTool' in toolkit 'test_toolkit' already exists in the catalog.
```
Example ToolDefinitionError Messages
```
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_missing_description': Tool 'tool_missing_description' is missing a description
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_with_invalid_secret_type': Secret keys must be strings (error in tool ToolWithInvalidSecretType).
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_with_empty_secret': Secrets must have a non-empty key (error in tool ToolWithEmptySecret).
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_with_invalid_metadata_type': Metadata must be strings (error in tool ToolWithInvalidMetadataType).
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_with_metadata_requiring_auth_without_auth': Tool ToolWithMetadataRequiringAuthWithoutAuth declares metadata key 'client_id', which requires that the tool has an auth requirement, but no auth requirement was provided. Please specify an auth requirement.
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_with_empty_metadata': Metadata must have a non-empty key (error in tool ToolWithEmptyMetadata).
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_with_unsupported_param_type': Unsupported parameter type: <class 'test_catalog.MyFancyTestClass'>
```
Example ToolInputSchemaError Messages
```
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_missing_input_parameter_annotation': Parameter 'input_text' is missing a description
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_no_type_annotation': Parameter param has no type annotation.
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_invalid_param_name': Invalid parameter name: '123invalid' is not a valid identifier. Identifiers must start with a letter or underscore, and can only contain letters, digits, or underscores.
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_too_many_annotations': Parameter param: Annotated[str, 'name', 'desc', 'extra'] has too many string annotations. Expected 0, 1, or 2, got 3.
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_required_union_param': Parameter param is a union type. Only optional types are supported.
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_non_callable_default_factory': Default factory for parameter param: Annotated[str, 'Parameter'] = FieldInfo(annotation=NoneType, required=False, default_factory=str) is not callable.
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_multiple_tool_contexts': Only one ToolContext parameter is supported, but tool tool_with_multiple_tool_contexts has multiple.
```
Example ToolOutputSchemaError Messages
```
- [TOOL_DEFINITION_BAD_OUTPUT_SCHEMA] ToolOutputSchemaError in definition of tool 'tool_missing_return_type_hint': Tool 'ToolMissingReturnTypeHint' must have a return type
- [TOOL_DEFINITION_BAD_OUTPUT_SCHEMA] ToolOutputSchemaError in definition of tool 'tool_with_unsupported_output_type': Unsupported output type '<class 'test_catalog.MyFancyTestClass'>'. Only built-in Python types, TypedDicts, Pydantic models, and standard collections are supported as tool output types.
```
### Runtime Error Message Examples
Example Tool Runtime Error Messages
```
- [TOOL_RUNTIME_FATAL] FatalToolError during execution of tool 'get_posts_in_subreddit': list index out of range
- [TOOL_RUNTIME_CONTEXT_REQUIRED] ContextRequiredToolError during execution of tool 'get_posts_in_subreddit': Ambiguous username. Please provide a more specific username
- [TOOL_RUNTIME_RETRY] RetryableToolError during execution of tool 'get_posts_in_subreddit': Retry with subreddit=learnpython or subreddit=learnprogramming
```
Example Upstream Runtime Error Messages
```
- [UPSTREAM_RUNTIME_RATE_LIMIT] UpstreamRateLimitError during execution of tool 'get_posts_in_subreddit': 429 Client Error: Too Many Requests
- [UPSTREAM_RUNTIME_BAD_REQUEST] UpstreamError during execution of tool 'get_posts_in_subreddit': 400 Client Error: Bad request. Missing 'id' parameter.
- [UPSTREAM_RUNTIME_BAD_REQUEST] UpstreamError during execution of tool 'search_files': Upstream Google API error: Invalid value '-23'. Values must be within the range: [value: 1\n, value: 1000\n]
```
200 lines
6.6 KiB
Python
200 lines
6.6 KiB
Python
import logging
|
|
from datetime import datetime, timezone
|
|
from typing import Any
|
|
from urllib.parse import urlparse
|
|
|
|
from arcade_core.errors import (
|
|
UpstreamError,
|
|
UpstreamRateLimitError,
|
|
)
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
RATE_HEADERS = ("retry-after", "x-ratelimit-reset", "x-ratelimit-reset-ms")
|
|
|
|
|
|
class BaseHTTPErrorMapper:
|
|
"""Base class for HTTP error mapping functionality."""
|
|
|
|
def _parse_retry_ms(self, headers: dict[str, str]) -> int:
|
|
"""
|
|
Parses a rate limit header and returns the number
|
|
of milliseconds until the rate limit resets.
|
|
|
|
Args:
|
|
headers: A dictionary of HTTP headers.
|
|
|
|
Returns:
|
|
The number of milliseconds until the rate limit resets.
|
|
Defaults to 1000ms if a rate limit header is not found or cannot be parsed.
|
|
"""
|
|
val = next((headers.get(h) for h in RATE_HEADERS if headers.get(h)), None)
|
|
# No rate limit header found
|
|
if val is None:
|
|
return 1_000
|
|
# Rate limit header is a number of seconds
|
|
if val.isdigit():
|
|
key = next((h for h in RATE_HEADERS if headers.get(h) == val), "")
|
|
if key.endswith("ms"):
|
|
return int(val)
|
|
return int(val) * 1_000
|
|
# Rate limit header is an absolute date
|
|
try:
|
|
dt = datetime.strptime(val, "%a, %d %b %Y %H:%M:%S %Z")
|
|
return int((dt - datetime.now(timezone.utc)).total_seconds() * 1_000)
|
|
except Exception:
|
|
logger.warning(f"Failed to parse rate limit header: {val}. Defaulting to 1000ms.")
|
|
return 1_000
|
|
|
|
def _sanitize_uri(self, uri: str) -> str:
|
|
"""Strip query params and fragments from URI for privacy."""
|
|
|
|
parsed = urlparse(uri)
|
|
return f"{parsed.scheme}://{parsed.netloc.strip('/')}/{parsed.path.strip('/')}"
|
|
|
|
def _build_extra_metadata(
|
|
self, request_url: str | None = None, request_method: str | None = None
|
|
) -> dict[str, str]:
|
|
"""Build extra metadata for error reporting."""
|
|
extra = {
|
|
"service": HTTPErrorAdapter.slug,
|
|
}
|
|
|
|
if request_url:
|
|
extra["endpoint"] = self._sanitize_uri(request_url)
|
|
|
|
if request_method:
|
|
extra["http_method"] = request_method.upper()
|
|
|
|
return extra
|
|
|
|
def _map_status_to_error(
|
|
self,
|
|
status: int,
|
|
headers: dict[str, str],
|
|
msg: str,
|
|
request_url: str | None = None,
|
|
request_method: str | None = None,
|
|
) -> UpstreamError:
|
|
"""Map HTTP status code to appropriate Arcade error."""
|
|
extra = self._build_extra_metadata(request_url, request_method)
|
|
|
|
# Special case for rate limiting
|
|
if status == 429:
|
|
return UpstreamRateLimitError(
|
|
retry_after_ms=self._parse_retry_ms(headers),
|
|
message=msg,
|
|
extra=extra,
|
|
)
|
|
|
|
return UpstreamError(message=msg, status_code=status, extra=extra)
|
|
|
|
|
|
class _HTTPXExceptionHandler:
|
|
"""Handler for httpx-specific exceptions."""
|
|
|
|
def handle_exception(self, exc: Any, mapper: BaseHTTPErrorMapper) -> UpstreamError | None:
|
|
"""Handle httpx HTTPStatusError exceptions.
|
|
|
|
Args:
|
|
exc: An httpx.HTTPStatusError exception
|
|
mapper: The BaseHTTPErrorMapper instance to use for mapping
|
|
|
|
Returns:
|
|
An Arcade error instance or None if not an httpx exception
|
|
"""
|
|
# Lazy import httpx types locally to avoid import errors for toolkits that don't use httpx
|
|
try:
|
|
import httpx
|
|
except ImportError:
|
|
return None
|
|
|
|
if not isinstance(exc, httpx.HTTPStatusError):
|
|
return None
|
|
|
|
response = exc.response
|
|
request_url = None
|
|
request_method = None
|
|
if hasattr(exc, "request") and exc.request:
|
|
request_url = str(exc.request.url)
|
|
request_method = exc.request.method
|
|
|
|
return mapper._map_status_to_error(
|
|
response.status_code,
|
|
dict(response.headers),
|
|
str(exc),
|
|
request_url=request_url,
|
|
request_method=request_method,
|
|
)
|
|
|
|
|
|
class _RequestsExceptionHandler:
|
|
"""Handler for requests-specific exceptions."""
|
|
|
|
def handle_exception(self, exc: Any, mapper: BaseHTTPErrorMapper) -> UpstreamError | None:
|
|
"""Handle requests library exceptions.
|
|
|
|
Args:
|
|
exc: A requests.exceptions.HTTPError exception
|
|
mapper: The BaseHTTPErrorMapper instance to use for mapping
|
|
|
|
Returns:
|
|
An Arcade error instance or None if not a requests exception
|
|
"""
|
|
# Lazy import requests types locally to avoid import errors for toolkits that don't use requests
|
|
try:
|
|
from requests.exceptions import HTTPError # type: ignore[import-untyped]
|
|
except ImportError:
|
|
return None
|
|
|
|
if not isinstance(exc, HTTPError):
|
|
return None
|
|
|
|
response = getattr(exc, "response", None)
|
|
if response is None:
|
|
return None
|
|
|
|
# Extract request information
|
|
request_url = None
|
|
request_method = None
|
|
if hasattr(response, "request") and response.request:
|
|
request_url = response.request.url
|
|
request_method = response.request.method
|
|
elif hasattr(response, "url"):
|
|
request_url = response.url
|
|
|
|
return mapper._map_status_to_error(
|
|
response.status_code,
|
|
dict(response.headers),
|
|
str(exc),
|
|
request_url=request_url,
|
|
request_method=request_method,
|
|
)
|
|
|
|
|
|
class HTTPErrorAdapter(BaseHTTPErrorMapper):
|
|
"""Main HTTP error adapter that supports multiple HTTP libraries."""
|
|
|
|
slug = "_http"
|
|
|
|
def __init__(self) -> None:
|
|
self._httpx_handler = _HTTPXExceptionHandler()
|
|
self._requests_handler = _RequestsExceptionHandler()
|
|
|
|
def from_exception(self, exc: Exception) -> UpstreamError | None:
|
|
"""Convert HTTP library exceptions into Arcade errors."""
|
|
|
|
httpx_result = self._httpx_handler.handle_exception(exc, self)
|
|
if httpx_result is not None:
|
|
return httpx_result
|
|
|
|
requests_result = self._requests_handler.handle_exception(exc, self)
|
|
if requests_result is not None:
|
|
return requests_result
|
|
|
|
logger.info(
|
|
f"Exception type '{type(exc).__name__}' was not handled by the '{self.slug}' adapter. "
|
|
f"Either the exception is not from a supported HTTP library (httpx, requests) or "
|
|
f"the required library is not installed in the toolkit's environment."
|
|
)
|
|
return None
|