fe8ddfd500
<!-- CURSOR_SUMMARY --> > [!NOTE] > **Medium Risk** > Touches authentication/login flow, credentials-file permissions, and subprocess lifecycle behavior across platforms; while mostly defensive, regressions could impact login or process management on Windows/macOS runners. > > **Overview** > Improves Windows/cross-platform reliability across the CLI and MCP server: OAuth login now binds the callback server to `127.0.0.1`, avoids slow loopback reverse-DNS, adds a configurable callback timeout (`--timeout` + env default), and opens URLs via a Windows-friendly `_open_browser` to avoid flashing console windows. > > Centralizes CLI output via a shared `console` that forces UTF-8 on Windows, standardizes UTF-8 file reads/writes throughout, tightens credentials-file permissions on Windows using `icacls`, and adds shared Windows subprocess helpers for **no-window** process creation and graceful termination (used by `deploy`, MCP reload, and usage-tracking worker). > > Updates client configuration UX/robustness (Windows AppData resolution via `platformdirs`, Cursor config path fallbacks + compatibility writes, overwrite warnings, absolute `uv` path for GUI clients, safer path display) and improves `deploy` child-process handling to avoid pipe-buffer deadlocks while giving better debug-aware error messages. > > Expands CI to run tests on Linux/Windows/macOS, adds a no-auth CLI integration workflow, disables usage tracking in toolkits CI, and adds extensive regression tests for Windows signals, subprocess cleanup, UTF-8, and config-path edge cases; bumps `arcade-core` to `4.4.2` and `arcade-mcp-server` to `1.17.2` (with updated dependency pin). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0fabd8ca1cd647039ba6ddbdf3f7809c330bab9e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
22 lines
640 B
Python
22 lines
640 B
Python
from pathlib import Path
|
|
|
|
from arcade_cli.utils import get_eval_files
|
|
|
|
|
|
def test_get_eval_files_with_spaces(tmp_path: Path) -> None:
|
|
eval_root = tmp_path / "eval dir with spaces"
|
|
eval_root.mkdir()
|
|
|
|
file_one = eval_root / "eval_one.py"
|
|
file_one.write_text("print('one')\n", encoding="utf-8")
|
|
|
|
nested = eval_root / "nested dir"
|
|
nested.mkdir()
|
|
file_two = nested / "eval_two.py"
|
|
file_two.write_text("print('two')\n", encoding="utf-8")
|
|
|
|
results = get_eval_files(str(eval_root))
|
|
resolved = {p.resolve() for p in results}
|
|
|
|
assert file_one.resolve() in resolved
|
|
assert file_two.resolve() in resolved
|