fe8ddfd500
<!-- CURSOR_SUMMARY --> > [!NOTE] > **Medium Risk** > Touches authentication/login flow, credentials-file permissions, and subprocess lifecycle behavior across platforms; while mostly defensive, regressions could impact login or process management on Windows/macOS runners. > > **Overview** > Improves Windows/cross-platform reliability across the CLI and MCP server: OAuth login now binds the callback server to `127.0.0.1`, avoids slow loopback reverse-DNS, adds a configurable callback timeout (`--timeout` + env default), and opens URLs via a Windows-friendly `_open_browser` to avoid flashing console windows. > > Centralizes CLI output via a shared `console` that forces UTF-8 on Windows, standardizes UTF-8 file reads/writes throughout, tightens credentials-file permissions on Windows using `icacls`, and adds shared Windows subprocess helpers for **no-window** process creation and graceful termination (used by `deploy`, MCP reload, and usage-tracking worker). > > Updates client configuration UX/robustness (Windows AppData resolution via `platformdirs`, Cursor config path fallbacks + compatibility writes, overwrite warnings, absolute `uv` path for GUI clients, safer path display) and improves `deploy` child-process handling to avoid pipe-buffer deadlocks while giving better debug-aware error messages. > > Expands CI to run tests on Linux/Windows/macOS, adds a no-auth CLI integration workflow, disables usage tracking in toolkits CI, and adds extensive regression tests for Windows signals, subprocess cleanup, UTF-8, and config-path edge cases; bumps `arcade-core` to `4.4.2` and `arcade-mcp-server` to `1.17.2` (with updated dependency pin). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0fabd8ca1cd647039ba6ddbdf3f7809c330bab9e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
49 lines
1.8 KiB
Python
49 lines
1.8 KiB
Python
from __future__ import annotations
|
|
|
|
from pathlib import Path
|
|
|
|
import toml
|
|
from packaging.requirements import Requirement
|
|
from packaging.version import Version
|
|
|
|
REPO_ROOT = Path(__file__).resolve().parents[3]
|
|
|
|
|
|
def _load_pyproject(path: Path) -> dict:
|
|
return toml.load(path)
|
|
|
|
|
|
def _get_requirement(dependencies: list[str], package_name: str) -> Requirement:
|
|
for dep in dependencies:
|
|
req = Requirement(dep)
|
|
if req.name == package_name:
|
|
return req
|
|
raise AssertionError(f"Missing dependency for {package_name!r}")
|
|
|
|
|
|
def test_root_dependency_includes_workspace_arcade_core_version() -> None:
|
|
root_pyproject = _load_pyproject(REPO_ROOT / "pyproject.toml")
|
|
core_pyproject = _load_pyproject(REPO_ROOT / "libs/arcade-core/pyproject.toml")
|
|
|
|
root_deps: list[str] = root_pyproject["project"]["dependencies"]
|
|
core_version = Version(core_pyproject["project"]["version"])
|
|
core_req = _get_requirement(root_deps, "arcade-core")
|
|
|
|
assert core_version in core_req.specifier, (
|
|
"Root dependency constraint for arcade-core must include the current "
|
|
f"workspace version {core_version}; got {core_req.specifier!s}"
|
|
)
|
|
|
|
|
|
def test_root_dependency_includes_workspace_arcade_mcp_server_version() -> None:
|
|
root_pyproject = _load_pyproject(REPO_ROOT / "pyproject.toml")
|
|
server_pyproject = _load_pyproject(REPO_ROOT / "libs/arcade-mcp-server/pyproject.toml")
|
|
|
|
root_deps: list[str] = root_pyproject["project"]["dependencies"]
|
|
server_version = Version(server_pyproject["project"]["version"])
|
|
server_req = _get_requirement(root_deps, "arcade-mcp-server")
|
|
|
|
assert server_version in server_req.specifier, (
|
|
"Root dependency constraint for arcade-mcp-server must include the current "
|
|
f"workspace version {server_version}; got {server_req.specifier!s}"
|
|
)
|