fe8ddfd500
<!-- CURSOR_SUMMARY --> > [!NOTE] > **Medium Risk** > Touches authentication/login flow, credentials-file permissions, and subprocess lifecycle behavior across platforms; while mostly defensive, regressions could impact login or process management on Windows/macOS runners. > > **Overview** > Improves Windows/cross-platform reliability across the CLI and MCP server: OAuth login now binds the callback server to `127.0.0.1`, avoids slow loopback reverse-DNS, adds a configurable callback timeout (`--timeout` + env default), and opens URLs via a Windows-friendly `_open_browser` to avoid flashing console windows. > > Centralizes CLI output via a shared `console` that forces UTF-8 on Windows, standardizes UTF-8 file reads/writes throughout, tightens credentials-file permissions on Windows using `icacls`, and adds shared Windows subprocess helpers for **no-window** process creation and graceful termination (used by `deploy`, MCP reload, and usage-tracking worker). > > Updates client configuration UX/robustness (Windows AppData resolution via `platformdirs`, Cursor config path fallbacks + compatibility writes, overwrite warnings, absolute `uv` path for GUI clients, safer path display) and improves `deploy` child-process handling to avoid pipe-buffer deadlocks while giving better debug-aware error messages. > > Expands CI to run tests on Linux/Windows/macOS, adds a no-auth CLI integration workflow, disables usage tracking in toolkits CI, and adds extensive regression tests for Windows signals, subprocess cleanup, UTF-8, and config-path edge cases; bumps `arcade-core` to `4.4.2` and `arcade-mcp-server` to `1.17.2` (with updated dependency pin). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0fabd8ca1cd647039ba6ddbdf3f7809c330bab9e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
83 lines
3.2 KiB
Python
83 lines
3.2 KiB
Python
from unittest.mock import MagicMock, patch
|
|
|
|
import pytest
|
|
from arcade_cli.main import cli
|
|
from arcade_core.constants import PROD_ENGINE_HOST
|
|
from typer.testing import CliRunner
|
|
|
|
runner = CliRunner()
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"args, expected_url",
|
|
[
|
|
([], f"https://{PROD_ENGINE_HOST}/dashboard"),
|
|
(["--local"], "http://localhost:9099/dashboard"),
|
|
(["--host", "custom.host.com"], "https://custom.host.com/dashboard"),
|
|
(["-h", "api.arcade.dev", "-p", "9099"], "https://api.arcade.dev:9099/dashboard"),
|
|
(["--local", "--port", "9099"], "http://localhost:9099/dashboard"),
|
|
(["--local", "--tls"], "https://localhost:9099/dashboard"),
|
|
(["--no-tls"], f"http://{PROD_ENGINE_HOST}/dashboard"),
|
|
],
|
|
)
|
|
def test_dashboard_url_construction(args, expected_url):
|
|
"""Test that the dashboard command constructs the correct URL with various args."""
|
|
with (
|
|
patch("arcade_cli.main._open_browser") as mock_open,
|
|
patch("arcade_cli.utils.validate_and_get_config") as mock_validate,
|
|
patch("arcade_cli.main.log_engine_health") as mock_health_check,
|
|
):
|
|
# Setup mocks
|
|
mock_open.return_value = True # Successfully opened browser
|
|
mock_validate.return_value = MagicMock()
|
|
mock_health_check.return_value = None # Successful health check
|
|
|
|
# Run command
|
|
result = runner.invoke(cli, ["dashboard", *args])
|
|
|
|
assert result.exit_code == 0
|
|
mock_open.assert_called_once_with(expected_url)
|
|
mock_health_check.assert_called_once()
|
|
|
|
|
|
def test_fallback_when_browser_fails():
|
|
"""Test fallback message when _open_browser fails."""
|
|
with (
|
|
patch("arcade_cli.main._open_browser") as mock_open,
|
|
patch("arcade_cli.utils.validate_and_get_config") as mock_validate,
|
|
patch("arcade_cli.main.log_engine_health") as mock_health_check,
|
|
patch("arcade_cli.main.console.print") as mock_print,
|
|
):
|
|
mock_open.return_value = False # Failed to open browser
|
|
mock_validate.return_value = MagicMock()
|
|
mock_health_check.return_value = None
|
|
|
|
result = runner.invoke(cli, ["dashboard"])
|
|
|
|
assert result.exit_code == 0
|
|
# The fallback message should mention the URL and hint about manual paste.
|
|
fallback_calls = [
|
|
call for call in mock_print.call_args_list
|
|
if "browser" in str(call).lower() and "dashboard" in str(call).lower()
|
|
]
|
|
assert len(fallback_calls) >= 1, (
|
|
f"Expected a fallback message about browser. Got calls: {mock_print.call_args_list}"
|
|
)
|
|
|
|
|
|
def test_health_check_success():
|
|
"""Test successful health check."""
|
|
with (
|
|
patch("arcade_cli.main._open_browser") as mock_open,
|
|
patch("arcade_cli.utils.validate_and_get_config") as mock_validate,
|
|
patch("arcade_cli.main.log_engine_health") as mock_health_check,
|
|
):
|
|
mock_open.return_value = True
|
|
mock_validate.return_value = MagicMock()
|
|
mock_health_check.return_value = None # Successful health check
|
|
|
|
result = runner.invoke(cli, ["dashboard"])
|
|
|
|
assert result.exit_code == 0
|
|
mock_health_check.assert_called_once()
|
|
mock_open.assert_called_once()
|