# PR Description ## Split toolkits This PR splits the `Microsoft`, `Google`, and `Search` toolkits into multiple toolkits each. * `Microsoft` --> `OutlookCalendar`, `OutlookMail`. * `Google` -----> `GoogleCalendar`, `GoogleContacts`, `GoogleDocs`, `GoogleDrive`, `Gmail`, `GoogleSheets` * `Search` -----> `GoogleFinance`, `GoogleFlights`, `GoogleHotels`, `GoogleJobs`, `GoogleMaps`, `GoogleNews`, `GoogleSearch`, `GoogleShopping`, `Walmart`, `Youtube` > The original monolithic toolkits (`Microsoft`, `Google`, `Search`) are not removed in this PR. The plan is to keep those toolkits around while we > 1. Stop documenting the toolkits, > 2. Stop displaying the toolkits in the dashboard, and > 3. Help customers migrate over to the new split toolkits. ## Rename toolkits This PR renames the following toolkits * `Web` ------------> `Firecrawl` * `CodeSandbox` ---> `E2B` > The `Web` and `CodeSandbox` toolkits are not removed in this PR. The plan is to keep them around while we > 1. Stop documenting the toolkits, > 2. Stop displaying the toolkits in the dashboard, and > 3. Help customers migrate over to the new renamed toolkits. ## Rename tools Since toolkit names were changed, this called for some tools to be renamed as well. * `GoogleSearch.SearchGoogle` ----------------> `GoogleSearch.Search` * `GoogleShopping.SearchShoppingProducts` ---> `GoogleShopping.SearchProducts` * `Walmart.SearchWalmartProducts` ------------> `Walmart.SearchProducts` * `Walmart.GetWalmartProductDetails` ---------> `Walmart.GetProductDetails` * `Youtube.SearchYoutubeVideos` --------------> `Youtube.SearchForVideos` ## Google File Picker Improvements to the Google File Picker experience were also added in this PR. The following tools will ALWAYS provide llm_instructions in their response to "let the end-user know that they have the option to select more files via the file picker url if they want to": * `GoogleDocs.SearchDocuments` * `GoogleDocs.SearchAndRetrieveDocuments` * `GoogleDrive.GetFileTreeStructure` The following tools will only provide the file picker URL if a 404 or 403 from the Google API: * `GoogleDocs.InsertTextAtEndOfDocument` * `GoogleDocs.GetDocumentById` * `GoogleSheets.GetSpreadsheet` * `GoogleSheets.WriteToCell` Also, a standalone `GoogleDrive.GenerateGoogleFilePickerUrl` tool exists. ## Other * The `SearchDocuments` and `SearchAndRetrieveDocuments` tools used to be organized within the Drive portion of the Google toolkit, but I moved these into the new GoogleDocs toolkit because they are specific to Docs. # Progress - [x] `OutlookCalendar` - [x] `OutlookMail` - [x] `GoogleFinance` - [x] `GoogleFlights` - [x] `GoogleHotels` - [x] `GoogleJobs` - [x] `GoogleMaps` - [x] `GoogleNews` - [x] `GoogleSearch` - [x] `GoogleShopping` - [x] `Walmart` - [x] `Youtube` - [x] `GoogleCalendar` - [x] `GoogleContacts` - [x] `GoogleDocs` - [x] `GoogleDrive` - [x] `Gmail` - [x] `GoogleSheets` - [x] `Firecrawl` - [x] `E2B` - [x] File picker # Discussion * Repeated code is a consequence of splitting toolkits that use the same provider. I am open to any ideas that would allow multiple toolkits to reference common code. Comment your ideas in this PR.
100 lines
3.5 KiB
Python
100 lines
3.5 KiB
Python
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
from arcade_tdk import ToolContext
|
|
|
|
from arcade_google_contacts.tools import create_contact
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_context():
|
|
context = AsyncMock(spec=ToolContext)
|
|
context.authorization = MagicMock()
|
|
context.authorization.token = "mock_token" # noqa: S105
|
|
return context
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_contact_success(mock_context):
|
|
# Test create_contact with all parameters (given, family names and email)
|
|
created_contact_data = {"resourceName": "people/123", "etag": "abc"}
|
|
|
|
create_contact_call = MagicMock()
|
|
create_contact_call.execute.return_value = created_contact_data
|
|
|
|
people_mock = MagicMock()
|
|
people_mock.createContact.return_value = create_contact_call
|
|
|
|
service_mock = MagicMock()
|
|
service_mock.people.return_value = people_mock
|
|
|
|
with patch(
|
|
"arcade_google_contacts.tools.contacts.build_people_service", return_value=service_mock
|
|
) as mock_build:
|
|
result = await create_contact(
|
|
mock_context,
|
|
given_name="Alice",
|
|
family_name="Smith",
|
|
email="alice@example.com",
|
|
)
|
|
assert "contact" in result
|
|
assert result["contact"] == created_contact_data
|
|
|
|
# Verify that the createContact API was called with the correct body contents.
|
|
expected_body = {
|
|
"names": [{"givenName": "Alice", "familyName": "Smith"}],
|
|
"emailAddresses": [{"value": "alice@example.com", "type": "work"}],
|
|
}
|
|
people_mock.createContact.assert_called_once_with(
|
|
body=expected_body, personFields="names,emailAddresses"
|
|
)
|
|
mock_build.assert_called_once()
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_contact_success_without_optional(mock_context):
|
|
# Test create_contact without optional parameters family_name and email.
|
|
created_contact_data = {"resourceName": "people/456", "etag": "def"}
|
|
|
|
create_contact_call = MagicMock()
|
|
create_contact_call.execute.return_value = created_contact_data
|
|
|
|
people_mock = MagicMock()
|
|
people_mock.createContact.return_value = create_contact_call
|
|
|
|
service_mock = MagicMock()
|
|
service_mock.people.return_value = people_mock
|
|
|
|
with patch(
|
|
"arcade_google_contacts.tools.contacts.build_people_service", return_value=service_mock
|
|
):
|
|
result = await create_contact(mock_context, given_name="Bob", family_name=None, email=None)
|
|
assert "contact" in result
|
|
assert result["contact"] == created_contact_data
|
|
|
|
# Expected body should only include the givenName when family_name and email are omitted.
|
|
expected_body = {"names": [{"givenName": "Bob"}]}
|
|
people_mock.createContact.assert_called_once_with(
|
|
body=expected_body, personFields="names,emailAddresses"
|
|
)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_create_contact_error(mock_context):
|
|
# Simulate an error thrown by createContact
|
|
error_call = MagicMock()
|
|
error_call.execute.side_effect = Exception("Create error")
|
|
|
|
people_mock = MagicMock()
|
|
people_mock.createContact.return_value = error_call
|
|
|
|
service_mock = MagicMock()
|
|
service_mock.people.return_value = people_mock
|
|
|
|
with (
|
|
patch(
|
|
"arcade_google_contacts.tools.contacts.build_people_service", return_value=service_mock
|
|
),
|
|
pytest.raises(Exception, match="Error in execution of CreateContact"),
|
|
):
|
|
await create_contact(mock_context, given_name="Alice", family_name="Doe", email=None)
|