07c52100f3
# PR Description ## Split toolkits This PR splits the `Microsoft`, `Google`, and `Search` toolkits into multiple toolkits each. * `Microsoft` --> `OutlookCalendar`, `OutlookMail`. * `Google` -----> `GoogleCalendar`, `GoogleContacts`, `GoogleDocs`, `GoogleDrive`, `Gmail`, `GoogleSheets` * `Search` -----> `GoogleFinance`, `GoogleFlights`, `GoogleHotels`, `GoogleJobs`, `GoogleMaps`, `GoogleNews`, `GoogleSearch`, `GoogleShopping`, `Walmart`, `Youtube` > The original monolithic toolkits (`Microsoft`, `Google`, `Search`) are not removed in this PR. The plan is to keep those toolkits around while we > 1. Stop documenting the toolkits, > 2. Stop displaying the toolkits in the dashboard, and > 3. Help customers migrate over to the new split toolkits. ## Rename toolkits This PR renames the following toolkits * `Web` ------------> `Firecrawl` * `CodeSandbox` ---> `E2B` > The `Web` and `CodeSandbox` toolkits are not removed in this PR. The plan is to keep them around while we > 1. Stop documenting the toolkits, > 2. Stop displaying the toolkits in the dashboard, and > 3. Help customers migrate over to the new renamed toolkits. ## Rename tools Since toolkit names were changed, this called for some tools to be renamed as well. * `GoogleSearch.SearchGoogle` ----------------> `GoogleSearch.Search` * `GoogleShopping.SearchShoppingProducts` ---> `GoogleShopping.SearchProducts` * `Walmart.SearchWalmartProducts` ------------> `Walmart.SearchProducts` * `Walmart.GetWalmartProductDetails` ---------> `Walmart.GetProductDetails` * `Youtube.SearchYoutubeVideos` --------------> `Youtube.SearchForVideos` ## Google File Picker Improvements to the Google File Picker experience were also added in this PR. The following tools will ALWAYS provide llm_instructions in their response to "let the end-user know that they have the option to select more files via the file picker url if they want to": * `GoogleDocs.SearchDocuments` * `GoogleDocs.SearchAndRetrieveDocuments` * `GoogleDrive.GetFileTreeStructure` The following tools will only provide the file picker URL if a 404 or 403 from the Google API: * `GoogleDocs.InsertTextAtEndOfDocument` * `GoogleDocs.GetDocumentById` * `GoogleSheets.GetSpreadsheet` * `GoogleSheets.WriteToCell` Also, a standalone `GoogleDrive.GenerateGoogleFilePickerUrl` tool exists. ## Other * The `SearchDocuments` and `SearchAndRetrieveDocuments` tools used to be organized within the Drive portion of the Google toolkit, but I moved these into the new GoogleDocs toolkit because they are specific to Docs. # Progress - [x] `OutlookCalendar` - [x] `OutlookMail` - [x] `GoogleFinance` - [x] `GoogleFlights` - [x] `GoogleHotels` - [x] `GoogleJobs` - [x] `GoogleMaps` - [x] `GoogleNews` - [x] `GoogleSearch` - [x] `GoogleShopping` - [x] `Walmart` - [x] `Youtube` - [x] `GoogleCalendar` - [x] `GoogleContacts` - [x] `GoogleDocs` - [x] `GoogleDrive` - [x] `Gmail` - [x] `GoogleSheets` - [x] `Firecrawl` - [x] `E2B` - [x] File picker # Discussion * Repeated code is a consequence of splitting toolkits that use the same provider. I am open to any ideas that would allow multiple toolkits to reference common code. Comment your ideas in this PR.
43 lines
1.7 KiB
Python
43 lines
1.7 KiB
Python
import pytest
|
|
from msgraph.generated.models.email_address import EmailAddress as GraphEmailAddress
|
|
from msgraph.generated.models.recipient import Recipient as GraphRecipient
|
|
|
|
from arcade_outlook_mail.message import Recipient
|
|
|
|
|
|
@pytest.mark.parametrize(
|
|
"input_sdk_recipient, expected_email, expected_name",
|
|
[
|
|
(
|
|
GraphRecipient(email_address=GraphEmailAddress(address="dev@arcade.dev", name="Dev")),
|
|
"dev@arcade.dev",
|
|
"Dev",
|
|
),
|
|
(
|
|
GraphRecipient(email_address=GraphEmailAddress(address="dev@arcade.dev")),
|
|
"dev@arcade.dev",
|
|
"",
|
|
),
|
|
(GraphRecipient(email_address=GraphEmailAddress(name="Dev")), "", "Dev"),
|
|
(GraphRecipient(email_address=GraphEmailAddress()), "", ""),
|
|
(GraphRecipient(), "", ""),
|
|
],
|
|
)
|
|
def test_recipient(input_sdk_recipient, expected_email, expected_name):
|
|
recipient = Recipient.from_sdk(input_sdk_recipient)
|
|
assert (
|
|
recipient.email_address == expected_email
|
|
), "SDK conversion didn't set email_address correctly"
|
|
assert recipient.name == expected_name, "SDK conversion didn't set name correctly"
|
|
|
|
recipient_dict = recipient.to_dict()
|
|
expected_dict = {"email_address": expected_email, "name": expected_name}
|
|
assert recipient_dict == expected_dict, "to_dict conversion did not produce expected dictionary"
|
|
|
|
actual_sdk_recipient = recipient.to_sdk()
|
|
assert (
|
|
actual_sdk_recipient.email_address.address == expected_email
|
|
), "to_sdk conversion produced wrong email address"
|
|
assert (
|
|
actual_sdk_recipient.email_address.name == expected_name
|
|
), "to_sdk conversion produced wrong name"
|