arcade-mcp/libs/tests/tool/test_create_tool_definition_errors.py
Sam Partee b6b4cd0a4c
🏗️ Restructure: Multi-Package Architecture + uv Migration (#412)
### Overview
Major restructuring from monolithic `arcade-ai` package to modular
library architecture with standardized uv-based dependency management.

![arcade-ai Monorepo
(2)](https://github.com/user-attachments/assets/25f102b0-bb87-4a04-9701-d227d05664b1)

### New Package Structure
- **`arcade-tdk`** - Lightweight toolkit development kit (core
decorators, auth)
- **`arcade-core`** - Core execution engine and catalog functionality  
- **`arcade-serve`** - FastAPI/MCP server components
- **`arcade-ai`** - Meta package that includes CLI functionality.
Optionally include evals via the `evals` extra. Optionally include all
packages via the `all` extra.

### Key Benefits
- **Lighter Dependencies**: Toolkits now depend only on `arcade-tdk` (~2
deps) vs full `arcade-ai` (~30+ deps)
- **Faster Builds**: uv provides 10-100x faster dependency resolution
and installation
- **Better Modularity**: Clear separation of concerns, consumers import
only what they need
- **Standard Tooling**: Eliminates custom poetry scripts, uses standard
Python packaging

### Migration Impact
- All 20 toolkits converted from poetry → uv with `arcade-tdk`
dependencies plus `arcade-ai[evals]` and `arcade-serve` dev
dependencies. When developing locally, devs should install toolkits via
`make install-local`.
- Modern Python 3.10+ type hints throughout
- Standardized build system with hatchling backend
- Enhanced Makefile with robust toolkit management commands
- Removed `arcade dev` CLI command
- Reduce the number of files created by `arcade new` and add an option
to not generate a tests and evals folder.

This foundation enables faster development cycles and cleaner dependency
chains for the growing toolkit ecosystem.

### Todo After this PR is merged
- [ ] Post-merge workflow(s) (release & publish containers, etc)
- [ ] Release order plan. @EricGustin suggests releasing in the
following order:
    1. `arcade-core` version 0.1.0
    2. `arcade-serve` version 0.1.0 and `arcade-tdk` version 0.1.0
    3. `arcade-ai` version 2.0.0
4. Patch release for all toolkits (all changes in toolkits are internal
refactors)
- [ ] [Update docs](https://github.com/ArcadeAI/docs/pull/318)

---------

Co-authored-by: Eric Gustin <eric@arcade.dev>
Co-authored-by: Eric Gustin <34000337+EricGustin@users.noreply.github.com>
2025-06-11 16:48:17 -07:00

194 lines
5.5 KiB
Python

from typing import Annotated, Union
import pytest
from arcade_core.catalog import ToolCatalog
from arcade_core.errors import ToolDefinitionError
from arcade_core.schema import ToolContext, ToolMetadataKey
from arcade_tdk import tool
@tool
def func_with_missing_description():
pass
@tool(desc="Returning function with declared no return type (illegal)")
def func_with_missing_return_type():
return "hello world"
@tool(desc="A function with a union return type (illegal)")
def func_with_union_return_type_1() -> Union[str, int]:
return "hello world"
@tool(desc="A function with a union return type (illegal)")
def func_with_union_return_type_2() -> str | int:
return "hello world"
@tool(desc="A function with a parameter type (illegal)")
def func_with_missing_param_type(param1):
pass
@tool(desc="A function with a parameter missing a description (illegal)")
def func_with_missing_param_description(param1: str):
pass
@tool(desc="A function with an unsupported parameter type (illegal)")
def func_with_unsupported_param(param1: complex):
pass
@tool(desc="A function with a union parameter (illegal)")
def func_with_union_param_1(param1: str | int):
pass
@tool(desc="A function with a union parameter (illegal)")
def func_with_union_param_2(param1: Union[str, int]):
pass
@tool(desc="A function with multiple context parameters (illegal)")
def func_with_multiple_context_params(context: ToolContext, context2: ToolContext):
pass
@tool(desc="A function with an invalid renamed parameter")
def func_with_invalid_renamed_param(
param1: Annotated[str, "invalid-param-name", "The first parameter"],
):
pass
@tool(
desc="A function with a required secret with a missing key (illegal)",
requires_secrets=[""],
)
def func_with_missing_secret_key(context: ToolContext):
pass
@tool(
desc="A function that requires a secret (invalid type)",
requires_secrets=[True],
)
def func_with_secret_requirement_invalid_type():
pass
@tool(
desc="A function with a required metadata with a missing key (illegal)",
requires_metadata=[""],
)
def func_with_missing_metadata_key(context: ToolContext):
pass
@tool(
desc="A function that requires metadata with an invalid type (illegal)",
requires_metadata=[True],
)
def func_with_metadata_requirement_invalid_type():
pass
@tool(
desc="A function with a required metadata key that depends on the tool having an auth requirement, but the tool does not have an auth requirement (illegal)",
requires_metadata=[ToolMetadataKey.CLIENT_ID],
)
def func_with_metadata_and_auth_dependency():
pass
@pytest.mark.parametrize(
"func_under_test, exception_type",
[
pytest.param(
func_with_missing_description,
ToolDefinitionError,
id=func_with_missing_description.__name__,
),
pytest.param(
func_with_missing_return_type,
ToolDefinitionError,
id=func_with_missing_return_type.__name__,
),
pytest.param(
func_with_missing_param_type,
ToolDefinitionError,
id=func_with_missing_param_type.__name__,
),
pytest.param(
func_with_missing_param_description,
ToolDefinitionError,
id=func_with_missing_param_description.__name__,
),
pytest.param(
func_with_unsupported_param,
ToolDefinitionError,
id=func_with_unsupported_param.__name__,
),
pytest.param(
func_with_union_param_1,
ToolDefinitionError,
id=func_with_union_param_1.__name__,
),
pytest.param(
func_with_union_param_2,
ToolDefinitionError,
id=func_with_union_param_2.__name__,
),
pytest.param(
func_with_multiple_context_params,
ToolDefinitionError,
id=func_with_multiple_context_params.__name__,
),
pytest.param(
func_with_invalid_renamed_param,
ToolDefinitionError,
id=func_with_invalid_renamed_param.__name__,
),
pytest.param(
func_with_missing_secret_key,
ToolDefinitionError,
id=func_with_missing_secret_key.__name__,
),
pytest.param(
func_with_secret_requirement_invalid_type,
ToolDefinitionError,
id=func_with_secret_requirement_invalid_type.__name__,
),
pytest.param(
func_with_missing_metadata_key,
ToolDefinitionError,
id=func_with_missing_metadata_key.__name__,
),
pytest.param(
func_with_metadata_requirement_invalid_type,
ToolDefinitionError,
id=func_with_metadata_requirement_invalid_type.__name__,
),
pytest.param(
func_with_metadata_and_auth_dependency,
ToolDefinitionError,
id=func_with_metadata_and_auth_dependency.__name__,
),
pytest.param(
func_with_union_return_type_1,
ToolDefinitionError,
id=func_with_union_return_type_1.__name__,
),
pytest.param(
func_with_union_return_type_2,
ToolDefinitionError,
id=func_with_union_return_type_2.__name__,
),
],
)
def test_missing_info_raises_error(func_under_test, exception_type):
with pytest.raises(exception_type):
ToolCatalog.create_tool_definition(func_under_test, "1.0")