arcade-mcp/toolkits/jira/arcade_jira/critics.py
Sam Partee b6b4cd0a4c
🏗️ Restructure: Multi-Package Architecture + uv Migration (#412)
### Overview
Major restructuring from monolithic `arcade-ai` package to modular
library architecture with standardized uv-based dependency management.

![arcade-ai Monorepo
(2)](https://github.com/user-attachments/assets/25f102b0-bb87-4a04-9701-d227d05664b1)

### New Package Structure
- **`arcade-tdk`** - Lightweight toolkit development kit (core
decorators, auth)
- **`arcade-core`** - Core execution engine and catalog functionality  
- **`arcade-serve`** - FastAPI/MCP server components
- **`arcade-ai`** - Meta package that includes CLI functionality.
Optionally include evals via the `evals` extra. Optionally include all
packages via the `all` extra.

### Key Benefits
- **Lighter Dependencies**: Toolkits now depend only on `arcade-tdk` (~2
deps) vs full `arcade-ai` (~30+ deps)
- **Faster Builds**: uv provides 10-100x faster dependency resolution
and installation
- **Better Modularity**: Clear separation of concerns, consumers import
only what they need
- **Standard Tooling**: Eliminates custom poetry scripts, uses standard
Python packaging

### Migration Impact
- All 20 toolkits converted from poetry → uv with `arcade-tdk`
dependencies plus `arcade-ai[evals]` and `arcade-serve` dev
dependencies. When developing locally, devs should install toolkits via
`make install-local`.
- Modern Python 3.10+ type hints throughout
- Standardized build system with hatchling backend
- Enhanced Makefile with robust toolkit management commands
- Removed `arcade dev` CLI command
- Reduce the number of files created by `arcade new` and add an option
to not generate a tests and evals folder.

This foundation enables faster development cycles and cleaner dependency
chains for the growing toolkit ecosystem.

### Todo After this PR is merged
- [ ] Post-merge workflow(s) (release & publish containers, etc)
- [ ] Release order plan. @EricGustin suggests releasing in the
following order:
    1. `arcade-core` version 0.1.0
    2. `arcade-serve` version 0.1.0 and `arcade-tdk` version 0.1.0
    3. `arcade-ai` version 2.0.0
4. Patch release for all toolkits (all changes in toolkits are internal
refactors)
- [ ] [Update docs](https://github.com/ArcadeAI/docs/pull/318)

---------

Co-authored-by: Eric Gustin <eric@arcade.dev>
Co-authored-by: Eric Gustin <34000337+EricGustin@users.noreply.github.com>
2025-06-11 16:48:17 -07:00

91 lines
3.2 KiB
Python

from dataclasses import dataclass
from typing import Any
from arcade_evals.critic import BinaryCritic
@dataclass
class HasSubstringCritic(BinaryCritic):
"""A critic for checking whether the argument value contains a substring."""
def evaluate(self, expected: Any, actual: Any) -> dict[str, float | bool]:
"""
Evaluates whether the actual value contains the expected value.
Args:
expected: The expected value.
actual: The actual value to compare, cast to the type of expected.
Returns:
dict: A dictionary containing the match status and score.
"""
if not isinstance(actual, str) or not isinstance(expected, str):
return {"match": False, "score": 0.0}
try:
actual_casted = self.cast_actual(expected, actual)
except TypeError:
actual_casted = actual
match = expected in actual_casted
return {"match": match, "score": self.weight if match else 0.0}
@dataclass
class CaseInsensitiveBinaryCritic(BinaryCritic):
"""A critic for checking whether actual and expected values are the same, case insensitive."""
def evaluate(self, expected: Any, actual: Any) -> dict[str, float | bool]:
"""
Evaluates whether the actual value is the same as the expected value, case insensitive.
Args:
expected: The expected value.
actual: The actual value to compare, cast to the type of expected.
Returns:
dict: A dictionary containing the match status and score.
"""
if not isinstance(actual, str) or not isinstance(expected, str):
return {"match": False, "score": 0.0}
try:
actual_casted = self.cast_actual(expected, actual)
except TypeError:
actual_casted = actual
match = expected.casefold() in actual_casted.casefold()
return {"match": match, "score": self.weight if match else 0.0}
@dataclass
class CaseInsensitiveListOfStringsBinaryCritic(BinaryCritic):
"""Checks that all strings match in Actual and Expected list of strings, case insensitive"""
def evaluate(self, expected: Any, actual: Any) -> dict[str, float | bool]:
"""
Checks that all strings match in Actual and Expected list of strings, case insensitive
Args:
expected: The expected value.
actual: The actual value to compare, cast to the type of expected.
Returns:
dict: A dictionary containing the match status and score.
"""
if not isinstance(actual, list) or not isinstance(expected, list):
return {"match": False, "score": 0.0}
all_actual_str = all(isinstance(item, str) for item in actual)
all_expected_str = all(isinstance(item, str) for item in expected)
if not all_actual_str or not all_expected_str:
return {"match": False, "score": 0.0}
actual_folded = [item.casefold() for item in actual]
expected_folded = [item.casefold() for item in expected]
match = len(actual) == len(expected) and all(
item in actual_folded for item in expected_folded
)
return {"match": match, "score": self.weight if match else 0.0}