arcade-mcp/toolkits/jira/tests/test_find_unique_priority.py
Sam Partee b6b4cd0a4c
🏗️ Restructure: Multi-Package Architecture + uv Migration (#412)
### Overview
Major restructuring from monolithic `arcade-ai` package to modular
library architecture with standardized uv-based dependency management.

![arcade-ai Monorepo
(2)](https://github.com/user-attachments/assets/25f102b0-bb87-4a04-9701-d227d05664b1)

### New Package Structure
- **`arcade-tdk`** - Lightweight toolkit development kit (core
decorators, auth)
- **`arcade-core`** - Core execution engine and catalog functionality  
- **`arcade-serve`** - FastAPI/MCP server components
- **`arcade-ai`** - Meta package that includes CLI functionality.
Optionally include evals via the `evals` extra. Optionally include all
packages via the `all` extra.

### Key Benefits
- **Lighter Dependencies**: Toolkits now depend only on `arcade-tdk` (~2
deps) vs full `arcade-ai` (~30+ deps)
- **Faster Builds**: uv provides 10-100x faster dependency resolution
and installation
- **Better Modularity**: Clear separation of concerns, consumers import
only what they need
- **Standard Tooling**: Eliminates custom poetry scripts, uses standard
Python packaging

### Migration Impact
- All 20 toolkits converted from poetry → uv with `arcade-tdk`
dependencies plus `arcade-ai[evals]` and `arcade-serve` dev
dependencies. When developing locally, devs should install toolkits via
`make install-local`.
- Modern Python 3.10+ type hints throughout
- Standardized build system with hatchling backend
- Enhanced Makefile with robust toolkit management commands
- Removed `arcade dev` CLI command
- Reduce the number of files created by `arcade new` and add an option
to not generate a tests and evals folder.

This foundation enables faster development cycles and cleaner dependency
chains for the growing toolkit ecosystem.

### Todo After this PR is merged
- [ ] Post-merge workflow(s) (release & publish containers, etc)
- [ ] Release order plan. @EricGustin suggests releasing in the
following order:
    1. `arcade-core` version 0.1.0
    2. `arcade-serve` version 0.1.0 and `arcade-tdk` version 0.1.0
    3. `arcade-ai` version 2.0.0
4. Patch release for all toolkits (all changes in toolkits are internal
refactors)
- [ ] [Update docs](https://github.com/ArcadeAI/docs/pull/318)

---------

Co-authored-by: Eric Gustin <eric@arcade.dev>
Co-authored-by: Eric Gustin <34000337+EricGustin@users.noreply.github.com>
2025-06-11 16:48:17 -07:00

227 lines
8 KiB
Python

from collections.abc import Callable
from unittest.mock import patch
import pytest
from arcade_tdk import ToolContext
from arcade_jira.exceptions import JiraToolExecutionError, MultipleItemsFoundError, NotFoundError
from arcade_jira.utils import clean_priority_dict, find_unique_priority
@pytest.mark.asyncio
async def test_find_unique_priority_by_id_success(
mock_context: ToolContext,
mock_httpx_client,
mock_httpx_response: Callable,
build_priority_dict: Callable,
):
sample_priority = build_priority_dict()
priority_response = mock_httpx_response(200, sample_priority)
mock_httpx_client.get.return_value = priority_response
response = await find_unique_priority(mock_context, sample_priority["id"], "123")
assert response == clean_priority_dict(sample_priority)
@pytest.mark.asyncio
@patch("arcade_jira.tools.priorities.find_priorities_by_project")
async def test_find_unique_priority_by_name_with_a_single_match(
mock_find_priorities_by_project,
mock_context: ToolContext,
mock_httpx_client,
mock_httpx_response: Callable,
build_project_dict: Callable,
build_priority_dict: Callable,
):
sample_project = build_project_dict()
sample_priority = build_priority_dict()
# It will first try to get the priority by ID
get_priority_by_id_response = mock_httpx_response(404, {})
# When it tries to get the priority by name, it will first query the project data
get_project_by_id_response = mock_httpx_response(200, sample_project)
# Then it will query the priorities available to the project
mock_find_priorities_by_project.return_value = {
"project": sample_project,
"priorities_available": [sample_priority],
}
mock_httpx_client.get.side_effect = [
get_priority_by_id_response,
get_project_by_id_response,
]
response = await find_unique_priority(
mock_context, sample_priority["name"].lower(), sample_project["id"]
)
assert response == clean_priority_dict(sample_priority)
@pytest.mark.asyncio
@patch("arcade_jira.tools.priorities.find_priorities_by_project")
async def test_find_unique_priority_by_name_when_project_does_not_exist(
mock_find_priorities_by_project,
mock_context: ToolContext,
mock_httpx_client,
mock_httpx_response: Callable,
build_project_dict: Callable,
build_priority_dict: Callable,
build_project_search_response_dict: Callable,
):
sample_project = build_project_dict()
sample_priority = build_priority_dict()
# It will first try to get the priority by ID
get_priority_by_id_response = mock_httpx_response(404, {})
# When it tries to get the project by id, we'll simulate a 404 error
get_project_by_id_response = mock_httpx_response(404, {})
# And also simulate no results found from search_projects
search_projects_response = mock_httpx_response(200, build_project_search_response_dict([]))
# We'll still simulate a find_priorities_by_project response, but this should not be called
mock_find_priorities_by_project.return_value = {
"project": sample_project,
"priorities_available": [sample_priority],
}
mock_httpx_client.get.side_effect = [
get_priority_by_id_response,
get_project_by_id_response,
search_projects_response,
]
with pytest.raises(JiraToolExecutionError) as exc:
await find_unique_priority(
mock_context, sample_priority["name"].lower(), sample_project["id"]
)
mock_find_priorities_by_project.assert_not_called()
assert f"Project not found with name/key/ID '{sample_project['id']}'" in exc.value.message
@pytest.mark.asyncio
@patch("arcade_jira.tools.priorities.find_priorities_by_project")
async def test_find_unique_priority_by_name_with_multiple_priorities_but_zero_matches(
mock_find_priorities_by_project,
mock_context: ToolContext,
mock_httpx_client,
mock_httpx_response: Callable,
build_project_dict: Callable,
build_priority_dict: Callable,
):
sample_project = build_project_dict()
sample_priority = build_priority_dict()
other_priority1 = build_priority_dict(name=sample_priority["name"] + "1")
other_priority2 = build_priority_dict(name=sample_priority["name"] + "2")
# It will first try to get the priority by ID
get_priority_by_id_response = mock_httpx_response(404, {})
# When it tries to get the priority by name, it will first query the project data
get_project_by_id_response = mock_httpx_response(200, sample_project)
# Then it will query the priorities available to the project
mock_find_priorities_by_project.return_value = {
"project": sample_project,
"priorities_available": [other_priority1, other_priority2],
}
mock_httpx_client.get.side_effect = [
get_priority_by_id_response,
get_project_by_id_response,
]
with pytest.raises(NotFoundError) as exc:
await find_unique_priority(
mock_context, sample_priority["name"].lower(), sample_project["id"]
)
assert (
f"Priority not found with ID or name '{sample_priority['name'].lower()}'"
== exc.value.message
)
@pytest.mark.asyncio
@patch("arcade_jira.tools.priorities.find_priorities_by_project")
async def test_find_unique_priority_by_name_with_multiple_priorities_but_one_match(
mock_find_priorities_by_project,
mock_context: ToolContext,
mock_httpx_client,
mock_httpx_response: Callable,
build_project_dict: Callable,
build_priority_dict: Callable,
):
sample_project = build_project_dict()
sample_priority = build_priority_dict()
other_priority1 = build_priority_dict()
other_priority2 = build_priority_dict()
# It will first try to get the priority by ID
get_priority_by_id_response = mock_httpx_response(404, {})
# When it tries to get the priority by name, it will first query the project data
get_project_by_id_response = mock_httpx_response(200, sample_project)
# Then it will query the priorities available to the project
mock_find_priorities_by_project.return_value = {
"project": sample_project,
"priorities_available": [sample_priority, other_priority1, other_priority2],
}
mock_httpx_client.get.side_effect = [
get_priority_by_id_response,
get_project_by_id_response,
]
response = await find_unique_priority(
mock_context, sample_priority["name"].lower(), sample_project["id"]
)
assert response == clean_priority_dict(sample_priority)
@pytest.mark.asyncio
@patch("arcade_jira.tools.priorities.find_priorities_by_project")
async def test_find_unique_priority_by_name_with_multiple_priorities_and_multiple_matches(
mock_find_priorities_by_project,
mock_context: ToolContext,
mock_httpx_client,
mock_httpx_response: Callable,
build_project_dict: Callable,
build_priority_dict: Callable,
):
sample_project = build_project_dict()
sample_priority = build_priority_dict()
other_priority1 = build_priority_dict(name=sample_priority["name"])
other_priority2 = build_priority_dict()
# It will first try to get the priority by ID
get_priority_by_id_response = mock_httpx_response(404, {})
# When it tries to get the priority by name, it will first query the project data
get_project_by_id_response = mock_httpx_response(200, sample_project)
# Then it will query the priorities available to the project
mock_find_priorities_by_project.return_value = {
"project": sample_project,
"priorities_available": [sample_priority, other_priority1, other_priority2],
}
mock_httpx_client.get.side_effect = [
get_priority_by_id_response,
get_project_by_id_response,
]
with pytest.raises(MultipleItemsFoundError) as exc:
await find_unique_priority(
mock_context, sample_priority["name"].lower(), sample_project["id"]
)
assert sample_priority["id"] in exc.value.message
assert other_priority1["id"] in exc.value.message
assert other_priority2["id"] not in exc.value.message