b6b4cd0a4c
### Overview Major restructuring from monolithic `arcade-ai` package to modular library architecture with standardized uv-based dependency management.  ### New Package Structure - **`arcade-tdk`** - Lightweight toolkit development kit (core decorators, auth) - **`arcade-core`** - Core execution engine and catalog functionality - **`arcade-serve`** - FastAPI/MCP server components - **`arcade-ai`** - Meta package that includes CLI functionality. Optionally include evals via the `evals` extra. Optionally include all packages via the `all` extra. ### Key Benefits - **Lighter Dependencies**: Toolkits now depend only on `arcade-tdk` (~2 deps) vs full `arcade-ai` (~30+ deps) - **Faster Builds**: uv provides 10-100x faster dependency resolution and installation - **Better Modularity**: Clear separation of concerns, consumers import only what they need - **Standard Tooling**: Eliminates custom poetry scripts, uses standard Python packaging ### Migration Impact - All 20 toolkits converted from poetry → uv with `arcade-tdk` dependencies plus `arcade-ai[evals]` and `arcade-serve` dev dependencies. When developing locally, devs should install toolkits via `make install-local`. - Modern Python 3.10+ type hints throughout - Standardized build system with hatchling backend - Enhanced Makefile with robust toolkit management commands - Removed `arcade dev` CLI command - Reduce the number of files created by `arcade new` and add an option to not generate a tests and evals folder. This foundation enables faster development cycles and cleaner dependency chains for the growing toolkit ecosystem. ### Todo After this PR is merged - [ ] Post-merge workflow(s) (release & publish containers, etc) - [ ] Release order plan. @EricGustin suggests releasing in the following order: 1. `arcade-core` version 0.1.0 2. `arcade-serve` version 0.1.0 and `arcade-tdk` version 0.1.0 3. `arcade-ai` version 2.0.0 4. Patch release for all toolkits (all changes in toolkits are internal refactors) - [ ] [Update docs](https://github.com/ArcadeAI/docs/pull/318) --------- Co-authored-by: Eric Gustin <eric@arcade.dev> Co-authored-by: Eric Gustin <34000337+EricGustin@users.noreply.github.com>
110 lines
3.4 KiB
Python
110 lines
3.4 KiB
Python
from unittest.mock import AsyncMock, patch
|
|
|
|
import pytest
|
|
from arcade_tdk.errors import ToolExecutionError
|
|
from httpx import Response
|
|
|
|
from arcade_github.tools.issues import create_issue, create_issue_comment
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_context():
|
|
context = AsyncMock()
|
|
context.authorization.token = "mock_token" # noqa: S105
|
|
return context
|
|
|
|
|
|
@pytest.fixture
|
|
def mock_client():
|
|
with patch("arcade_github.tools.issues.httpx.AsyncClient") as client:
|
|
yield client.return_value.__aenter__.return_value
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
@pytest.mark.parametrize(
|
|
"status_code,error_message,expected_error,func,args",
|
|
[
|
|
(
|
|
422,
|
|
"Validation Failed",
|
|
"Error accessing.*: Validation failed",
|
|
create_issue,
|
|
("owner", "repo", "title"),
|
|
),
|
|
(
|
|
401,
|
|
"Unauthorized",
|
|
"Error accessing.*: Failed to process request",
|
|
create_issue_comment,
|
|
("owner", "repo", 1, "body"),
|
|
),
|
|
(
|
|
403,
|
|
"API rate limit exceeded",
|
|
"Error accessing.*: Forbidden",
|
|
create_issue_comment,
|
|
("owner", "repo", 1, "body"),
|
|
),
|
|
(
|
|
401,
|
|
"Bad credentials",
|
|
"Error accessing.*: Failed to process request",
|
|
create_issue,
|
|
("owner", "repo", "title"),
|
|
),
|
|
],
|
|
)
|
|
async def test_issue_errors(
|
|
mock_context, mock_client, status_code, error_message, expected_error, func, args
|
|
):
|
|
mock_client.post.return_value = Response(status_code, json={"message": error_message})
|
|
|
|
with pytest.raises(ToolExecutionError, match=expected_error):
|
|
await func(mock_context, *args)
|
|
|
|
|
|
@pytest.mark.asyncio
|
|
@pytest.mark.parametrize(
|
|
"func,args,response_json,expected_assertions",
|
|
[
|
|
(
|
|
create_issue,
|
|
("owner", "repo", "Test Issue", "This is a test issue"),
|
|
{
|
|
"id": 1,
|
|
"url": "https://api.github.com/repos/owner/repo/issues/1",
|
|
"title": "Test Issue",
|
|
"body": "This is a test issue",
|
|
"state": "open",
|
|
"html_url": "https://github.com/owner/repo/issues/1",
|
|
"created_at": "2023-05-01T12:00:00Z",
|
|
"updated_at": "2023-05-01T12:00:00Z",
|
|
"user": {"login": "testuser"},
|
|
"assignees": [],
|
|
"labels": [],
|
|
},
|
|
["Test Issue", "https://github.com/owner/repo/issues/1"],
|
|
),
|
|
(
|
|
create_issue_comment,
|
|
("owner", "repo", 1, "This is a test comment"),
|
|
{
|
|
"id": 1,
|
|
"url": "https://api.github.com/repos/owner/repo/issues/comments/1",
|
|
"body": "This is a test comment",
|
|
"user": {"login": "testuser"},
|
|
"created_at": "2023-05-01T12:00:00Z",
|
|
"updated_at": "2023-05-01T12:00:00Z",
|
|
},
|
|
["This is a test comment", "https://api.github.com/repos/owner/repo/issues/comments/1"],
|
|
),
|
|
],
|
|
)
|
|
async def test_issue_success(
|
|
mock_context, mock_client, func, args, response_json, expected_assertions
|
|
):
|
|
mock_client.post.return_value = Response(201, json=response_json)
|
|
|
|
result = await func(mock_context, *args)
|
|
for assertion in expected_assertions:
|
|
assert assertion in result
|