arcade-mcp/libs/tests/core
Francisco Or Something dc4607daa4
feat(telemetry): add developer messages to tool error spans (#831)
## Summary
- Add shared span attributes for tool error diagnostics, including
developer-facing messages when present.
- Wire those attributes through MCP server, worker RunTool, and HTTP
CallTool spans while keeping default MCP response content public-only.
- Cover no-leak response behavior, non-recording spans, outputless
worker responses, and the shared attribute contract.

## Verification
- `uv run ruff format ...`
- `uv run ruff check ...`
- `uv run pytest -W ignore
libs/tests/arcade_mcp_server/test_debug_exposure_integration.py
libs/tests/core/test_log_extras.py
libs/tests/worker/test_worker_base.py`

Made with [Cursor](https://cursor.com)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Adds new telemetry attributes that propagate tool error messages
(including optional developer_message) into active spans across MCP
server and worker execution paths; risk is mainly around potential
leakage of sensitive developer messages into tracing backends and
changes to observability contracts.
> 
> **Overview**
> Adds a shared
`arcade_core.log_extras.build_tool_error_span_attributes()` helper and
wires it into tool error paths so the current OpenTelemetry span is
annotated with stable `tool_error_*` attributes (including
`developer_message` when present).
> 
> MCP tool calls now record these span attributes on failure while
keeping default MCP response content sanitized, and `arcade-serve`
records the same attributes on both `RunTool` and HTTP `CallTool` spans
(handling `output=None`). Versions and dependency constraints are bumped
to consume the new core helper, with tests added/updated to lock the
span-attribute contract and verify behavior for non-recording spans and
no-leak responses.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
33a53991d72140a662152f508dc53e9b769b9f07. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
2026-04-29 20:41:07 -03:00
..
converters Adding MCP Servers supports to Arcade Evals (#689) 2026-01-07 20:26:23 -03:00
usage [TOO-326] Windows papercuts (#768) 2026-02-25 13:18:16 -03:00
utils Fix MCP capabilities, examples, tests, and more (#657) 2025-10-30 11:59:00 -07:00
test_catalog.py Rename some 'toolkit' references to 'server' (#624) 2025-10-14 18:42:27 -07:00
test_converter_utils.py Adding MCP Servers supports to Arcade Evals (#689) 2026-01-07 20:26:23 -03:00
test_dependency_alignment.py [TOO-326] Windows papercuts (#768) 2026-02-25 13:18:16 -03:00
test_discovery.py MCP Local (#563) 2025-09-25 15:28:15 -07:00
test_errors.py feat: add NetworkTransportError for no-response HTTP failures (#823) 2026-04-16 18:29:13 -03:00
test_executor.py TOO-627: Improve error messages for agents and Datadog (#814) 2026-04-13 20:10:51 -03:00
test_log_extras.py feat(telemetry): add developer messages to tool error spans (#831) 2026-04-29 20:41:07 -03:00
test_output.py TOO-627: Improve error messages for agents and Datadog (#814) 2026-04-13 20:10:51 -03:00
test_parse.py 🏗️ Restructure: Multi-Package Architecture + uv Migration (#412) 2025-06-11 16:48:17 -07:00
test_schema.py MCP Local (#563) 2025-09-25 15:28:15 -07:00
test_schema_mcp_degradation.py Adding MCP Servers supports to Arcade Evals (#689) 2026-01-07 20:26:23 -03:00
test_schema_validation.py Tool Error Handling (#539) 2025-09-10 10:45:18 -07:00
test_subprocess_utils.py [TOO-326] Windows papercuts (#768) 2026-02-25 13:18:16 -03:00
test_toolkit.py [TOO-326] Windows papercuts (#768) 2026-02-25 13:18:16 -03:00
test_typeddict_output_execution.py fix: TypedDict total=False output breaks validation (#816) 2026-04-09 17:47:57 -07:00