# Improvements to Arcade TDK Error Handling
I tried my very best to not make any breaking changes in this PR. So,
you will notice various "Deprecation" notices throughout.
### Instructions for PR reviewers
1. Pull down this PR's branch
2. Pull down the Engine's tool error handling PR's branch
3. Update your installed arcadepy to have the following:
- In `arcadepy/resources/tools/tools.py`, if you want to test out
including stacktraces, then you need to update `ToolsResource.execute`
to accept a `include_error_stacktrace` argument and also include the
"include_error_stacktrace" argument to the POST to the Engine inside of
the function's execute method's body.
- In `arcadepy/types/execute_tool_response.py` add the following enum
```py
class ErrorKind(str, Enum):
"""Error kind that is comprised of
- the who (toolkit, tool, upstream)
- the when (load time, definition parsing time, runtime)
- the what (bad_definition, bad_input, bad_output, retry,
context_required, fatal, etc.)"""
TOOLKIT_LOAD_FAILED = "TOOLKIT_LOAD_FAILED"
TOOL_DEFINITION_BAD_DEFINITION = "TOOL_DEFINITION_BAD_DEFINITION"
TOOL_DEFINITION_BAD_INPUT_SCHEMA = "TOOL_DEFINITION_BAD_INPUT_SCHEMA"
TOOL_DEFINITION_BAD_OUTPUT_SCHEMA = "TOOL_DEFINITION_BAD_OUTPUT_SCHEMA"
TOOL_RUNTIME_BAD_INPUT_VALUE = "TOOL_RUNTIME_BAD_INPUT_VALUE"
TOOL_RUNTIME_BAD_OUTPUT_VALUE = "TOOL_RUNTIME_BAD_OUTPUT_VALUE"
TOOL_RUNTIME_RETRY = "TOOL_RUNTIME_RETRY"
TOOL_RUNTIME_CONTEXT_REQUIRED = "TOOL_RUNTIME_CONTEXT_REQUIRED"
TOOL_RUNTIME_FATAL = "TOOL_RUNTIME_FATAL"
UPSTREAM_RUNTIME_BAD_REQUEST = "UPSTREAM_RUNTIME_BAD_REQUEST"
UPSTREAM_RUNTIME_AUTH_ERROR = "UPSTREAM_RUNTIME_AUTH_ERROR"
UPSTREAM_RUNTIME_NOT_FOUND = "UPSTREAM_RUNTIME_NOT_FOUND"
UPSTREAM_RUNTIME_VALIDATION_ERROR = "UPSTREAM_RUNTIME_VALIDATION_ERROR"
UPSTREAM_RUNTIME_RATE_LIMIT = "UPSTREAM_RUNTIME_RATE_LIMIT"
UPSTREAM_RUNTIME_SERVER_ERROR = "UPSTREAM_RUNTIME_SERVER_ERROR"
UPSTREAM_RUNTIME_UNMAPPED = "UPSTREAM_RUNTIME_UNMAPPED"
UNKNOWN = "UNKNOWN"
```
- In `arcadepy/types/execute_tool_response.py` add the following fields
to OutputError:
```py
kind: ErrorKind
status_code: Optional[int] = None
stacktrace: Optional[str] = None
extra: Optional[dict[str, Any]] = None
```
### Example Client Usage
```py
# Example of handling an upstream rate limit
error = response.output.error
if error and error.kind == ErrorKind.UPSTREAM_RUNTIME_RATE_LIMIT:
sleep_time = error.retry_after_ms / 1000
time.sleep(sleep_time)
# and then execute again
```
```py
# Examples of determining what type of runtime error it is
error = response.output.error
if error:
is_retryable_error = error.kind == ErrorKind.TOOL_RUNTIME_RETRY
is_a_bug_in_the_tool = error.kind == ErrorKind.TOOL_RUNTIME_FATAL
is_additional_context_required = error.kind == ErrorKind.TOOL_RUNTIME_CONTEXT_REQUIRED
```
### Example Tool Usage
```py
# EXAMPLE 1 letting Arcade handle upstream error handling for you
reddit_client.post(params) # Arcade's httpx adapter will handle error handling for you!
# ------------------------------------
# EXAMPLE 2 handling upstream bad request yourself, but letting Arcade handle the rest
try:
reddit_client.post(params)
except httpx.HTTPStatusError as e:
if e.status_code == 400:
raise UpstreamError("My extra custom message) from e
raise
```
```py
# EXAMPLE 1 letting Arcade handle it for you
risky_element = my_risky_list[42] # Arcade will raise a FatalToolError for you
# ------------------------------------
# EXAMPLE 2 handling it yourself for extra flexibility
try:
risky_element = my_risky_list[42]
except IndexError as e:
raise FatalToolError("My extra custom message") from e
```
### Non-runtime Error Message Examples
Example ToolkitLoadError Messages:
```
- [TOOLKIT_LOAD_FAILED] ToolkitLoadError when loading toolkit 'sample_tool': Could not import module mock_module. Reason: Mock import error
- [TOOLKIT_LOAD_FAILED] ToolkitLoadError when loading toolkit 'test_toolkit': Tool 'ValidTool' in toolkit 'test_toolkit' already exists in the catalog.
```
Example ToolDefinitionError Messages
```
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_missing_description': Tool 'tool_missing_description' is missing a description
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_with_invalid_secret_type': Secret keys must be strings (error in tool ToolWithInvalidSecretType).
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_with_empty_secret': Secrets must have a non-empty key (error in tool ToolWithEmptySecret).
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_with_invalid_metadata_type': Metadata must be strings (error in tool ToolWithInvalidMetadataType).
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_with_metadata_requiring_auth_without_auth': Tool ToolWithMetadataRequiringAuthWithoutAuth declares metadata key 'client_id', which requires that the tool has an auth requirement, but no auth requirement was provided. Please specify an auth requirement.
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_with_empty_metadata': Metadata must have a non-empty key (error in tool ToolWithEmptyMetadata).
- [TOOL_DEFINITION_BAD_DEFINITION] ToolDefinitionError in definition of tool 'tool_with_unsupported_param_type': Unsupported parameter type: <class 'test_catalog.MyFancyTestClass'>
```
Example ToolInputSchemaError Messages
```
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_missing_input_parameter_annotation': Parameter 'input_text' is missing a description
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_no_type_annotation': Parameter param has no type annotation.
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_invalid_param_name': Invalid parameter name: '123invalid' is not a valid identifier. Identifiers must start with a letter or underscore, and can only contain letters, digits, or underscores.
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_too_many_annotations': Parameter param: Annotated[str, 'name', 'desc', 'extra'] has too many string annotations. Expected 0, 1, or 2, got 3.
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_required_union_param': Parameter param is a union type. Only optional types are supported.
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_non_callable_default_factory': Default factory for parameter param: Annotated[str, 'Parameter'] = FieldInfo(annotation=NoneType, required=False, default_factory=str) is not callable.
- [TOOL_DEFINITION_BAD_INPUT_SCHEMA] ToolInputSchemaError in definition of tool 'tool_with_multiple_tool_contexts': Only one ToolContext parameter is supported, but tool tool_with_multiple_tool_contexts has multiple.
```
Example ToolOutputSchemaError Messages
```
- [TOOL_DEFINITION_BAD_OUTPUT_SCHEMA] ToolOutputSchemaError in definition of tool 'tool_missing_return_type_hint': Tool 'ToolMissingReturnTypeHint' must have a return type
- [TOOL_DEFINITION_BAD_OUTPUT_SCHEMA] ToolOutputSchemaError in definition of tool 'tool_with_unsupported_output_type': Unsupported output type '<class 'test_catalog.MyFancyTestClass'>'. Only built-in Python types, TypedDicts, Pydantic models, and standard collections are supported as tool output types.
```
### Runtime Error Message Examples
Example Tool Runtime Error Messages
```
- [TOOL_RUNTIME_FATAL] FatalToolError during execution of tool 'get_posts_in_subreddit': list index out of range
- [TOOL_RUNTIME_CONTEXT_REQUIRED] ContextRequiredToolError during execution of tool 'get_posts_in_subreddit': Ambiguous username. Please provide a more specific username
- [TOOL_RUNTIME_RETRY] RetryableToolError during execution of tool 'get_posts_in_subreddit': Retry with subreddit=learnpython or subreddit=learnprogramming
```
Example Upstream Runtime Error Messages
```
- [UPSTREAM_RUNTIME_RATE_LIMIT] UpstreamRateLimitError during execution of tool 'get_posts_in_subreddit': 429 Client Error: Too Many Requests
- [UPSTREAM_RUNTIME_BAD_REQUEST] UpstreamError during execution of tool 'get_posts_in_subreddit': 400 Client Error: Bad request. Missing 'id' parameter.
- [UPSTREAM_RUNTIME_BAD_REQUEST] UpstreamError during execution of tool 'search_files': Upstream Google API error: Invalid value '-23'. Values must be within the range: [value: 1\n, value: 1000\n]
```
154 lines
5.3 KiB
Python
154 lines
5.3 KiB
Python
import functools
|
|
import inspect
|
|
from typing import Any, Callable, TypeVar
|
|
|
|
from arcade_tdk.auth import ToolAuthorization
|
|
from arcade_tdk.error_adapters import ErrorAdapter
|
|
from arcade_tdk.error_adapters.utils import get_adapter_for_auth_provider
|
|
from arcade_tdk.errors import (
|
|
FatalToolError,
|
|
ToolRuntimeError,
|
|
)
|
|
from arcade_tdk.providers.http import HTTPErrorAdapter
|
|
from arcade_tdk.utils import snake_to_pascal_case
|
|
|
|
T = TypeVar("T")
|
|
|
|
|
|
def _build_adapter_chain(
|
|
adapters: list[ErrorAdapter] | None, auth_provider: ToolAuthorization | None
|
|
) -> list[ErrorAdapter]:
|
|
"""
|
|
Build the adapter chain for error handling.
|
|
|
|
Args:
|
|
adapters: User-provided list of error adapters
|
|
auth_provider: The auth provider for the tool
|
|
|
|
Returns:
|
|
A deduplicated list of error adapters with the HTTP adapter as fallback
|
|
|
|
Raises:
|
|
ValueError: If any adapter doesn't follow the ErrorAdapter protocol
|
|
"""
|
|
adapter_chain = adapters or []
|
|
|
|
# Validate that all adapters follow the ErrorAdapter protocol
|
|
if not all(isinstance(adapter, ErrorAdapter) for adapter in adapter_chain):
|
|
invalid_adapters = [
|
|
type(adapter).__name__
|
|
for adapter in adapter_chain
|
|
if not isinstance(adapter, ErrorAdapter)
|
|
]
|
|
raise ValueError(
|
|
f"All adapters must follow the ErrorAdapter protocol. "
|
|
f"Invalid adapters: {', '.join(invalid_adapters)}"
|
|
)
|
|
|
|
# Add the adapter that is mapped to the tool's auth provider if it exists
|
|
if auth_adapter := get_adapter_for_auth_provider(auth_provider):
|
|
adapter_chain.append(auth_adapter)
|
|
|
|
# Always add HTTP adapter as the final adapter fallback
|
|
adapter_chain.append(HTTPErrorAdapter())
|
|
|
|
# Remove duplicates from the adapter chain, preserving order
|
|
seen_types = set()
|
|
deduplicated_chain = []
|
|
for adapter in adapter_chain:
|
|
adapter_type = type(adapter)
|
|
if adapter_type not in seen_types:
|
|
seen_types.add(adapter_type)
|
|
deduplicated_chain.append(adapter)
|
|
|
|
return deduplicated_chain
|
|
|
|
|
|
def _raise_as_arcade_error(
|
|
exception: Exception, adapter_chain: list[ErrorAdapter], tool_name: str, func_name: str
|
|
) -> None:
|
|
"""
|
|
Try to translate an exception using the adapter chain, then raise the translated error.
|
|
If no adapter can translate the exception, a FatalToolError is raised.
|
|
|
|
Args:
|
|
exception: The exception to translate to an Arcade Error
|
|
adapter_chain: List of error adapters to try
|
|
tool_name: The tool's display name for error messages
|
|
func_name: The function name for developer messages
|
|
|
|
Raises:
|
|
ToolRuntimeError or some subclass thereof
|
|
"""
|
|
for adapter in adapter_chain:
|
|
mapped = adapter.from_exception(exception)
|
|
if isinstance(mapped, ToolRuntimeError):
|
|
raise mapped from exception
|
|
|
|
raise FatalToolError(
|
|
message=f"{exception!s}",
|
|
developer_message=f"{exception!s}",
|
|
) from exception
|
|
|
|
|
|
def tool(
|
|
func: Callable | None = None,
|
|
desc: str | None = None,
|
|
name: str | None = None,
|
|
requires_auth: ToolAuthorization | None = None,
|
|
requires_secrets: list[str] | None = None,
|
|
requires_metadata: list[str] | None = None,
|
|
adapters: list[ErrorAdapter] | None = None,
|
|
) -> Callable:
|
|
def decorator(func: Callable) -> Callable:
|
|
func_name = str(getattr(func, "__name__", None))
|
|
tool_name = name or snake_to_pascal_case(func_name)
|
|
|
|
func.__tool_name__ = tool_name # type: ignore[attr-defined]
|
|
func.__tool_description__ = desc or inspect.cleandoc(func.__doc__ or "") # type: ignore[attr-defined]
|
|
func.__tool_requires_auth__ = requires_auth # type: ignore[attr-defined]
|
|
func.__tool_requires_secrets__ = requires_secrets # type: ignore[attr-defined]
|
|
func.__tool_requires_metadata__ = requires_metadata # type: ignore[attr-defined]
|
|
|
|
adapter_chain = _build_adapter_chain(adapters, requires_auth)
|
|
|
|
if inspect.iscoroutinefunction(func):
|
|
|
|
@functools.wraps(func)
|
|
async def func_with_error_handling(*args: Any, **kwargs: Any) -> Any:
|
|
try:
|
|
return await func(*args, **kwargs)
|
|
except ToolRuntimeError:
|
|
# re-raise as-is if it is already an Arcade Error
|
|
raise
|
|
except Exception as e:
|
|
_raise_as_arcade_error(e, adapter_chain, tool_name, func_name)
|
|
|
|
else:
|
|
|
|
@functools.wraps(func)
|
|
def func_with_error_handling(*args: Any, **kwargs: Any) -> Any:
|
|
try:
|
|
return func(*args, **kwargs)
|
|
except ToolRuntimeError:
|
|
# re-raise as-is if it is already an Arcade Error
|
|
raise
|
|
except Exception as e:
|
|
_raise_as_arcade_error(e, adapter_chain, tool_name, func_name)
|
|
|
|
return func_with_error_handling
|
|
|
|
if func:
|
|
return decorator(func)
|
|
return decorator
|
|
|
|
|
|
def _tool_deprecated(message: str) -> Callable:
|
|
def decorator(func: Callable) -> Callable:
|
|
func.__tool_deprecation_message__ = message # type: ignore[attr-defined]
|
|
return func
|
|
|
|
return decorator
|
|
|
|
|
|
tool.deprecated = _tool_deprecated # type: ignore[attr-defined]
|