<!-- CURSOR_SUMMARY --> > [!NOTE] > **Medium Risk** > Touches authentication/login flow, credentials-file permissions, and subprocess lifecycle behavior across platforms; while mostly defensive, regressions could impact login or process management on Windows/macOS runners. > > **Overview** > Improves Windows/cross-platform reliability across the CLI and MCP server: OAuth login now binds the callback server to `127.0.0.1`, avoids slow loopback reverse-DNS, adds a configurable callback timeout (`--timeout` + env default), and opens URLs via a Windows-friendly `_open_browser` to avoid flashing console windows. > > Centralizes CLI output via a shared `console` that forces UTF-8 on Windows, standardizes UTF-8 file reads/writes throughout, tightens credentials-file permissions on Windows using `icacls`, and adds shared Windows subprocess helpers for **no-window** process creation and graceful termination (used by `deploy`, MCP reload, and usage-tracking worker). > > Updates client configuration UX/robustness (Windows AppData resolution via `platformdirs`, Cursor config path fallbacks + compatibility writes, overwrite warnings, absolute `uv` path for GUI clients, safer path display) and improves `deploy` child-process handling to avoid pipe-buffer deadlocks while giving better debug-aware error messages. > > Expands CI to run tests on Linux/Windows/macOS, adds a no-auth CLI integration workflow, disables usage tracking in toolkits CI, and adds extensive regression tests for Windows signals, subprocess cleanup, UTF-8, and config-path edge cases; bumps `arcade-core` to `4.4.2` and `arcade-mcp-server` to `1.17.2` (with updated dependency pin). > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 0fabd8ca1cd647039ba6ddbdf3f7809c330bab9e. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
132 lines
5 KiB
YAML
132 lines
5 KiB
YAML
name: Test Toolkits
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- main
|
|
pull_request:
|
|
types: [opened, synchronize, reopened, ready_for_review]
|
|
|
|
env:
|
|
ARCADE_USAGE_TRACKING: "0"
|
|
|
|
jobs:
|
|
setup:
|
|
runs-on: ubuntu-latest
|
|
outputs:
|
|
toolkits_with_gha_secrets: ${{ steps.load_toolkits.outputs.toolkits_with_gha_secrets }}
|
|
toolkits_without_gha_secrets: ${{ steps.load_toolkits.outputs.toolkits_without_gha_secrets }}
|
|
steps:
|
|
- name: Check out
|
|
uses: actions/checkout@v4
|
|
|
|
- name: determine toolkits with and without GHA secrets
|
|
id: load_toolkits
|
|
run: |
|
|
# Find all directories in toolkits/ that have a pyproject.toml
|
|
TOOLKITS=$(find toolkits -maxdepth 1 -type d -not -name "toolkits" -exec test -f {}/pyproject.toml \; -exec basename {} \; | jq -R -s -c 'split("\n")[:-1]')
|
|
TOOLKITS_WITH_GHA_SECRETS='["postgres", "clickhouse", "mongodb"]'
|
|
TOOLKITS_WITHOUT_GHA_SECRETS=$(echo "$TOOLKITS" | jq -c --argjson with "$TOOLKITS_WITH_GHA_SECRETS" '[.[] | select(. as $t | $with | index($t) | not)]')
|
|
echo "Found toolkits: $TOOLKITS"
|
|
echo "Found toolkits without GHA secrets: $TOOLKITS_WITHOUT_GHA_SECRETS"
|
|
echo "Found toolkits with GHA secrets: $TOOLKITS_WITH_GHA_SECRETS"
|
|
echo "toolkits_without_gha_secrets=$TOOLKITS_WITHOUT_GHA_SECRETS" >> $GITHUB_OUTPUT
|
|
echo "toolkits_with_gha_secrets=$TOOLKITS_WITH_GHA_SECRETS" >> $GITHUB_OUTPUT
|
|
|
|
test-toolkits:
|
|
needs: setup
|
|
name: test-toolkits (${{ matrix.toolkit }}, ${{ matrix.os }})
|
|
runs-on: ${{ matrix.os }}
|
|
strategy:
|
|
matrix:
|
|
os: [ubuntu-latest, windows-latest, macos-latest]
|
|
toolkit: ${{ fromJson(needs.setup.outputs.toolkits_without_gha_secrets) }}
|
|
fail-fast: false
|
|
steps:
|
|
- name: Check out
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Set up the environment
|
|
uses: ./.github/actions/setup-uv-env
|
|
with:
|
|
is-toolkit: "true"
|
|
working-directory: toolkits/${{ matrix.toolkit }}
|
|
|
|
- name: Install toolkit dependencies
|
|
working-directory: toolkits/${{ matrix.toolkit }}
|
|
shell: bash
|
|
run: uv pip install -e ".[dev]"
|
|
|
|
- name: Check toolkit
|
|
working-directory: toolkits/${{ matrix.toolkit }}
|
|
shell: bash
|
|
run: |
|
|
uv run --active pre-commit run -a
|
|
uv run --active mypy --config-file=pyproject.toml
|
|
|
|
- name: Test stand-alone toolkits (no secrets)
|
|
working-directory: toolkits/${{ matrix.toolkit }}
|
|
shell: bash
|
|
run: |
|
|
# Run pytest and capture exit code
|
|
uv run --active pytest -W ignore -v --cov=arcade_${{ matrix.toolkit }} --cov-report=xml || EXIT_CODE=$?
|
|
|
|
if [ "${EXIT_CODE:-0}" -eq 5 ]; then
|
|
echo "No tests found for toolkit ${{ matrix.toolkit }}, skipping..."
|
|
exit 0
|
|
elif [ "${EXIT_CODE:-0}" -ne 0 ]; then
|
|
exit ${EXIT_CODE}
|
|
fi
|
|
|
|
test-toolkits-with-gha-secrets:
|
|
needs: setup
|
|
# Linux-only: these toolkits bootstrap local DBs via docker/apt in tests/test_setup.sh.
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
matrix:
|
|
toolkit: ${{ fromJson(needs.setup.outputs.toolkits_with_gha_secrets) }}
|
|
fail-fast: true
|
|
steps:
|
|
- name: Check out
|
|
uses: actions/checkout@v4
|
|
|
|
- name: Set up the environment
|
|
uses: ./.github/actions/setup-uv-env
|
|
with:
|
|
is-toolkit: "true"
|
|
working-directory: toolkits/${{ matrix.toolkit }}
|
|
|
|
- name: Install toolkit dependencies
|
|
working-directory: toolkits/${{ matrix.toolkit }}
|
|
run: uv pip install -e ".[dev]"
|
|
|
|
- name: Check toolkit
|
|
working-directory: toolkits/${{ matrix.toolkit }}
|
|
run: |
|
|
uv run --active pre-commit run -a
|
|
uv run --active mypy --config-file=pyproject.toml
|
|
|
|
- name: Test stand-alone toolkits (with secrets)
|
|
if: |
|
|
!github.event.pull_request.head.repo.fork
|
|
working-directory: toolkits/${{ matrix.toolkit }}
|
|
env:
|
|
TEST_POSTGRES_DATABASE_CONNECTION_STRING: ${{ secrets.TEST_POSTGRES_DATABASE_CONNECTION_STRING }} # TODO: dynamically only load the `TEST_${{ matrix.toolkit }}_DATABASE_CONNECTION_STRING secret`
|
|
TEST_CLICKHOUSE_DATABASE_CONNECTION_STRING: ${{ secrets.TEST_CLICKHOUSE_DATABASE_CONNECTION_STRING }}
|
|
TEST_MONGODB_CONNECTION_STRING: ${{ secrets.TEST_MONGODB_CONNECTION_STRING }}
|
|
run: |
|
|
# If there's a custom test_setup.sh file, run it
|
|
if [ -f tests/test_setup.sh ]; then
|
|
echo "Running custom test setup for ${{ matrix.toolkit }}..."
|
|
./tests/test_setup.sh
|
|
fi
|
|
|
|
# Run pytest and capture exit code
|
|
uv run --active pytest -W ignore -v --cov=arcade_${{ matrix.toolkit }} --cov-report=xml || EXIT_CODE=$?
|
|
|
|
if [ "${EXIT_CODE:-0}" -eq 5 ]; then
|
|
echo "No tests found for toolkit ${{ matrix.toolkit }}, skipping..."
|
|
exit 0
|
|
elif [ "${EXIT_CODE:-0}" -ne 0 ]; then
|
|
exit ${EXIT_CODE}
|
|
fi
|