admin-valentin/ceo-api
1
0
Fork 0
Code Issues Pull requests Projects Releases 2 Packages Wiki Activity Actions

fix(decisions): wrap mutations in db.transaction() for audit atomicity

Browse source
This commit is contained in:
admin-valentin 2026-07-31 10:48:37 +00:00
parent 880c2a7018
commit 3b1b14e380
1 changed files with 41 additions and 37 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
src/decisions/decisions.service.ts
View file

@ -26,7 +26,8 @@ export class DecisionsService {
} }
async create(session: AuthenticatedSession, dto: CreateDecisionDto) { async create(session: AuthenticatedSession, dto: CreateDecisionDto) {
const [row] = await db return db.transaction(async (tx) => {
const [row] = await tx
.insert(decisions) .insert(decisions)
.values({ .values({
tenantId: session.tenantId, tenantId: session.tenantId,
@ -38,18 +39,20 @@ export class DecisionsService {
reviewDueAt: dto.reviewDueAt ? new Date(dto.reviewDueAt) : undefined, reviewDueAt: dto.reviewDueAt ? new Date(dto.reviewDueAt) : undefined,
}) })
.returning(); .returning();
await this.audit.record(null, { await this.audit.record(tx, {
tenantId: session.tenantId, tenantId: session.tenantId,
actorId: session.userId, actorId: session.userId,
action: 'decision.created', action: 'decision.created',
resource: `decision:${row.id}`, resource: `decision:${row.id}`,
}); });
return row; return row;
});
} }
async update(session: AuthenticatedSession, id: string, dto: UpdateDecisionDto) { async update(session: AuthenticatedSession, id: string, dto: UpdateDecisionDto) {
await this.getById(session, id); await this.getById(session, id);
const [row] = await db return db.transaction(async (tx) => {
const [row] = await tx
.update(decisions) .update(decisions)
.set({ .set({
...(dto.context !== undefined ? { context: dto.context } : {}), ...(dto.context !== undefined ? { context: dto.context } : {}),
@ -63,12 +66,13 @@ export class DecisionsService {
}) })
.where(and(eq(decisions.id, id), eq(decisions.tenantId, session.tenantId))) .where(and(eq(decisions.id, id), eq(decisions.tenantId, session.tenantId)))
.returning(); .returning();
await this.audit.record(null, { await this.audit.record(tx, {
tenantId: session.tenantId, tenantId: session.tenantId,
actorId: session.userId, actorId: session.userId,
action: dto.selectedOption !== undefined ? 'decision.option_selected' : 'decision.updated', action: dto.selectedOption !== undefined ? 'decision.option_selected' : 'decision.updated',
resource: `decision:${id}`, resource: `decision:${id}`,
}); });
return row; return row;
});
} }
} }