admin-valentin/open-notebook
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(ui): optimize MutationObserver in NoteEditorDialog

Browse source 
Only observe DOM mutations when dialog is open, preventing
unnecessary observer activity when the dialog is closed.

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
LUIS NOVO 2025-12-20 10:13:49 -03:00
parent a8bb88e10f
commit 2a4d98772b
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
frontend/src/app/(dashboard)/notebooks/components/NoteEditorDialog.tsx
View file

@ -70,12 +70,14 @@ export function NoteEditorDialog({ open, onOpenChange, notebookId, note }: NoteE
}, [open, note, fetchedNote, reset]) }, [open, note, fetchedNote, reset])
useEffect(() => { useEffect(() => {
if (!open) return
const observer = new MutationObserver(() => { const observer = new MutationObserver(() => {
setIsEditorFullscreen(!!document.querySelector('.w-md-editor-fullscreen')) setIsEditorFullscreen(!!document.querySelector('.w-md-editor-fullscreen'))
}) })
observer.observe(document.body, {subtree: true, attributes: true, attributeFilter: ['class']}) observer.observe(document.body, { subtree: true, attributes: true, attributeFilter: ['class'] })
return () => observer.disconnect() return () => observer.disconnect()
}, []) }, [open])
const onSubmit = async (data: CreateNoteFormData) => { const onSubmit = async (data: CreateNoteFormData) => {
if (note) { if (note) {