admin-valentin/open-notebook
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(docker): make wait-for-api.sh POSIX and enforce LF line endings (#586) (#598)

Browse source 
* fix(docker): make wait-for-api.sh POSIX and enforce LF line endings (#586)

* fix: restore inline comment on final exit 0

Addresses review feedback: the comment on the final `exit 0` explains
a non-obvious design decision (frontend still starts when the API
never became ready, so users get a usable UI with connection errors
rather than a dead container).

---------

Co-authored-by: Luis Novo <lfnovo@gmail.com>
This commit is contained in:
Greg G 2026-04-19 14:49:11 -04:00 committed by GitHub
parent 4efe613f69
commit 4d4330fb3f
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
.gitattributes vendored Normal file
View file

@ -0,0 +1,2 @@
# Ensure shell scripts always use LF so they run in Linux containers (e.g. Docker)
*.sh text eol=lf

9
scripts/wait-for-api.sh
View file

@ -1,18 +1,21 @@
#!/bin/bash #!/bin/sh
# Wait for the API to be healthy before starting the frontend # Wait for the API to be healthy before starting the frontend
# This prevents the "Unable to Connect to API Server" error during startup # This prevents the "Unable to Connect to API Server" error during startup
# POSIX-compliant so it runs with /bin/sh (dash) in slim images
API_URL="${INTERNAL_API_URL:-http://localhost:5055}" API_URL="${INTERNAL_API_URL:-http://localhost:5055}"
MAX_RETRIES=60 # 60 retries * 5 seconds = 5 minutes max wait MAX_RETRIES=60
RETRY_INTERVAL=5 RETRY_INTERVAL=5
i=0
echo "Waiting for API to be ready at ${API_URL}/health..." echo "Waiting for API to be ready at ${API_URL}/health..."
for i in $(seq 1 $MAX_RETRIES); do while [ $i -lt $MAX_RETRIES ]; do
if curl -s -f "${API_URL}/health" > /dev/null 2>&1; then if curl -s -f "${API_URL}/health" > /dev/null 2>&1; then
echo "API is ready! Starting frontend..." echo "API is ready! Starting frontend..."
exit 0 exit 0
fi fi
i=$((i + 1))
echo "Attempt $i/$MAX_RETRIES: API not ready yet, waiting ${RETRY_INTERVAL}s..." echo "Attempt $i/$MAX_RETRIES: API not ready yet, waiting ${RETRY_INTERVAL}s..."
sleep $RETRY_INTERVAL sleep $RETRY_INTERVAL
done done