admin-valentin/open-notebook
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Merge pull request #588 from lfnovo/fix/ui-fixes

Browse source 
fix: UI overflow, translation proxy, and notes API fixes
This commit is contained in:
Luis Novo 2026-02-16 15:08:07 -03:00 committed by GitHub
commit 6226db2746
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
13 changed files with 23 additions and 27 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
api/routers/notes.py
View file

@ -96,7 +96,7 @@ async def create_note(note_data: NoteCreate):
note_type=new_note.note_type,
created=str(new_note.created),
updated=str(new_note.updated),
command_id=command_id,
command_id=str(command_id) if command_id else None,
)
except HTTPException:
raise
@ -160,7 +160,7 @@ async def update_note(note_id: str, note_update: NoteUpdate):
note_type=note.note_type,
created=str(note.created),
updated=str(note.updated),
command_id=command_id,
command_id=str(command_id) if command_id else None,
)
except HTTPException:
raise

2
frontend/src/app/(dashboard)/notebooks/[id]/page.tsx
View file

@ -230,7 +230,7 @@ export default function NotebookPage() {
</div>
{/* Chat Column - always expanded, takes remaining space */}
<div className="transition-all duration-150 flex-1 lg:pr-6 lg:-mr-6">
<div className="transition-all duration-150 flex-1 min-w-0 lg:pr-6 lg:-mr-6">
<ChatColumn
notebookId={notebookId}
contextSelections={contextSelections}

2
frontend/src/app/(dashboard)/notebooks/components/NoteEditorDialog.tsx
View file

@ -126,7 +126,7 @@ export function NoteEditorDialog({ open, onOpenChange, notebookId, note }: NoteE
<DialogTitle className="sr-only">
{isEditing ? t.sources.editNote : t.sources.createNote}
</DialogTitle>
<form onSubmit={handleSubmit(onSubmit)} className="flex h-full flex-col">
<form onSubmit={handleSubmit(onSubmit)} className="flex h-full flex-col min-w-0">
{isEditing && noteLoading ? (
<div className="flex-1 flex items-center justify-center py-10">
<span className="text-sm text-muted-foreground">{t.common.loading}</span>

4
frontend/src/app/(dashboard)/notebooks/components/NotesColumn.tsx
View file

@ -179,11 +179,11 @@ export function NotesColumn({
</div>
{note.title && (
<h4 className="text-sm font-medium mb-2">{note.title}</h4>
<h4 className="text-sm font-medium mb-2 break-all">{note.title}</h4>
)}
{note.content && (
<p className="text-sm text-muted-foreground line-clamp-3">
<p className="text-sm text-muted-foreground line-clamp-3 break-all">
{note.content}
</p>
)}

2
frontend/src/components/common/InlineEdit.tsx
View file

@ -87,7 +87,7 @@ export function InlineEdit({
<button
type="button"
className={cn(
"cursor-pointer hover:bg-muted/50 rounded px-2 py-1 -mx-2 -my-1 transition-colors text-left w-full",
"cursor-pointer hover:bg-muted/50 rounded px-2 py-1 -mx-2 -my-1 transition-colors text-left w-full break-all",
className
)}
onClick={(e) => {

2
frontend/src/components/notebooks/CreateNotebookDialog.tsx
View file

@ -75,7 +75,7 @@ export function CreateNotebookDialog({ open, onOpenChange }: CreateNotebookDialo
<form onSubmit={handleSubmit(onSubmit)} className="space-y-4">
<div className="space-y-2">
<Label htmlFor="notebook-name">{t.common.name || 'Name'} *</Label>
<Label htmlFor="notebook-name">{t.common.name} *</Label>
<Input
id="notebook-name"
{...register('name')}

6
frontend/src/components/source/ChatPanel.tsx
View file

@ -203,7 +203,7 @@ export function ChatPanel({
onReferenceClick={handleReferenceClick}
/>
) : (
<p className="text-sm break-words overflow-wrap-anywhere">{message.content}</p>
<p className="text-sm break-all">{message.content}</p>
)}
</div>
{message.type === 'ai' && (
@ -290,7 +290,7 @@ export function ChatPanel({
</div>
)}
<div className="flex gap-2 items-end">
<div className="flex gap-2 items-end min-w-0">
<Textarea
id={chatInputId}
name="chat-message"
@ -300,7 +300,7 @@ export function ChatPanel({
onKeyDown={handleKeyDown}
placeholder={`${t.chat.sendPlaceholder} (${t.chat.pressToSend.replace('{key}', keyHint)})`}
disabled={isStreaming}
className="flex-1 min-h-[40px] max-h-[100px] resize-none py-2 px-3"
className="flex-1 min-h-[40px] max-h-[100px] resize-none py-2 px-3 min-w-0"
rows={1}
/>
<Button

2
frontend/src/components/sources/AddSourceDialog.tsx
View file

@ -542,7 +542,7 @@ export function AddSourceDialog({
</DialogDescription>
</DialogHeader>
<form onSubmit={handleSubmit(onSubmit)}>
<form onSubmit={handleSubmit(onSubmit)} className="min-w-0">
<WizardContainer
currentStep={currentStep}
steps={WIZARD_STEPS}

2
frontend/src/components/sources/SourceCard.tsx
View file

@ -240,7 +240,7 @@ export function SourceCard({
{/* Title */}
<div className={cn('mb-1.5', !isCompleted && 'mb-1')}>
<h4
className="text-sm font-medium leading-tight line-clamp-2"
className="text-sm font-medium leading-tight line-clamp-2 break-all"
title={title}
>
{title}

2
frontend/src/components/ui/dialog.tsx
View file

@ -63,7 +63,7 @@ const DialogContent = ({
data-slot="dialog-content"
aria-describedby={undefined}
className={cn(
"bg-background data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[state=closed]:pointer-events-none fixed top-[50%] left-[50%] z-50 grid w-full max-w-[calc(100%-2rem)] translate-x-[-50%] translate-y-[-50%] gap-4 rounded-lg border p-6 shadow-lg duration-200 sm:max-w-[calc(100%-2rem)]",
"bg-background data-[state=open]:animate-in data-[state=closed]:animate-out data-[state=closed]:fade-out-0 data-[state=open]:fade-in-0 data-[state=closed]:zoom-out-95 data-[state=open]:zoom-in-95 data-[state=closed]:pointer-events-none fixed top-[50%] left-[50%] z-50 grid w-full max-w-[calc(100%-2rem)] translate-x-[-50%] translate-y-[-50%] gap-4 rounded-lg border p-6 shadow-lg duration-200 sm:max-w-[calc(100%-2rem)] overflow-hidden",
className
)}
{...props}

2
frontend/src/components/ui/textarea.tsx
View file

@ -7,7 +7,7 @@ function Textarea({ className, ...props }: React.ComponentProps<"textarea">) {
<textarea
data-slot="textarea"
className={cn(
"border-input placeholder:text-muted-foreground focus-visible:border-ring focus-visible:ring-ring/50 aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40 aria-invalid:border-destructive dark:bg-input/30 flex field-sizing-content min-h-16 w-full rounded-md border bg-transparent px-3 py-2 text-base shadow-xs transition-[color,box-shadow] outline-none focus-visible:ring-[3px] disabled:cursor-not-allowed disabled:opacity-50 md:text-sm",
"border-input placeholder:text-muted-foreground focus-visible:border-ring focus-visible:ring-ring/50 aria-invalid:ring-destructive/20 dark:aria-invalid:ring-destructive/40 aria-invalid:border-destructive dark:bg-input/30 flex field-sizing-content min-h-16 min-w-0 w-full rounded-md border bg-transparent px-3 py-2 text-base shadow-xs transition-[color,box-shadow] outline-none focus-visible:ring-[3px] disabled:cursor-not-allowed disabled:opacity-50 md:text-sm",
className
)}
{...props}

10
frontend/src/components/ui/wizard-container.tsx
View file

@ -85,15 +85,15 @@ export function WizardContainer({
className
}: WizardContainerProps) {
return (
<div className={cn('flex flex-col h-[500px] bg-card rounded-lg border border-border', className)}>
<StepIndicator
<div className={cn('flex flex-col h-[500px] min-w-0 overflow-hidden bg-card rounded-lg border border-border', className)}>
<StepIndicator
currentStep={currentStep}
steps={steps}
onStepClick={onStepClick}
/>
<div className="flex-1 overflow-hidden">
<div className="h-full overflow-y-auto px-6 py-4">
<div className="flex-1 min-w-0 overflow-hidden">
<div className="h-full min-w-0 overflow-y-auto px-6 py-4">
{children}
</div>
</div>

10
frontend/src/lib/hooks/use-translation.ts
View file

@ -78,12 +78,6 @@ export function useTranslation() {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
return (target as any)[prop];
}
// Handle function's own properties
if (prop in target) {
// eslint-disable-next-line @typescript-eslint/no-explicit-any
return (target as any)[prop];
}
if (typeof prop !== 'string') return undefined;
@ -94,7 +88,9 @@ export function useTranslation() {
const currentPath = path ? `${path}.${prop}` : prop;
// Try to get the translation
// Try to get the translation first (before checking target properties,
// since target is a function and has built-in properties like 'name'
// that would shadow translation keys)
const result = i18nTranslateCopy(currentPath, { returnObjects: true });
// If it's a leaf string, return it directly