From d147994b9246a8b2509570603e98fe60ee4ea572 Mon Sep 17 00:00:00 2001
From: Luis Novo <lfnovo@gmail.com>
Date: Mon, 16 Feb 2026 14:46:42 -0300
Subject: [PATCH] fix: resolve translation proxy shadowing `name` keys

The Proxy's get handler checked `prop in target` before looking up
translations. Since the target is a function, `Function.name` is a
built-in property that shadowed translation keys like `t.common.name`,
causing the raw proxy path to render instead of the translated string.

Move translation lookup before target property checks so i18n keys
always take priority. Also remove unnecessary `|| 'Name'` fallback
in CreateNotebookDialog.
---
 .../src/components/notebooks/CreateNotebookDialog.tsx  |  2 +-
 frontend/src/lib/hooks/use-translation.ts              | 10 +++-------
 2 files changed, 4 insertions(+), 8 deletions(-)

diff --git a/frontend/src/components/notebooks/CreateNotebookDialog.tsx b/frontend/src/components/notebooks/CreateNotebookDialog.tsx
index a224c34..ced84c4 100644
--- a/frontend/src/components/notebooks/CreateNotebookDialog.tsx
+++ b/frontend/src/components/notebooks/CreateNotebookDialog.tsx
@@ -75,7 +75,7 @@ export function CreateNotebookDialog({ open, onOpenChange }: CreateNotebookDialo
 
         <form onSubmit={handleSubmit(onSubmit)} className="space-y-4">
           <div className="space-y-2">
-            <Label htmlFor="notebook-name">{t.common.name || 'Name'} *</Label>
+            <Label htmlFor="notebook-name">{t.common.name} *</Label>
             <Input
               id="notebook-name"
               {...register('name')}
diff --git a/frontend/src/lib/hooks/use-translation.ts b/frontend/src/lib/hooks/use-translation.ts
index 44a515d..128c044 100644
--- a/frontend/src/lib/hooks/use-translation.ts
+++ b/frontend/src/lib/hooks/use-translation.ts
@@ -78,12 +78,6 @@ export function useTranslation() {
             // eslint-disable-next-line @typescript-eslint/no-explicit-any
             return (target as any)[prop];
           }
-          
-          // Handle function's own properties
-          if (prop in target) {
-            // eslint-disable-next-line @typescript-eslint/no-explicit-any
-            return (target as any)[prop];
-          }
 
           if (typeof prop !== 'string') return undefined;
 
@@ -94,7 +88,9 @@ export function useTranslation() {
 
           const currentPath = path ? `${path}.${prop}` : prop;
 
-          // Try to get the translation
+          // Try to get the translation first (before checking target properties,
+          // since target is a function and has built-in properties like 'name'
+          // that would shadow translation keys)
           const result = i18nTranslateCopy(currentPath, { returnObjects: true });
 
           // If it's a leaf string, return it directly