18a7cab36f
- #627: Replace model-construction tests with endpoint-level tests that exercise the real create_source async path via TestClient, capturing the Source instance passed to save() using patch.object(autospec=True) - #651: Use assert_awaited_once() instead of assert_called_once() on AsyncMock methods to catch missing await bugs - Remove redundant class-level @patch for Source.save in title tests
362 lines
13 KiB
Python
362 lines
13 KiB
Python
"""
|
|
Tests for bug fixes #627 (asset persistence), #670 (title preservation),
|
|
and #651 (credential cascade delete).
|
|
"""
|
|
|
|
from unittest.mock import AsyncMock, MagicMock, patch
|
|
|
|
import pytest
|
|
from fastapi.testclient import TestClient
|
|
|
|
from open_notebook.domain.notebook import Asset, Source
|
|
|
|
|
|
@pytest.fixture
|
|
def client():
|
|
"""Create test client after environment variables have been cleared by conftest."""
|
|
from api.main import app
|
|
|
|
return TestClient(app)
|
|
|
|
|
|
# ============================================================================
|
|
# TEST SUITE 1: #627 - Async source creation persists asset
|
|
# ============================================================================
|
|
|
|
|
|
class TestAsyncSourceAssetPersistence:
|
|
"""Tests for #627 - asset is persisted before async processing.
|
|
|
|
These tests hit the real create_source endpoint with mocked DB/command
|
|
calls, verifying that the Source saved to the database has the correct
|
|
asset set *before* async processing begins.
|
|
"""
|
|
|
|
@pytest.mark.asyncio
|
|
@patch("api.routers.sources.CommandService.submit_command_job", new_callable=AsyncMock)
|
|
@patch("api.routers.sources.Source.add_to_notebook", new_callable=AsyncMock)
|
|
@patch("api.routers.sources.Notebook.get", new_callable=AsyncMock)
|
|
async def test_async_link_source_persists_url_asset(
|
|
self, mock_nb_get, mock_add_nb, mock_submit, client
|
|
):
|
|
"""POST /sources with type=link and async_processing=true persists Asset(url=...)."""
|
|
mock_nb_get.return_value = MagicMock() # notebook exists
|
|
mock_submit.return_value = "command:123"
|
|
|
|
# Track the Source instance that save() is called on
|
|
saved_sources = []
|
|
|
|
async def capture_save(self_source):
|
|
saved_sources.append(self_source)
|
|
self_source.id = "source:fake"
|
|
self_source.command = None
|
|
|
|
with patch.object(Source, "save", autospec=True, side_effect=capture_save):
|
|
response = client.post(
|
|
"/api/sources",
|
|
data={
|
|
"type": "link",
|
|
"url": "https://example.com/article",
|
|
"notebooks": '["notebook:1"]',
|
|
"async_processing": "true",
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert len(saved_sources) >= 1
|
|
|
|
# The first save should have the asset with URL
|
|
source = saved_sources[0]
|
|
assert source.asset is not None
|
|
assert source.asset.url == "https://example.com/article"
|
|
assert source.asset.file_path is None
|
|
|
|
@pytest.mark.asyncio
|
|
@patch("api.routers.sources.CommandService.submit_command_job", new_callable=AsyncMock)
|
|
@patch("api.routers.sources.Source.add_to_notebook", new_callable=AsyncMock)
|
|
@patch("api.routers.sources.Notebook.get", new_callable=AsyncMock)
|
|
@patch("api.routers.sources.save_uploaded_file", new_callable=AsyncMock)
|
|
async def test_async_upload_source_persists_file_asset(
|
|
self, mock_upload, mock_nb_get, mock_add_nb, mock_submit, client
|
|
):
|
|
"""POST /sources with type=upload and async_processing=true persists Asset(file_path=...)."""
|
|
mock_nb_get.return_value = MagicMock()
|
|
mock_upload.return_value = "/tmp/uploads/video.mp4"
|
|
mock_submit.return_value = "command:123"
|
|
|
|
saved_sources = []
|
|
|
|
async def capture_save(self_source):
|
|
saved_sources.append(self_source)
|
|
self_source.id = "source:fake"
|
|
self_source.command = None
|
|
|
|
with patch.object(Source, "save", autospec=True, side_effect=capture_save):
|
|
response = client.post(
|
|
"/api/sources",
|
|
data={
|
|
"type": "upload",
|
|
"notebooks": '["notebook:1"]',
|
|
"async_processing": "true",
|
|
},
|
|
files={"file": ("video.mp4", b"fake content", "video/mp4")},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert len(saved_sources) >= 1
|
|
|
|
source = saved_sources[0]
|
|
assert source.asset is not None
|
|
assert source.asset.file_path == "/tmp/uploads/video.mp4"
|
|
assert source.asset.url is None
|
|
|
|
@pytest.mark.asyncio
|
|
@patch("api.routers.sources.CommandService.submit_command_job", new_callable=AsyncMock)
|
|
@patch("api.routers.sources.Source.add_to_notebook", new_callable=AsyncMock)
|
|
@patch("api.routers.sources.Notebook.get", new_callable=AsyncMock)
|
|
async def test_async_text_source_has_no_asset(
|
|
self, mock_nb_get, mock_add_nb, mock_submit, client
|
|
):
|
|
"""POST /sources with type=text and async_processing=true has asset=None."""
|
|
mock_nb_get.return_value = MagicMock()
|
|
mock_submit.return_value = "command:123"
|
|
|
|
saved_sources = []
|
|
|
|
async def capture_save(self_source):
|
|
saved_sources.append(self_source)
|
|
self_source.id = "source:fake"
|
|
self_source.command = None
|
|
|
|
with patch.object(Source, "save", autospec=True, side_effect=capture_save):
|
|
response = client.post(
|
|
"/api/sources",
|
|
data={
|
|
"type": "text",
|
|
"content": "Some text content",
|
|
"notebooks": '["notebook:1"]',
|
|
"async_processing": "true",
|
|
},
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
assert len(saved_sources) >= 1
|
|
|
|
source = saved_sources[0]
|
|
assert source.asset is None
|
|
|
|
|
|
# ============================================================================
|
|
# TEST SUITE 2: #670 - Custom title preservation
|
|
# ============================================================================
|
|
|
|
|
|
class TestTitlePreservation:
|
|
"""Tests for #670 - user-set titles are preserved after processing."""
|
|
|
|
@pytest.mark.asyncio
|
|
@patch("open_notebook.graphs.source.Source.get")
|
|
async def test_custom_title_preserved(self, mock_get):
|
|
"""User-set title is NOT overwritten by content_state.title."""
|
|
from open_notebook.graphs.source import save_source
|
|
|
|
mock_source = MagicMock(spec=Source)
|
|
mock_source.title = "My Custom Research Title"
|
|
mock_source.save = AsyncMock()
|
|
mock_get.return_value = mock_source
|
|
|
|
content_state = MagicMock()
|
|
content_state.title = "video.mp4"
|
|
content_state.url = "https://example.com"
|
|
content_state.file_path = None
|
|
content_state.content = "Some content"
|
|
|
|
state = {
|
|
"source_id": "source:123",
|
|
"content_state": content_state,
|
|
"embed": False,
|
|
"apply_transformations": [],
|
|
}
|
|
|
|
await save_source(state)
|
|
|
|
assert mock_source.title == "My Custom Research Title"
|
|
mock_source.save.assert_awaited_once()
|
|
|
|
@pytest.mark.asyncio
|
|
@patch("open_notebook.graphs.source.Source.get")
|
|
async def test_placeholder_title_replaced(self, mock_get):
|
|
"""Placeholder 'Processing...' title IS replaced by extracted title."""
|
|
from open_notebook.graphs.source import save_source
|
|
|
|
mock_source = MagicMock(spec=Source)
|
|
mock_source.title = "Processing..."
|
|
mock_source.save = AsyncMock()
|
|
mock_get.return_value = mock_source
|
|
|
|
content_state = MagicMock()
|
|
content_state.title = "Extracted Article Title"
|
|
content_state.url = "https://example.com"
|
|
content_state.file_path = None
|
|
content_state.content = "Some content"
|
|
|
|
state = {
|
|
"source_id": "source:123",
|
|
"content_state": content_state,
|
|
"embed": False,
|
|
"apply_transformations": [],
|
|
}
|
|
|
|
await save_source(state)
|
|
|
|
assert mock_source.title == "Extracted Article Title"
|
|
mock_source.save.assert_awaited_once()
|
|
|
|
@pytest.mark.asyncio
|
|
@patch("open_notebook.graphs.source.Source.get")
|
|
async def test_none_title_replaced(self, mock_get):
|
|
"""None title IS replaced by extracted title."""
|
|
from open_notebook.graphs.source import save_source
|
|
|
|
mock_source = MagicMock(spec=Source)
|
|
mock_source.title = None
|
|
mock_source.save = AsyncMock()
|
|
mock_get.return_value = mock_source
|
|
|
|
content_state = MagicMock()
|
|
content_state.title = "Extracted Title"
|
|
content_state.url = None
|
|
content_state.file_path = "/tmp/file.pdf"
|
|
content_state.content = "Content"
|
|
|
|
state = {
|
|
"source_id": "source:123",
|
|
"content_state": content_state,
|
|
"embed": False,
|
|
"apply_transformations": [],
|
|
}
|
|
|
|
await save_source(state)
|
|
|
|
assert mock_source.title == "Extracted Title"
|
|
mock_source.save.assert_awaited_once()
|
|
|
|
@pytest.mark.asyncio
|
|
@patch("open_notebook.graphs.source.Source.get")
|
|
async def test_empty_title_replaced(self, mock_get):
|
|
"""Empty string title IS replaced by extracted title."""
|
|
from open_notebook.graphs.source import save_source
|
|
|
|
mock_source = MagicMock(spec=Source)
|
|
mock_source.title = ""
|
|
mock_source.save = AsyncMock()
|
|
mock_get.return_value = mock_source
|
|
|
|
content_state = MagicMock()
|
|
content_state.title = "Extracted Title"
|
|
content_state.url = None
|
|
content_state.file_path = None
|
|
content_state.content = "Content"
|
|
|
|
state = {
|
|
"source_id": "source:123",
|
|
"content_state": content_state,
|
|
"embed": False,
|
|
"apply_transformations": [],
|
|
}
|
|
|
|
await save_source(state)
|
|
|
|
assert mock_source.title == "Extracted Title"
|
|
mock_source.save.assert_awaited_once()
|
|
|
|
|
|
# ============================================================================
|
|
# TEST SUITE 3: #651 - Credential cascade delete
|
|
# ============================================================================
|
|
|
|
|
|
class TestCredentialCascadeDelete:
|
|
"""Tests for #651 - deleting credential cascade-deletes linked models."""
|
|
|
|
@pytest.mark.asyncio
|
|
@patch("api.routers.credentials.Credential.get")
|
|
async def test_cascade_delete_linked_models(self, mock_get, client):
|
|
"""Deleting credential without options cascade-deletes linked models."""
|
|
mock_model1 = AsyncMock()
|
|
mock_model1.id = "model:1"
|
|
mock_model1.provider = "openai"
|
|
mock_model1.name = "gpt-4"
|
|
|
|
mock_model2 = AsyncMock()
|
|
mock_model2.id = "model:2"
|
|
mock_model2.provider = "openai"
|
|
mock_model2.name = "gpt-3.5-turbo"
|
|
|
|
mock_cred = AsyncMock()
|
|
mock_cred.get_linked_models = AsyncMock(
|
|
return_value=[mock_model1, mock_model2]
|
|
)
|
|
mock_cred.delete = AsyncMock()
|
|
mock_get.return_value = mock_cred
|
|
|
|
response = client.delete("/api/credentials/cred:123")
|
|
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
assert data["deleted_models"] == 2
|
|
assert data["message"] == "Credential deleted successfully"
|
|
|
|
mock_model1.delete.assert_awaited_once()
|
|
mock_model2.delete.assert_awaited_once()
|
|
mock_cred.delete.assert_awaited_once()
|
|
|
|
@pytest.mark.asyncio
|
|
@patch("api.routers.credentials.Credential.get")
|
|
async def test_delete_credential_no_linked_models(self, mock_get, client):
|
|
"""Deleting credential with no linked models works cleanly."""
|
|
mock_cred = AsyncMock()
|
|
mock_cred.get_linked_models = AsyncMock(return_value=[])
|
|
mock_cred.delete = AsyncMock()
|
|
mock_get.return_value = mock_cred
|
|
|
|
response = client.delete("/api/credentials/cred:123")
|
|
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
assert data["deleted_models"] == 0
|
|
mock_cred.delete.assert_awaited_once()
|
|
|
|
@pytest.mark.asyncio
|
|
@patch("api.routers.credentials.Credential.get")
|
|
async def test_migrate_models_instead_of_delete(self, mock_get, client):
|
|
"""Passing migrate_to reassigns models instead of deleting them."""
|
|
mock_model = AsyncMock()
|
|
mock_model.id = "model:1"
|
|
mock_model.credential = "cred:123"
|
|
mock_model.save = AsyncMock()
|
|
|
|
mock_cred = AsyncMock()
|
|
mock_cred.get_linked_models = AsyncMock(return_value=[mock_model])
|
|
mock_cred.delete = AsyncMock()
|
|
|
|
mock_target_cred = AsyncMock()
|
|
mock_target_cred.id = "cred:456"
|
|
|
|
# First call returns cred to delete, second returns target
|
|
mock_get.side_effect = [mock_cred, mock_target_cred]
|
|
|
|
response = client.delete(
|
|
"/api/credentials/cred:123?migrate_to=cred:456"
|
|
)
|
|
|
|
assert response.status_code == 200
|
|
data = response.json()
|
|
assert data["deleted_models"] == 0 # Models were migrated, not deleted
|
|
mock_model.save.assert_awaited_once()
|
|
assert mock_model.credential == "cred:456"
|
|
mock_cred.delete.assert_awaited_once()
|
|
|
|
|
|
if __name__ == "__main__":
|
|
pytest.main([__file__, "-v"])
|