open-notebook/frontend/src/components/layout/AppSidebar.tsx
MisonL 67dd85c928
Feat/localization tests docker (#371)
* feat(i18n): complete 100% internationalization and fix Next.js 15 compatibility

* feat(i18n): complete 100% internationalization coverage

* chore(test): finalize component tests and project cleanup

* test(logic): add unit tests for useModalManager hook

* fix(test): resolve timeout in AppSidebar tests by mocking TooltipProvider

* feat(i18n): comprehensive i18n audit, fixes for hardcoded strings, and complete zh-TW support

* fix(i18n): resolve TypeScript warnings and improve translation hook stability

- Remove unused useTranslation import from ConnectionGuard
- Add ref-based checking state to prevent dependency cycles
- Fix useTranslation hook to return empty string for undefined translations
- Add comment for backward compatibility on ExtractedReference interface
- Ensure .replace() string methods work safely with nested translation keys

* feat(i18n): complete internationalization implementation with Docker deployment

- Add LanguageLoadingOverlay component for smooth language transitions
- Update all translation files (en-US, zh-CN, zh-TW) with improved terminology
- Optimize Docker configuration for better performance
- Update version check and config handling for i18n support
- Fix route handling for language-specific content
- Add comprehensive task documentation

* fix(i18n): resolve localization errors, duplicates, and type issues

* chore(i18n): finalize 100% internationalization coverage

* chore(test): supplement i18n test cases and cleanup redundant files

* fix(test): resolve lint type errors and finalize delivery documents

* feat(i18n): finalize full internationalization and zh-TW localization

* fix(frontend): add missing devDependency and fix build tsconfig

* feat(ui): enhance sidebar hover effects with better visual feedback

* fix(frontend): resolve accessibility, i18n, and lint issues

- fix: add missing id, name, autocomplete attributes to dialog inputs
- fix: add aria labels and DialogDescription for accessibility
- fix: resolve uncontrolled component warning in SettingsForm
- fix: correct duplicate 'Traditional Chinese' label in zh-TW locale
- feat: add i18n support for podcast template names
- chore: fix lint errors in Dialogs

* fix: address all 21 PR feedback items from cubic-dev-ai bot

Configuration:
- Remove ignoreDuringBuilds flags from next.config.ts

Testing:
- Fix AppSidebar.test.tsx regex pattern and add missing assertion

Logic:
- Fix ConnectionGuard.tsx re-entry prevention logic

Internationalization (I18n) - Translations:
- Add missing keys: notebooks.archived, common.note/insight, accessibility keys
- Add specific keys: sources.allSourcesDescShort, transformations.selectModel
- Add singular/plural keys: podcasts.usedByCount_one/other, common.note/notes
- Add common.created/updated with {time} placeholder

Internationalization (I18n) - Usage:
- SourcesPage: use allSourcesDescShort instead of string splitting
- TransformationPlayground: use navigation.transformation and selectModel
- CommandPalette: use dedicated keys instead of string concatenation
- GeneratePodcastDialog: fix zh-TW date locale handling
- NotebookHeader: correctly interpolate {time} placeholder
- TransformationCard: use common.description instead of undefined key
- ChatPanel/SpeakerProfilesPanel: implement proper pluralization
- SystemInfo: correctly interpolate {version} placeholder
- LanguageLoadingOverlay: use t.common.loading instead of hardcoded string
- MessageActions: use specific error key cannotSaveNoteNoNotebook

Other:
- Fix SessionManager.tsx exhaustive-deps warning

* fix: remove duplicate locale keys and add missing zh-CN translations

- en-US: remove duplicate loading key (line 59) and addNew key (sources)
- zh-CN: remove duplicate common keys (loading, note, insight, newSource, newNotebook, newPodcast)
- zh-CN: remove duplicate accessibility.searchNotebooks key
- zh-CN: remove duplicate sources.addNew key
- zh-CN: remove duplicate navigation.transformation key
- zh-CN: add missing usedByCount_one and usedByCount_other keys in podcasts
- zh-TW: remove duplicate common keys (loading, note, insight, newSource, newNotebook, newPodcast)
- zh-TW: remove duplicate accessibility.searchNotebooks key
- zh-TW: remove duplicate sources.addNew key

* docs: remove info.md

* fix: remove duplicate notebook keys and unused ts-expect-error

- zh-CN: remove duplicate notebooks keys (archived, archive, unarchive, deleteNotebook, deleteNotebookDesc)
- zh-TW: remove duplicate notebooks keys (archived, archive, unarchive, deleteNotebook, deleteNotebookDesc)
- GeneratePodcastDialog: remove unused @ts-expect-error directive

* fix(a11y): fix unassociated labels in search page

- Replace <Label> with role='group' + aria-labelledby for search type section
- Replace <Label> with role='group' + aria-labelledby for search in section
- Follows WAI-ARIA best practices for labeling form field groups

* fix(a11y): fix unassociated labels across multiple components

- search/page.tsx: use role='group' + aria-labelledby for search type and search in sections
- RebuildEmbeddings.tsx: use role='group' + aria-labelledby for include checkboxes
- TransformationPlayground.tsx: replace Label with span for non-form output label

* chore: revert to npm stack and ensure i18n compatibility

* chore: polish zh-TW translations for better idiomatic usage

* fix: resolve linter errors (ruff import sort, mypy config duplicate)

* style: apply ruff formatting

* fix: finalize upstream compliance (Dockerfile.single, i18n hooks, docker-compose)

* style: polish strings, fix timeout cleanup, and improve test mocks

* fix: use relative imports in test setup to resolve IDE path errors

* perf(docker): optimize build speed by removing apt-get upgrade and build tools

- Remove apt-get upgrade from both builder and runtime stages (saves 10-15 min each)
- Remove gcc/g++/make/git from builder (uv downloads pre-built wheels)
- Add --no-install-recommends to minimize package footprint
- Keep npm mirror (npmmirror.com) for faster frontend deps
- Add npm registry config for reliable China network access

Also includes:
- fix(a11y): add missing labels and aria attributes to form fields
- fix(i18n): add 2s safety timeout to LanguageLoadingOverlay
- fix(i18n): add robustness checks to use-translation proxy

Build time reduced from 2+ hours to ~34 minutes (~70% improvement)

* fix(a11y): resolve 16 form field accessibility warnings in notebook and podcast pages

* fix(a11y): resolve 4 button and 1 select field accessibility warnings in models page

* fix(a11y): resolve redundant attributes and residual warnings in transformations and podcast forms

* fix(i18n): deep fix for language switch hang using proxy protection and safer access

* fix(a11y): add name attributes to ModelSelector, TransformationPlayground, and SourceDetailContent

* fix: add missing Label import to SourceDetailContent

* fix(i18n): use native react-i18next in LanguageLoadingOverlay to prevent hang during language switch

* fix(i18n): rewrite use-translation Proxy with strict depth limit and expanded blocked props to prevent language switch hang

* fix: add type assertion to fix TypeScript comparison error

* fix(i18n): disable useSuspense to prevent thread hang during language resource loading

* fix(i18n): add infinite loop detection circuit breaker to useTranslation hook

* fix(i18n): update traditional chinese label to native script in en-US

* feat: add new localization strings for notebook and note management.

* fix: resolve config priority, docker build deps, and ui glitches

* refactor: improve ui details and test coverage based on feedback

* refactor: improve ui details (version check/lang toggle) and test coverage

* fix: polish language matching and test cleanup

* fix(test): update mocks to resolve timeouts and proxy errors

* fix(frontend): restore tsconfig.json structure and enable IDE support for tests

* fix: address PR review findings and resolve CI OIDC failure

* fix: merge exception headers in custom handler

* fix: comprehensive PR review remediations and async performance fixes

* refactor: address all PR #371 review feedback

- Docker: consolidate SURREAL_URL to docker.env, add single-container override
- Security: restore apt-get upgrade in Dockerfile and Dockerfile.single
- Create centralized getDateLocale helper (lib/utils/date-locale.ts)
- Refactor 7 files to use getDateLocale helper
- Revert config/route.ts to origin/main version
- Move test files to co-located pattern (3 files)
- Remove local useTranslation mock from ConfirmDialog.test.tsx
- Simplify use-version-check to single useEffect pattern
- Fix test import paths after moving to co-located pattern

* fix: add jest-dom types for test files

* fix: address remaining review issues

- Add apt-get upgrade -y to Dockerfile.single backend-builder stage
- Refactor ChatColumn.test.tsx: use 'as unknown as ReturnType<typeof hook>' instead of 'as any'
- Use toBeInTheDocument() assertions instead of toBeDefined()
2026-01-15 13:51:05 -03:00

381 lines
12 KiB
TypeScript

'use client'
import { useState, useEffect } from 'react'
import Link from 'next/link'
import Image from 'next/image'
import { usePathname } from 'next/navigation'
import { cn } from '@/lib/utils'
import { Button } from '@/components/ui/button'
import { useAuth } from '@/lib/hooks/use-auth'
import { useSidebarStore } from '@/lib/stores/sidebar-store'
import { useCreateDialogs } from '@/lib/hooks/use-create-dialogs'
import {
Tooltip,
TooltipContent,
TooltipProvider,
TooltipTrigger,
} from '@/components/ui/tooltip'
import {
DropdownMenu,
DropdownMenuContent,
DropdownMenuItem,
DropdownMenuTrigger,
} from '@/components/ui/dropdown-menu'
import { ThemeToggle } from '@/components/common/ThemeToggle'
import { LanguageToggle } from '@/components/common/LanguageToggle'
import { TranslationKeys } from '@/lib/locales'
import { useTranslation } from '@/lib/hooks/use-translation'
import { Separator } from '@/components/ui/separator'
import {
Book,
Search,
Mic,
Bot,
Shuffle,
Settings,
LogOut,
ChevronLeft,
Menu,
FileText,
Plus,
Wrench,
Command,
} from 'lucide-react'
const getNavigation = (t: TranslationKeys) => [
{
title: t.navigation.collect,
items: [
{ name: t.navigation.sources, href: '/sources', icon: FileText },
],
},
{
title: t.navigation.process,
items: [
{ name: t.navigation.notebooks, href: '/notebooks', icon: Book },
{ name: t.navigation.askAndSearch, href: '/search', icon: Search },
],
},
{
title: t.navigation.create,
items: [
{ name: t.navigation.podcasts, href: '/podcasts', icon: Mic },
],
},
{
title: t.navigation.manage,
items: [
{ name: t.navigation.models, href: '/models', icon: Bot },
{ name: t.navigation.transformations, href: '/transformations', icon: Shuffle },
{ name: t.navigation.settings, href: '/settings', icon: Settings },
{ name: t.navigation.advanced, href: '/advanced', icon: Wrench },
],
},
] as const
type CreateTarget = 'source' | 'notebook' | 'podcast'
export function AppSidebar() {
const { t } = useTranslation()
const navigation = getNavigation(t)
const pathname = usePathname()
const { logout } = useAuth()
const { isCollapsed, toggleCollapse } = useSidebarStore()
const { openSourceDialog, openNotebookDialog, openPodcastDialog } = useCreateDialogs()
const [createMenuOpen, setCreateMenuOpen] = useState(false)
const [isMac, setIsMac] = useState(true) // Default to Mac for SSR
// Detect platform for keyboard shortcut display
useEffect(() => {
setIsMac(navigator.platform.toLowerCase().includes('mac'))
}, [])
const handleCreateSelection = (target: CreateTarget) => {
setCreateMenuOpen(false)
if (target === 'source') {
openSourceDialog()
} else if (target === 'notebook') {
openNotebookDialog()
} else if (target === 'podcast') {
openPodcastDialog()
}
}
return (
<TooltipProvider delayDuration={0}>
<div
className={cn(
'app-sidebar flex h-full flex-col bg-sidebar border-sidebar-border border-r transition-all duration-300',
isCollapsed ? 'w-16' : 'w-64'
)}
>
<div
className={cn(
'flex h-16 items-center group',
isCollapsed ? 'justify-center px-2' : 'justify-between px-4'
)}
>
{isCollapsed ? (
<div className="relative flex items-center justify-center w-full">
<Image
src="/logo.svg"
alt="Open Notebook"
width={32}
height={32}
className="transition-opacity group-hover:opacity-0"
/>
<Button
variant="ghost"
size="sm"
onClick={toggleCollapse}
className="absolute text-sidebar-foreground hover:bg-sidebar-accent opacity-0 group-hover:opacity-100 transition-opacity"
>
<Menu className="h-4 w-4" />
</Button>
</div>
) : (
<>
<div className="flex items-center gap-2">
<Image src="/logo.svg" alt={t.common.appName} width={32} height={32} />
<span className="text-base font-medium text-sidebar-foreground">
{t.common.appName}
</span>
</div>
<Button
variant="ghost"
size="sm"
onClick={toggleCollapse}
className="text-sidebar-foreground hover:bg-sidebar-accent"
data-testid="sidebar-toggle"
>
<ChevronLeft className="h-4 w-4" />
</Button>
</>
)}
</div>
<nav
className={cn(
'flex-1 space-y-1 py-4',
isCollapsed ? 'px-2' : 'px-3'
)}
>
<div
className={cn(
'mb-4',
isCollapsed ? 'px-0' : 'px-3'
)}
>
<DropdownMenu open={createMenuOpen} onOpenChange={setCreateMenuOpen}>
{isCollapsed ? (
<Tooltip>
<TooltipTrigger asChild>
<DropdownMenuTrigger asChild>
<Button
onClick={() => setCreateMenuOpen(true)}
variant="default"
size="sm"
className="w-full justify-center px-2 bg-primary hover:bg-primary/90 text-primary-foreground border-0"
aria-label={t.common.create}
>
<Plus className="h-4 w-4" />
</Button>
</DropdownMenuTrigger>
</TooltipTrigger>
<TooltipContent side="right">{t.common.create}</TooltipContent>
</Tooltip>
) : (
<DropdownMenuTrigger asChild>
<Button
onClick={() => setCreateMenuOpen(true)}
variant="default"
size="sm"
className="w-full justify-start bg-primary hover:bg-primary/90 text-primary-foreground border-0"
>
<Plus className="h-4 w-4 mr-2" />
{t.common.create}
</Button>
</DropdownMenuTrigger>
)}
<DropdownMenuContent
align={isCollapsed ? 'end' : 'start'}
side={isCollapsed ? 'right' : 'bottom'}
className="w-48"
>
<DropdownMenuItem
onSelect={(event) => {
event.preventDefault()
handleCreateSelection('source')
}}
className="gap-2"
>
<FileText className="h-4 w-4" />
{t.common.source}
</DropdownMenuItem>
<DropdownMenuItem
onSelect={(event) => {
event.preventDefault()
handleCreateSelection('notebook')
}}
className="gap-2"
>
<Book className="h-4 w-4" />
{t.common.notebook}
</DropdownMenuItem>
<DropdownMenuItem
onSelect={(event) => {
event.preventDefault()
handleCreateSelection('podcast')
}}
className="gap-2"
>
<Mic className="h-4 w-4" />
{t.common.podcast}
</DropdownMenuItem>
</DropdownMenuContent>
</DropdownMenu>
</div>
{navigation.map((section, index) => (
<div key={section.title}>
{index > 0 && (
<Separator className="my-3" />
)}
<div className="space-y-1">
{!isCollapsed && (
<h3 className="mb-2 px-3 text-xs font-semibold uppercase tracking-wider text-sidebar-foreground/60">
{section.title}
</h3>
)}
{section.items.map((item) => {
const isActive = pathname?.startsWith(item.href) || false
const button = (
<Button
variant={isActive ? 'secondary' : 'ghost'}
className={cn(
'w-full gap-3 text-sidebar-foreground sidebar-menu-item',
isActive && 'bg-sidebar-accent text-sidebar-accent-foreground',
isCollapsed ? 'justify-center px-2' : 'justify-start'
)}
>
<item.icon className="h-4 w-4" />
{!isCollapsed && <span>{item.name}</span>}
</Button>
)
if (isCollapsed) {
return (
<Tooltip key={item.name}>
<TooltipTrigger asChild>
<Link href={item.href}>
{button}
</Link>
</TooltipTrigger>
<TooltipContent side="right">{item.name}</TooltipContent>
</Tooltip>
)
}
return (
<Link key={item.name} href={item.href}>
{button}
</Link>
)
})}
</div>
</div>
))}
</nav>
<div
className={cn(
'border-t border-sidebar-border p-3 space-y-2',
isCollapsed && 'px-2'
)}
>
{/* Command Palette hint */}
{!isCollapsed && (
<div className="px-3 py-1.5 text-xs text-sidebar-foreground/60">
<div className="flex items-center justify-between">
<span className="flex items-center gap-1.5">
<Command className="h-3 w-3" />
{t.common.quickActions}
</span>
<kbd className="pointer-events-none inline-flex h-5 select-none items-center gap-1 rounded border bg-muted px-1.5 font-mono text-[10px] font-medium text-muted-foreground">
{isMac ? <span className="text-xs"></span> : <span>Ctrl+</span>}K
</kbd>
</div>
<p className="mt-1 text-[10px] text-sidebar-foreground/40">
{t.common.quickActionsDesc}
</p>
</div>
)}
<div
className={cn(
'flex flex-col gap-2',
isCollapsed ? 'items-center' : 'items-stretch'
)}
>
{isCollapsed ? (
<>
<Tooltip>
<TooltipTrigger asChild>
<div>
<ThemeToggle iconOnly />
</div>
</TooltipTrigger>
<TooltipContent side="right">{t.common.theme}</TooltipContent>
</Tooltip>
<Tooltip>
<TooltipTrigger asChild>
<div>
<LanguageToggle iconOnly />
</div>
</TooltipTrigger>
<TooltipContent side="right">{t.common.language}</TooltipContent>
</Tooltip>
</>
) : (
<>
<ThemeToggle />
<LanguageToggle />
</>
)}
</div>
{isCollapsed ? (
<Tooltip>
<TooltipTrigger asChild>
<Button
variant="outline"
className="w-full justify-center sidebar-menu-item"
onClick={logout}
aria-label={t.common.signOut}
>
<LogOut className="h-4 w-4" />
</Button>
</TooltipTrigger>
<TooltipContent side="right">{t.common.signOut}</TooltipContent>
</Tooltip>
) : (
<Button
variant="outline"
className="w-full justify-start gap-3 sidebar-menu-item"
onClick={logout}
aria-label={t.common.signOut}
>
<LogOut className="h-4 w-4" />
{t.common.signOut}
</Button>
)}
</div>
</div>
</TooltipProvider>
)
}