admin-valentin/openai-agents-python
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

adopted float instead of timedelta for timeout parameters (#874)

Browse source 
I replaced the `timedelta` parameters for MCP timeouts with `float`
values, addressing issue #845 .

Given that the MCP official repository has incorporated these changes in
[this PR](https://github.com/modelcontextprotocol/python-sdk/pull/941),
updating the MCP version in openai-agents and specifying the timeouts as
floats should be enough.
This commit is contained in:
Daniele Morotti 2025-06-16 17:35:09 +02:00 committed by GitHub
parent 6d2806f10c
commit 281a7b2bb6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 9 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
pyproject.toml
View file

@ -13,7 +13,7 @@ dependencies = [
"typing-extensions>=4.12.2, <5",
"requests>=2.0, <3",
"types-requests>=2.0, <3",
"mcp>=1.8.0, <2; python_version >= '3.10'",
"mcp>=1.9.4, <2; python_version >= '3.10'",
]
classifiers = [
"Typing :: Typed",

8
src/agents/mcp/server.py
View file

@ -340,10 +340,10 @@ class MCPServerStreamableHttpParams(TypedDict):
headers: NotRequired[dict[str, str]]
"""The headers to send to the server."""
timeout: NotRequired[timedelta]
timeout: NotRequired[timedelta | float]
"""The timeout for the HTTP request. Defaults to 5 seconds."""
sse_read_timeout: NotRequired[timedelta]
sse_read_timeout: NotRequired[timedelta | float]
"""The timeout for the SSE connection, in seconds. Defaults to 5 minutes."""
terminate_on_close: NotRequired[bool]
@ -401,8 +401,8 @@ class MCPServerStreamableHttp(_MCPServerWithClientSession):
return streamablehttp_client(
url=self.params["url"],
headers=self.params.get("headers", None),
timeout=self.params.get("timeout", timedelta(seconds=30)),
sse_read_timeout=self.params.get("sse_read_timeout", timedelta(seconds=60 * 5)),
timeout=self.params.get("timeout", 5),
sse_read_timeout=self.params.get("sse_read_timeout", 60 * 5),
terminate_on_close=self.params.get("terminate_on_close", True),
)

8
uv.lock
View file

@ -1047,7 +1047,7 @@ wheels = [
[[package]]
name = "mcp"
version = "1.8.1"
version = "1.9.4"
source = { registry = "https://pypi.org/simple" }
dependencies = [
{ name = "anyio", marker = "python_full_version >= '3.10'" },
@ -1060,9 +1060,9 @@ dependencies = [
{ name = "starlette", marker = "python_full_version >= '3.10'" },
{ name = "uvicorn", marker = "python_full_version >= '3.10' and sys_platform != 'emscripten'" },
]
sdist = { url = "https://files.pythonhosted.org/packages/7c/13/16b712e8a3be6a736b411df2fc6b4e75eb1d3e99b1cd57a3a1decf17f612/mcp-1.8.1.tar.gz", hash = "sha256:ec0646271d93749f784d2316fb5fe6102fb0d1be788ec70a9e2517e8f2722c0e", size = 265605 }
sdist = { url = "https://files.pythonhosted.org/packages/06/f2/dc2450e566eeccf92d89a00c3e813234ad58e2ba1e31d11467a09ac4f3b9/mcp-1.9.4.tar.gz", hash = "sha256:cfb0bcd1a9535b42edaef89947b9e18a8feb49362e1cc059d6e7fc636f2cb09f", size = 333294 }
wheels = [
{ url = "https://files.pythonhosted.org/packages/1c/5d/91cf0d40e40ae9ecf8d4004e0f9611eea86085aa0b5505493e0ff53972da/mcp-1.8.1-py3-none-any.whl", hash = "sha256:948e03783859fa35abe05b9b6c0a1d5519be452fc079dc8d7f682549591c1770", size = 119761 },
{ url = "https://files.pythonhosted.org/packages/97/fc/80e655c955137393c443842ffcc4feccab5b12fa7cb8de9ced90f90e6998/mcp-1.9.4-py3-none-any.whl", hash = "sha256:7fcf36b62936adb8e63f89346bccca1268eeca9bf6dfb562ee10b1dfbda9dac0", size = 130232 },
]
[[package]]
@ -1534,7 +1534,7 @@ requires-dist = [
{ name = "graphviz", marker = "extra == 'viz'", specifier = ">=0.17" },
{ name = "griffe", specifier = ">=1.5.6,<2" },
{ name = "litellm", marker = "extra == 'litellm'", specifier = ">=1.67.4.post1,<2" },
{ name = "mcp", marker = "python_full_version >= '3.10'", specifier = ">=1.8.0,<2" },
{ name = "mcp", marker = "python_full_version >= '3.10'", specifier = ">=1.9.4,<2" },
{ name = "numpy", marker = "python_full_version >= '3.10' and extra == 'voice'", specifier = ">=2.2.0,<3" },
{ name = "openai", specifier = ">=1.81.0" },
{ name = "pydantic", specifier = ">=2.10,<3" },