admin-valentin/agent-ecosystem
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

feat: add review status, all-tasks-completed and cross-team message notifications

Browse source 
- Detect review state transitions (kanbanColumn → review) in status change notifications
- Add "All tasks completed" notification when every task in a team reaches completed/deleted
- Add "Cross-team message" notification with separate toggle (source: cross_team in inbox)
- All three enabled by default with UI toggles in settings
This commit is contained in:
iliya 2026-03-16 14:32:03 +02:00
parent 48033ef701
commit 2131ad32d0
12 changed files with 172 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
src/main/index.ts
View file

@ -255,16 +255,27 @@ async function notifyNewInboxMessages(teamName: string, detail: string): Promise
const summary = msg.summary || extracted.summary;
const msgId = msg.timestamp ?? String(prevCount + i);
// Cross-team messages get their own event type and per-type toggle
const isCrossTeam = msg.source === 'cross_team';
const eventType: 'lead_inbox' | 'user_inbox' | 'cross_team_message' = isCrossTeam
? 'cross_team_message'
: isLeadInbox
? 'lead_inbox'
: 'user_inbox';
const effectiveSuppressToast = isCrossTeam
? !config.notifications.enabled || !config.notifications.notifyOnCrossTeamMessage
: suppressToast;
void notificationManager
.addTeamNotification({
teamEventType: isLeadInbox ? 'lead_inbox' : 'user_inbox',
teamEventType: eventType,
teamName,
teamDisplayName,
from: fromLabel,
summary,
body: extracted.body,
dedupeKey: `inbox:${teamName}:${memberName}:${msgId}`,
suppressToast,
suppressToast: effectiveSuppressToast,
})
.catch(() => undefined);
}

14
src/main/ipc/configValidation.ts
View file

@ -115,6 +115,8 @@ function validateNotificationsSection(
'notifyOnStatusChange',
'notifyOnTaskComments',
'notifyOnTaskCreated',
'notifyOnAllTasksCompleted',
'notifyOnCrossTeamMessage',
'statusChangeOnlySolo',
'statusChangeStatuses',
'triggers',
@ -185,6 +187,18 @@ function validateNotificationsSection(
}
result.notifyOnTaskCreated = value;
break;
case 'notifyOnAllTasksCompleted':
if (typeof value !== 'boolean') {
return { valid: false, error: `notifications.${key} must be a boolean` };
}
result.notifyOnAllTasksCompleted = value;
break;
case 'notifyOnCrossTeamMessage':
if (typeof value !== 'boolean') {
return { valid: false, error: `notifications.${key} must be a boolean` };
}
result.notifyOnCrossTeamMessage = value;
break;
case 'statusChangeOnlySolo':
if (typeof value !== 'boolean') {
return { valid: false, error: `notifications.${key} must be a boolean` };

2
src/main/services/error/ErrorMessageBuilder.ts
View file

@ -60,6 +60,8 @@ export interface DetectedError {
| 'task_status_change'
| 'task_comment'
| 'task_created'
| 'all_tasks_completed'
| 'cross_team_message'
| 'schedule_completed'
| 'schedule_failed';
/** Explicit key for storage deduplication. Two notifications with the same dedupeKey won't be stored twice. */

6
src/main/services/infrastructure/ConfigManager.ts
View file

@ -52,6 +52,10 @@ export interface NotificationConfig {
notifyOnTaskComments: boolean;
/** Whether to show native OS notifications when a new task is created */
notifyOnTaskCreated: boolean;
/** Whether to show native OS notifications when all tasks in a team are completed */
notifyOnAllTasksCompleted: boolean;
/** Whether to show native OS notifications for cross-team messages */
notifyOnCrossTeamMessage: boolean;
/** Only notify on status changes in solo teams (no teammates) */
statusChangeOnlySolo: boolean;
/** Which target statuses to notify about (e.g. ['in_progress', 'completed']) */
@ -267,6 +271,8 @@ const DEFAULT_CONFIG: AppConfig = {
notifyOnStatusChange: true,
notifyOnTaskComments: true,
notifyOnTaskCreated: true,
notifyOnAllTasksCompleted: true,
notifyOnCrossTeamMessage: true,
statusChangeOnlySolo: false,
statusChangeStatuses: ['in_progress', 'completed'],
triggers: DEFAULT_TRIGGERS,

4
src/main/utils/teamNotificationBuilder.ts
View file

@ -22,6 +22,8 @@ export type TeamEventType =
| 'task_status_change'
| 'task_comment'
| 'task_created'
| 'all_tasks_completed'
| 'cross_team_message'
| 'schedule_completed'
| 'schedule_failed';
@ -65,6 +67,8 @@ const TEAM_NOTIFICATION_CONFIG: Record<TeamEventType, TeamNotificationConfig> =
task_status_change: { triggerName: 'Status Change', triggerColor: 'purple' },
task_comment: { triggerName: 'Task Comment', triggerColor: 'cyan' },
task_created: { triggerName: 'Task Created', triggerColor: 'green' },
all_tasks_completed: { triggerName: 'All Done', triggerColor: 'green' },
cross_team_message: { triggerName: 'Cross-Team', triggerColor: 'cyan' },
schedule_completed: { triggerName: 'Schedule Done', triggerColor: 'green' },
schedule_failed: { triggerName: 'Schedule Failed', triggerColor: 'red' },
};

5
src/renderer/components/settings/hooks/useSettingsConfig.ts
View file

@ -48,6 +48,8 @@ export interface SafeConfig {
notifyOnStatusChange: boolean;
notifyOnTaskComments: boolean;
notifyOnTaskCreated: boolean;
notifyOnAllTasksCompleted: boolean;
notifyOnCrossTeamMessage: boolean;
statusChangeOnlySolo: boolean;
statusChangeStatuses: string[];
triggers: AppConfig['notifications']['triggers'];
@ -183,6 +185,9 @@ export function useSettingsConfig(): UseSettingsConfigReturn {
notifyOnStatusChange: displayConfig?.notifications?.notifyOnStatusChange ?? true,
notifyOnTaskComments: displayConfig?.notifications?.notifyOnTaskComments ?? true,
notifyOnTaskCreated: displayConfig?.notifications?.notifyOnTaskCreated ?? true,
notifyOnAllTasksCompleted:
displayConfig?.notifications?.notifyOnAllTasksCompleted ?? true,
notifyOnCrossTeamMessage: displayConfig?.notifications?.notifyOnCrossTeamMessage ?? true,
statusChangeOnlySolo: displayConfig?.notifications?.statusChangeOnlySolo ?? true,
statusChangeStatuses: displayConfig?.notifications?.statusChangeStatuses ?? [
'in_progress',

2
src/renderer/components/settings/hooks/useSettingsHandlers.ts
View file

@ -301,6 +301,8 @@ export function useSettingsHandlers({
notifyOnStatusChange: true,
notifyOnTaskComments: true,
notifyOnTaskCreated: true,
notifyOnAllTasksCompleted: true,
notifyOnCrossTeamMessage: true,
statusChangeOnlySolo: true,
statusChangeStatuses: ['in_progress', 'completed'],
triggers: defaultTriggers,

29
src/renderer/components/settings/sections/NotificationsSection.tsx
View file

@ -24,6 +24,8 @@ import {
MessageSquare,
PartyPopper,
CirclePlus,
CheckCircle2,
GitBranch,
Send,
Users,
Volume2,
@ -37,7 +39,7 @@ import type { NotificationTrigger } from '@renderer/types/data';
import type { TeamReviewState, TeamTaskStatus } from '@shared/types';
/** Notification targets span workflow status plus the explicit review axis. */
type NotifiableStatus = TeamTaskStatus | Extract<TeamReviewState, 'needsFix' | 'approved'>;
type NotifiableStatus = TeamTaskStatus | Extract<TeamReviewState, 'review' | 'needsFix' | 'approved'>;
// Snooze duration options
const SNOOZE_OPTIONS = [
@ -66,6 +68,8 @@ interface NotificationsSectionProps {
| 'notifyOnStatusChange'
| 'notifyOnTaskComments'
| 'notifyOnTaskCreated'
| 'notifyOnAllTasksCompleted'
| 'notifyOnCrossTeamMessage'
| 'statusChangeOnlySolo',
value: boolean
) => void;
@ -306,6 +310,28 @@ export const NotificationsSection = ({
disabled={saving || !safeConfig.notifications.enabled}
/>
</SettingRow>
<SettingRow
label="All tasks completed"
description="Notify when every task in a team reaches completed status"
icon={<CheckCircle2 className="size-4" />}
>
<SettingsToggle
enabled={safeConfig.notifications.notifyOnAllTasksCompleted}
onChange={(v) => onNotificationToggle('notifyOnAllTasksCompleted', v)}
disabled={saving || !safeConfig.notifications.enabled}
/>
</SettingRow>
<SettingRow
label="Cross-team message notifications"
description="Notify when a message arrives from another team"
icon={<GitBranch className="size-4" />}
>
<SettingsToggle
enabled={safeConfig.notifications.notifyOnCrossTeamMessage}
onChange={(v) => onNotificationToggle('notifyOnCrossTeamMessage', v)}
disabled={saving || !safeConfig.notifications.enabled}
/>
</SettingRow>
{/* Task Status Change Notifications — nested within team card */}
<div className="last:*:border-b-0">
@ -447,6 +473,7 @@ export const NotificationsSection = ({
const STATUS_OPTIONS: { value: NotifiableStatus; label: string }[] = [
{ value: 'in_progress', label: 'Started' },
{ value: 'completed', label: 'Completed' },
{ value: 'review', label: 'Review' },
{ value: 'needsFix', label: 'Needs Fixes' },
{ value: 'approved', label: 'Approved' },
{ value: 'pending', label: 'Pending' },

93
src/renderer/store/slices/teamSlice.ts
View file

@ -117,6 +117,7 @@ const notifiedClarificationTaskKeys = new Set<string>();
const notifiedStatusChangeKeys = new Set<string>();
const notifiedCommentKeys = new Set<string>();
const notifiedCreatedTaskKeys = new Set<string>();
const notifiedAllCompletedTeams = new Set<string>();
let isFirstFetchAllTasks = true;
@ -182,10 +183,11 @@ function detectStatusChangeNotifications(
const taskKanbanColumn = getTaskKanbanColumn(task);
const oldTaskKanbanColumn = getTaskKanbanColumn(oldTask);
const becameApproved = taskKanbanColumn === 'approved' && oldTaskKanbanColumn !== 'approved';
const becameReview = taskKanbanColumn === 'review' && oldTaskKanbanColumn !== 'review';
const becameNeedsFix = task.reviewState === 'needsFix' && oldTask.reviewState !== 'needsFix';
const statusChanged = oldTask.status !== task.status;
if (!statusChanged && !becameApproved && !becameNeedsFix) continue;
if (!statusChanged && !becameApproved && !becameReview && !becameNeedsFix) continue;
if (onlySolo) {
const team = teamByName[task.teamName];
@ -193,18 +195,24 @@ function detectStatusChangeNotifications(
}
// Resolve the effective status for notification matching
const effectiveStatus = becameApproved ? 'approved' : becameNeedsFix ? 'needsFix' : task.status;
const effectiveStatus = becameApproved
? 'approved'
: becameReview
? 'review'
: becameNeedsFix
? 'needsFix'
: task.status;
if (!statuses.includes(effectiveStatus)) continue;
const key = `${task.teamName}:${task.id}:${effectiveStatus}`;
if (notifiedStatusChangeKeys.has(key)) continue;
notifiedStatusChangeKeys.add(key);
const fromLabel = becameApproved ? 'Completed' : oldTask.status;
const fromLabel = becameApproved ? 'Completed' : becameReview ? 'Completed' : oldTask.status;
fireStatusChangeNotification(
task,
fromLabel,
becameApproved ? 'approved' : becameNeedsFix ? 'needsFix' : undefined,
becameApproved ? 'approved' : becameReview ? 'review' : becameNeedsFix ? 'needsFix' : undefined,
!statusChangeEnabled
);
}
@ -221,6 +229,7 @@ function fireStatusChangeNotification(
in_progress: 'In Progress',
completed: 'Completed',
deleted: 'Deleted',
review: 'Review',
needsFix: 'Needs Fixes',
approved: 'Approved',
};
@ -329,6 +338,64 @@ function fireTaskCreatedNotification(task: GlobalTask, suppressToast: boolean):
.catch(() => undefined);
}
function detectAllTasksCompletedNotification(
oldTasks: GlobalTask[],
newTasks: GlobalTask[],
notifyEnabled: boolean
): void {
// Group tasks by team
const teamTasks = new Map<string, GlobalTask[]>();
for (const task of newTasks) {
const list = teamTasks.get(task.teamName) ?? [];
list.push(task);
teamTasks.set(task.teamName, list);
}
for (const [teamName, tasks] of teamTasks) {
if (tasks.length === 0) continue;
const allCompleted = tasks.every((t) => t.status === 'completed' || t.status === 'deleted');
if (!allCompleted) {
// Reset so we can notify again if tasks become all-completed later
notifiedAllCompletedTeams.delete(teamName);
continue;
}
if (notifiedAllCompletedTeams.has(teamName)) continue;
// Check that at least one task was NOT completed before (real transition)
const oldTeamTasks = oldTasks.filter((t) => t.teamName === teamName);
const wasAlreadyAllCompleted =
oldTeamTasks.length > 0 &&
oldTeamTasks.every((t) => t.status === 'completed' || t.status === 'deleted');
if (wasAlreadyAllCompleted) {
notifiedAllCompletedTeams.add(teamName);
continue;
}
notifiedAllCompletedTeams.add(teamName);
fireAllTasksCompletedNotification(tasks[0], tasks.length, !notifyEnabled);
}
}
function fireAllTasksCompletedNotification(
sampleTask: GlobalTask,
taskCount: number,
suppressToast: boolean
): void {
void api.teams
?.showMessageNotification({
teamName: sampleTask.teamName,
teamDisplayName: sampleTask.teamDisplayName,
from: 'system',
to: 'user',
summary: `All ${taskCount} tasks completed`,
body: `All tasks in team "${sampleTask.teamDisplayName}" are done`,
teamEventType: 'all_tasks_completed',
dedupeKey: `all-done:${sampleTask.teamName}:${Date.now()}`,
suppressToast,
})
.catch(() => undefined);
}
function collectTaskChangeInvalidationState(
teamName: string,
prevTasks: TeamData['tasks'],
@ -888,6 +955,9 @@ export const createTeamSlice: StateCreator<AppState, [], [], TeamSlice> = (set,
detectTaskCommentNotifications(oldTasks, tasks, notifyOnTaskComments);
const notifyOnTaskCreated = get().appConfig?.notifications?.notifyOnTaskCreated ?? true;
detectTaskCreatedNotifications(oldTasks, tasks, notifyOnTaskCreated);
const notifyOnAllCompleted =
get().appConfig?.notifications?.notifyOnAllTasksCompleted ?? true;
detectAllTasksCompletedNotification(oldTasks, tasks, notifyOnAllCompleted);
} else {
// Initial load — seed the Sets to prevent false notifications on next update
for (const task of tasks) {
@ -901,6 +971,9 @@ export const createTeamSlice: StateCreator<AppState, [], [], TeamSlice> = (set,
if (getTaskKanbanColumn(task) === 'approved') {
notifiedStatusChangeKeys.add(`${task.teamName}:${task.id}:approved`);
}
if (getTaskKanbanColumn(task) === 'review') {
notifiedStatusChangeKeys.add(`${task.teamName}:${task.id}:review`);
}
// Seed comment keys to prevent false notifications
for (const comment of task.comments ?? []) {
notifiedCommentKeys.add(`${task.teamName}:${task.id}:${comment.id}`);
@ -908,6 +981,18 @@ export const createTeamSlice: StateCreator<AppState, [], [], TeamSlice> = (set,
// Seed created task keys to prevent false notifications
notifiedCreatedTaskKeys.add(`${task.teamName}:${task.id}`);
}
// Seed all-completed teams
const teamTasksMap = new Map<string, GlobalTask[]>();
for (const task of tasks) {
const list = teamTasksMap.get(task.teamName) ?? [];
list.push(task);
teamTasksMap.set(task.teamName, list);
}
for (const [teamName, teamTasks] of teamTasksMap) {
if (teamTasks.every((t) => t.status === 'completed' || t.status === 'deleted')) {
notifiedAllCompletedTeams.add(teamName);
}
}
}
set({

6
src/shared/types/notifications.ts
View file

@ -61,6 +61,8 @@ export interface DetectedError {
| 'task_status_change'
| 'task_comment'
| 'task_created'
| 'all_tasks_completed'
| 'cross_team_message'
| 'schedule_completed'
| 'schedule_failed';
/** Explicit key for storage deduplication. Two notifications with the same dedupeKey won't be stored twice. */
@ -274,6 +276,10 @@ export interface AppConfig {
notifyOnTaskComments: boolean;
/** Whether to show native OS notifications when a new task is created */
notifyOnTaskCreated: boolean;
/** Whether to show native OS notifications when all tasks in a team are completed */
notifyOnAllTasksCompleted: boolean;
/** Whether to show native OS notifications for cross-team messages */
notifyOnCrossTeamMessage: boolean;
/** Only notify on status changes in solo teams (no teammates) */
statusChangeOnlySolo: boolean;
/** Which target statuses to notify about (e.g. ['in_progress', 'completed']) */

2
src/shared/types/team.ts
View file

@ -713,7 +713,7 @@ export interface TeamMessageNotificationData {
/** Optional sender color for visual context. */
color?: string;
/** Team event sub-type for notification categorization. */
teamEventType?: 'task_clarification' | 'task_status_change' | 'task_comment' | 'task_created';
teamEventType?: 'task_clarification' | 'task_status_change' | 'task_comment' | 'task_created' | 'all_tasks_completed';
/** Stable key for storage deduplication. Required — no fallback to Date.now(). */
dedupeKey?: string;
/**

2
test/main/utils/teamNotificationBuilder.test.ts
View file

@ -94,6 +94,8 @@ describe('buildDetectedErrorFromTeam', () => {
task_status_change: { triggerName: 'Status Change', triggerColor: 'purple' },
task_comment: { triggerName: 'Task Comment', triggerColor: 'cyan' },
task_created: { triggerName: 'Task Created', triggerColor: 'green' },
all_tasks_completed: { triggerName: 'All Done', triggerColor: 'green' },
cross_team_message: { triggerName: 'Cross-Team', triggerColor: 'cyan' },
schedule_completed: { triggerName: 'Schedule Done', triggerColor: 'green' },
schedule_failed: { triggerName: 'Schedule Failed', triggerColor: 'red' },
};