admin-valentin/agent-ecosystem
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(opencode): keep Windows marker cleanup conservative

Browse source
This commit is contained in:
777genius 2026-05-16 09:15:35 +03:00
parent f3a01d173f
commit 31bfd5ebb3
2 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
src/main/services/team/opencode/bridge/OpenCodeManagedHostProcessCleanup.ts
View file

@ -102,7 +102,6 @@ export async function cleanupManagedOpenCodeServeProcesses(
isManagedByWindowsCommand || Boolean(details && isManagedOpenCodeServeProcessDetails(details)); isManagedByWindowsCommand || Boolean(details && isManagedOpenCodeServeProcessDetails(details));
const hasRequiredDetailsMarkers = const hasRequiredDetailsMarkers =
requiredDetailsMarkers.length === 0 || requiredDetailsMarkers.length === 0 ||
(isManagedByWindowsCommand && details === null) ||
Boolean(details && processDetailsIncludeMarkers(details, requiredDetailsMarkers)); Boolean(details && processDetailsIncludeMarkers(details, requiredDetailsMarkers));
if (!isManaged || !hasRequiredDetailsMarkers) { if (!isManaged || !hasRequiredDetailsMarkers) {
result.candidates.push({ result.candidates.push({

6
test/main/services/team/OpenCodeManagedHostProcessCleanup.test.ts
View file

@ -403,7 +403,7 @@ describe('OpenCodeManagedHostProcessCleanup', () => {
expect(result.diagnostics).toEqual([]); expect(result.diagnostics).toEqual([]);
}); });
it('does not require unreadable Windows details for app-managed command fallback cleanup', async () => { it('honors required markers when Windows details are unavailable', async () => {
const killProcess = vi.fn(); const killProcess = vi.fn();
const result = await cleanupManagedOpenCodeServeProcesses({ const result = await cleanupManagedOpenCodeServeProcesses({
@ -425,8 +425,8 @@ describe('OpenCodeManagedHostProcessCleanup', () => {
killProcess, killProcess,
}); });
expect(killProcess).toHaveBeenCalledWith(71629); expect(killProcess).not.toHaveBeenCalled();
expect(result.candidates[0]).toMatchObject({ pid: 71629, action: 'killed' }); expect(result.candidates[0]).toMatchObject({ pid: 71629, action: 'kept_unmanaged' });
expect(result.diagnostics).toEqual([]); expect(result.diagnostics).toEqual([]);
}); });