admin-valentin/agent-ecosystem
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: apply exact reviewer suggestions for MemberLogsTab

Browse source 
- Move endRefreshing() outside the !cancelled guard in finally block
  so it always runs even when the effect is torn down mid-refresh.
- Only call load() when isTabActive or on first load — prevents
  unnecessary fetches when a hidden tab's effect re-runs.
This commit is contained in:
Artem Rootman 2026-04-05 17:01:36 +00:00
parent 0e83d99e0a
commit e81116b85e
No known key found for this signature in database
GPG key ID: B7C30676209A822C
1 changed files with 4 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/renderer/components/team/members/MemberLogsTab.tsx
View file

@ -474,14 +474,16 @@ export const MemberLogsTab = ({
setError(e instanceof Error ? e.message : 'Unknown error'); setError(e instanceof Error ? e.message : 'Unknown error');
} }
} finally { } finally {
if (didBeginRefreshing) endRefreshing();
if (!cancelled) { if (!cancelled) {
setLoading(false); setLoading(false);
if (didBeginRefreshing) endRefreshing();
} }
} }
}; };
void load(); if (isTabActive || !hasLoadedRef.current) {
void load();
}
const interval = shouldAutoRefresh && isTabActive ? setInterval(() => void load(), 5000) : null; const interval = shouldAutoRefresh && isTabActive ? setInterval(() => void load(), 5000) : null;